Changeset 6178 for branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive/3.4/ExperimentManager/HiveJobDownloader.cs

Timestamp:

05/10/11 17:58:59 (13 years ago)

Author:

cneumuel

Message:

#1233

• added semaphores to ensure an appdomain is never unloaded when the start method has not finished
• HiveEngine uploading and downloading of jobs works and is displayed in the view

File:

• branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive/3.4/ExperimentManager/HiveJobDownloader.cs (modified) (6 diffs)

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive/3.4/ExperimentManager/HiveJobDownloader.cs

@@ -30 +30 @@
   public class HiveJobDownloader {
     private IEnumerable<Guid> jobIds;
-    private JobDownloader<ItemJob> jobDownloader;
+    private ConcurrentJobDownloader<ItemJob> jobDownloader;
     private IDictionary<Guid, HiveJob> results;
 
     public bool IsFinished {
       get {
-        //return tasks.TrueForAll(t => t.Status == TaskStatus.RanToCompletion ||
-        //                             t.Status == TaskStatus.Faulted ||
-        //                             t.Status == TaskStatus.Canceled);
         return results.Count == jobIds.Count();
       }
@@ -44 +41 @@
     public int FinishedCount {
       get {
-        //var faulted = tasks.Where(t => t.Status == TaskStatus.Faulted);
-        //if (faulted.Count() > 0) {
-        //  abort = true;
-        //  throw faulted.First().Exception;
-        //}
-        //return tasks.Count(t => t.Status == TaskStatus.RanToCompletion ||
-        //                        t.Status == TaskStatus.Faulted ||
-        //                        t.Status == TaskStatus.Canceled);
         return results.Count;
       }
@@ -58 +47 @@
     public IDictionary<Guid, HiveJob> Results {
       get {
-        //var results = new Dictionary<Guid, HiveJob>();
-        //foreach (var t in tasks) {
-        //  if (t.Status == TaskStatus.Faulted) {
-        //    throw t.Exception;
-        //  }
-        //  if (t.Result != null)
-        //    results.Add(t.Result.Job.Id, t.Result);
-        //}
         return results;
       }
@@ -72 +53 @@
     public HiveJobDownloader(IEnumerable<Guid> jobIds) {
       this.jobIds = jobIds;
-      this.jobDownloader = new JobDownloader<ItemJob>(2, 2);
+      this.jobDownloader = new ConcurrentJobDownloader<ItemJob>(2, 2);
       this.results = new Dictionary<Guid, HiveJob>();
     }
@@ -81 +62 @@
           (id, itemJob, exception) => {
             if (exception != null) {
-              throw new JobDownloaderException("Downloading job failed", exception);
+              throw new ConcurrentJobDownloaderException("Downloading job failed", exception);
             }
             Job job = ServiceLocator.Instance.CallHiveService(s => s.GetJob(id));
@@ -95 +76 @@
             }
           });
-      }
-
-      //tasks = new List<Task<HiveJob>>();
-      //TaskScheduler.UnobservedTaskException += new EventHandler<UnobservedTaskExceptionEventArgs>(TaskScheduler_UnobservedTaskException);
-      //foreach (Guid jobId in jobIds) {
-      //  tasks.Add(Task<JobData>.Factory.StartNew(
-      //    (x) => DownloadJob(x), jobId)
-      //    .ContinueWith((x) => DeserializeJob(x.Result)));
-      //}
+      }      
     }
-
-    //private void TaskScheduler_UnobservedTaskException(object sender, UnobservedTaskExceptionEventArgs e) {
-    //  e.SetObserved(); // avoid crash of process because task crashes. first exception found is handled in Results property
-    //}
-
-    //// use semaphore to ensure only few concurrenct connections and few SerializedJob objects in memory
-    //private Semaphore downloadSemaphore = new Semaphore(2, 2);
-    //private Semaphore deserializeSemaphore = new Semaphore(2, 2);
-    //protected JobData DownloadJob(object jobId) {
-    //  downloadSemaphore.WaitOne();
-    //  deserializeSemaphore.WaitOne();
-    //  JobData result;
-    //  try {
-    //    if (abort) return null;
-    //    result = ServiceLocator.Instance.CallHiveService(s => s.GetJobData((Guid)jobId));
-    //  }
-    //  finally {
-    //    downloadSemaphore.Release();
-    //  }
-    //  return result;
-    //}
-
-    //protected HiveJob DeserializeJob(JobData jobData) {
-    //  try {
-    //    Job job = ServiceLocator.Instance.CallHiveService(s => s.GetJob(jobData.JobId));
-    //    if (abort || job == null || jobData == null) return null;
-
-    //    HiveJob hiveJob;
-    //    var itemJob = PersistenceUtil.Deserialize<ItemJob>(jobData.Data);
-    //    if (itemJob is OptimizerJob) {
-    //      hiveJob = new OptimizerHiveJob((OptimizerJob)itemJob);
-    //    } else {
-    //      hiveJob = new HiveJob(itemJob, true);
-    //    }
-    //    jobData.Data = null; // reduce memory consumption.
-    //    hiveJob.Job = job;
-    //    return hiveJob;
-    //  }
-    //  finally {
-    //    deserializeSemaphore.Release();
-    //  }
-    //}
   }
 }