Changeset 5237 for trunk/sources/HeuristicLab.Core.Views/3.3/ItemCollectionView.cs

Timestamp:

01/08/11 01:47:47 (13 years ago)

Author:

swagner

Message:

#1324:

• Added performance optimization in all other item collection views
• Checked and refactored item event registration/deregistration
• Enabled null items in item collection views
• Moved non-default Dispose methods from designer files into user files

File:

• trunk/sources/HeuristicLab.Core.Views/3.3/ItemCollectionView.cs (modified) (11 diffs)

trunk/sources/HeuristicLab.Core.Views/3.3/ItemCollectionView.cs

@@ -34 +34 @@
   [Content(typeof(IItemCollection<>), false)]
   public partial class ItemCollectionView<T> : ItemView where T : class, IItem {
-    private Dictionary<T, List<ListViewItem>> listViewItemMapping;
+    protected Dictionary<T, List<ListViewItem>> itemListViewItemMapping;
     protected TypeSelectorDialog typeSelectorDialog;
 
@@ -48 +48 @@
     public ItemCollectionView() {
       InitializeComponent();
-      listViewItemMapping = new Dictionary<T, List<ListViewItem>>();
+      itemListViewItemMapping = new Dictionary<T, List<ListViewItem>>();
+    }
+
+    protected override void Dispose(bool disposing) {
+      if (disposing) {
+        if (typeSelectorDialog != null) typeSelectorDialog.Dispose();
+        if (components != null) components.Dispose();
+      }
+      base.Dispose(disposing);
     }
 
@@ -55 +63 @@
       Content.ItemsRemoved -= new CollectionItemsChangedEventHandler<T>(Content_ItemsRemoved);
       Content.CollectionReset -= new CollectionItemsChangedEventHandler<T>(Content_CollectionReset);
-      foreach (T item in listViewItemMapping.Keys) {
-        item.ItemImageChanged -= new EventHandler(Item_ItemImageChanged);
-        item.ToStringChanged -= new EventHandler(Item_ToStringChanged);
+      foreach (T item in itemListViewItemMapping.Keys) {
+        DeregisterItemEvents(item);
       }
       base.DeregisterContentEvents();
@@ -67 +74 @@
       Content.CollectionReset += new CollectionItemsChangedEventHandler<T>(Content_CollectionReset);
     }
+    protected virtual void DeregisterItemEvents(T item) {
+      item.ItemImageChanged -= new EventHandler(Item_ItemImageChanged);
+      item.ToStringChanged -= new EventHandler(Item_ToStringChanged);
+    }
+    protected virtual void RegisterItemEvents(T item) {
+      item.ItemImageChanged += new EventHandler(Item_ItemImageChanged);
+      item.ToStringChanged += new EventHandler(Item_ToStringChanged);
+    }
 
     protected override void OnContentChanged() {
       base.OnContentChanged();
-      while (itemsListView.Items.Count > 0) RemoveListViewItem(itemsListView.Items[0]);
+      itemsListView.Items.Clear();
+      itemListViewItemMapping.Clear();
       RebuildImageList();
       viewHost.Content = null;
@@ -112 +128 @@
         try {
           return (T)typeSelectorDialog.TypeSelector.CreateInstanceOfSelectedType();
-        } catch (Exception ex) {
+        }
+        catch (Exception ex) {
           ErrorHandling.ShowErrorDialog(this, ex);
         }
@@ -120 +137 @@
     protected virtual ListViewItem CreateListViewItem(T item) {
       ListViewItem listViewItem = new ListViewItem();
-      listViewItem.Text = item.ToString();
-      listViewItem.ToolTipText = item.ItemName + ": " + item.ItemDescription;
-      listViewItem.Tag = item;
-      itemsListView.SmallImageList.Images.Add(item.ItemImage);
-      listViewItem.ImageIndex = itemsListView.SmallImageList.Images.Count - 1;
+      if (item == null) {
+        listViewItem.Text = "null";
+        itemsListView.SmallImageList.Images.Add(HeuristicLab.Common.Resources.VS2008ImageLibrary.Nothing);
+        listViewItem.ImageIndex = itemsListView.SmallImageList.Images.Count - 1;
+      } else {
+        listViewItem.Text = item.ToString();
+        listViewItem.ToolTipText = item.ItemName + ": " + item.ItemDescription;
+        itemsListView.SmallImageList.Images.Add(item.ItemImage);
+        listViewItem.ImageIndex = itemsListView.SmallImageList.Images.Count - 1;
+        listViewItem.Tag = item;
+      }
       return listViewItem;
     }
@@ -130 +153 @@
       T item = (listViewItem.Tag as T);
       itemsListView.Items.Add(listViewItem);
-      if (!listViewItemMapping.ContainsKey(item)) {
-        item.ItemImageChanged += new EventHandler(Item_ItemImageChanged);
-        item.ToStringChanged += new EventHandler(Item_ToStringChanged);
-        listViewItemMapping.Add(item, new List<ListViewItem>());
-      }
-      listViewItemMapping[item].Add(listViewItem);
+      if (item != null) {
+        if (!itemListViewItemMapping.ContainsKey(item)) {
+          RegisterItemEvents(item);
+          itemListViewItemMapping.Add(item, new List<ListViewItem>());
+        }
+        itemListViewItemMapping[item].Add(listViewItem);
+      }
       sortAscendingButton.Enabled = itemsListView.Items.Count > 1;
       sortDescendingButton.Enabled = itemsListView.Items.Count > 1;
@@ -141 +165 @@
     protected virtual void RemoveListViewItem(ListViewItem listViewItem) {
       T item = (listViewItem.Tag as T);
-      listViewItemMapping[item].Remove(listViewItem);
-      if (listViewItemMapping[item].Count == 0) {
-        listViewItemMapping.Remove(item);
-        item.ItemImageChanged -= new EventHandler(Item_ItemImageChanged);
-        item.ToStringChanged -= new EventHandler(Item_ToStringChanged);
+      if (item != null) {
+        itemListViewItemMapping[item].Remove(listViewItem);
+        if (itemListViewItemMapping[item].Count == 0) {
+          itemListViewItemMapping.Remove(item);
+          DeregisterItemEvents(item);
+        }
       }
       listViewItem.Remove();
@@ -152 +177 @@
     }
     protected virtual void UpdateListViewItemImage(ListViewItem listViewItem) {
+      T item = listViewItem.Tag as T;
       int i = listViewItem.ImageIndex;
-      listViewItem.ImageList.Images[i] = ((T)listViewItem.Tag).ItemImage;
+      listViewItem.ImageList.Images[i] = item == null ? HeuristicLab.Common.Resources.VS2008ImageLibrary.Nothing : item.ItemImage;
       listViewItem.ImageIndex = -1;
       listViewItem.ImageIndex = i;
     }
     protected virtual void UpdateListViewItemText(ListViewItem listViewItem) {
-      if (!listViewItem.Text.Equals(listViewItem.Tag.ToString()))
-        listViewItem.Text = listViewItem.Tag.ToString();
+      T item = listViewItem.Tag as T;
+      listViewItem.Text = item == null ? "null" : item.ToString();
+      listViewItem.ToolTipText = item == null ? string.Empty : item.ItemName + ": " + item.ItemDescription;
     }
     protected virtual IEnumerable<ListViewItem> GetListViewItemsForItem(T item) {
-      return listViewItemMapping[item];
+      if (item == null) {
+        List<ListViewItem> listViewItems = new List<ListViewItem>();
+        foreach (ListViewItem listViewItem in itemsListView.Items) {
+          if (listViewItem.Tag == null) listViewItems.Add(listViewItem);
+        }
+        return listViewItems;
+      } else {
+        return itemListViewItemMapping[item];
+      }
     }
 
@@ -190 +225 @@
     protected virtual void itemsListView_DoubleClick(object sender, EventArgs e) {
       if (itemsListView.SelectedItems.Count == 1) {
-        T item = (T)itemsListView.SelectedItems[0].Tag;
-        IContentView view = MainFormManager.MainForm.ShowContent(item);
-        if (view != null) {
-          view.ReadOnly = ReadOnly;
-          view.Locked = Locked;
+        T item = itemsListView.SelectedItems[0].Tag as T;
+        if (item != null) {
+          IContentView view = MainFormManager.MainForm.ShowContent(item);
+          if (view != null) {
+            view.ReadOnly = ReadOnly;
+            view.Locked = Locked;
+          }
         }
       }
@@ -201 +238 @@
       if (!Locked) {
         ListViewItem listViewItem = (ListViewItem)e.Item;
-        T item = (T)listViewItem.Tag;
-        DataObject data = new DataObject();
-        data.SetData("Type", item.GetType());
-        data.SetData("Value", item);
-        if (Content.IsReadOnly || ReadOnly) {
-          DoDragDrop(data, DragDropEffects.Copy | DragDropEffects.Link);
-        } else {
-          DragDropEffects result = DoDragDrop(data, DragDropEffects.Copy | DragDropEffects.Link | DragDropEffects.Move);
-          if ((result & DragDropEffects.Move) == DragDropEffects.Move)
-            Content.Remove(item);
+        T item = listViewItem.Tag as T;
+        if (item != null) {
+          DataObject data = new DataObject();
+          data.SetData("Type", item.GetType());
+          data.SetData("Value", item);
+          if (Content.IsReadOnly || ReadOnly) {
+            DoDragDrop(data, DragDropEffects.Copy | DragDropEffects.Link);
+          } else {
+            DragDropEffects result = DoDragDrop(data, DragDropEffects.Copy | DragDropEffects.Link | DragDropEffects.Move);
+            if ((result & DragDropEffects.Move) == DragDropEffects.Move)
+              Content.Remove(item);
+          }
         }
       }