Changeset 4121 for branches/3.3-HiveMigration/sources/HeuristicLab.Hive/HeuristicLab.Hive.Experiment/3.3/HiveExperiment.cs

Timestamp:

07/30/10 13:56:28 (14 years ago)

Author:

cneumuel

Message:

Stabilization of Hive, Improvement HiveExperiment GUI (#1115)

File:

• branches/3.3-HiveMigration/sources/HeuristicLab.Hive/HeuristicLab.Hive.Experiment/3.3/HiveExperiment.cs (modified) (15 diffs)

branches/3.3-HiveMigration/sources/HeuristicLab.Hive/HeuristicLab.Hive.Experiment/3.3/HiveExperiment.cs

@@ -52 +52 @@
     private const string itemName = "Hive Experiment";
     private const string itemDescription = "An experiment which contains multiple batch runs of algorithms which are executed in the Hive.";
-    private const int resultPollingIntervalMs = 10000;
+    private const int resultPollingIntervalMs = 15000;
 
     private object locker = new object();
@@ -128 +128 @@
 
     public override IDeepCloneable Clone(Cloner cloner) {
-      log.LogMessage("I am beeing cloned");
+      LogMessage("I am beeing cloned");
       HiveExperiment clone = (HiveExperiment)base.Clone(cloner);
       clone.resourceIds = this.resourceIds;
@@ -148 +148 @@
     private void AfterDeserialization() {
       InitTimer();
-      log.LogMessage("I was deserialized.");
+      LogMessage("I was deserialized.");
     }
 
@@ -224 +224 @@
           ResponseObject<JobDto> response = executionEngineFacade.AddJobWithGroupStrings(serializedJob, groups);
           pendingOptimizers.Add(response.Obj.Id, optimizer);
-          StartResultPollingThread(response.Obj);
 
           JobItem jobItem = new JobItem() {
@@ -236 +235 @@
           jobItems.Add(jobItem);
 
-          log.LogMessage("Sent job to server (jobId: " + response.Obj.Id + ")");
+          LogMessage("Sent job to server (jobId: " + response.Obj.Id + ")");
+        }
+
+        // start results polling after sending sending the jobs to the server (to avoid race conflicts at the optimizers-collection)
+        foreach (JobItem jobItem in jobItems) {
+          StartResultPollingThread(jobItem.JobDto);
         }
       });
@@ -256 +260 @@
 
     private void ReplaceOptimizer(IOptimizer originalOptimizer, IOptimizer newOptimizer) {
-      int originalOptimizerIndex = experiment.Optimizers.IndexOf(originalOptimizer);
-      experiment.Optimizers[originalOptimizerIndex] = newOptimizer;
+      lock (locker) {
+        int originalOptimizerIndex = experiment.Optimizers.IndexOf(originalOptimizer);
+        experiment.Optimizers[originalOptimizerIndex] = newOptimizer;
+      }
     }
 
@@ -308 +314 @@
         do {
           Thread.Sleep(resultPollingIntervalMs);
-          lock (locker) {
+          //lock (locker) { [chn] try without locking for better performance
             if (stopPending) return;
-            
-            ResponseObject<SerializedJob> response = executionEngineFacade.GetLastSerializedResult(job.Id, false, false);
-            log.LogMessage("Received response for job: " + response.StatusMessage + " (jobId: " + job.Id + ")");
-            
+
+            ResponseObject<JobDto> response = executionEngineFacade.GetJobById(job.Id);
+            LogMessage("Response: " + response.StatusMessage + " (jobId: " + job.Id + ")");
+
+            if (response.Obj != null) {
+              UpdateJobItem(response.Obj);
+            }
             
             // loop while 
@@ -320 +329 @@
             // 3. no result for the job is available yet (response.Obj==null)
             // 4. the result that we get from the server is a snapshot and not the final result
-            if (response.Success && response.Obj != null && response.StatusMessage != ApplicationConstants.RESPONSE_JOB_RESULT_NOT_YET_HERE) {
-              restoredObject = XmlParser.Deserialize<IJob>(new MemoryStream(response.Obj.SerializedJobData));
+            if (response.Success && response.Obj != null && response.Obj.State == State.Finished) {
+              ResponseObject<SerializedJob> jobResponse = executionEngineFacade.GetLastSerializedResult(job.Id, false, false);
+              restoredObject = XmlParser.Deserialize<IJob>(new MemoryStream(jobResponse.Obj.SerializedJobData));
+              UpdateSnapshot(jobResponse);
             }
-          }
+          //}
         } while (restoredObject == null || restoredObject.ExecutionState != Core.ExecutionState.Stopped);
 
-        log.LogMessage("Job finished (jobId: " + job.Id + ")");
+        LogMessage("Job finished (jobId: " + job.Id + ")");
         // job retrieved... replace the existing optimizers with the finished one
         IOptimizer originalOptimizer = pendingOptimizers[job.Id];
@@ -340 +351 @@
         }
       });
-
-      Logger.Debug("HiveEngine: Starting results-polling thread");
       t.Start();
+    }
+
+    private void UpdateJobItem(JobDto jobDto) {
+      JobItem jobItem = jobItems.Single(x => x.JobDto.Id == jobDto.Id);
+      jobItem.JobDto = jobDto;
+    }
+
+    private void UpdateSnapshot(ResponseObject<SerializedJob> response) {
+      JobItem jobItem = jobItems.Single(x => x.JobDto.Id == response.Obj.JobInfo.Id);
+      jobItem.LatestSnapshot = response;
+    }
+
+    private void LogMessage(string message) {
+      // HeuristicLab.Log is not Thread-Safe, so lock every call
+      lock (locker) {
+        log.LogMessage(message);
+      }
     }
     
@@ -440 +466 @@
     public event EventHandler ExecutionStateChanged;
     private void OnExecutionStateChanged() {
-      log.LogMessage("ExecutionState changed to " + executionState.ToString());
+      LogMessage("ExecutionState changed to " + executionState.ToString());
       EventHandler handler = ExecutionStateChanged;
       if (handler != null) handler(this, EventArgs.Empty);
@@ -449 +475 @@
     public event EventHandler Started;
     private void OnStarted() {
-      log.LogMessage("Started");
+      LogMessage("Started");
       timer.Start();
       EventHandler handler = Started;
@@ -458 +484 @@
     private void OnStopped() {
       timer.Stop();
-      log.LogMessage("Stopped");
+      LogMessage("Stopped");
       EventHandler handler = Stopped;
       if (handler != null) handler(this, EventArgs.Empty);
@@ -466 +492 @@
     private void OnPaused() {
       timer.Stop();
-      log.LogMessage("Paused");
+      LogMessage("Paused");
       EventHandler handler = Paused;
       if (handler != null) handler(this, EventArgs.Empty);
@@ -473 +499 @@
     public event EventHandler Prepared;
     protected virtual void OnPrepared() {
-      log.LogMessage("Prepared");
+      LogMessage("Prepared");
       EventHandler handler = Prepared;
       if (handler != null) handler(this, EventArgs.Empty);
@@ -486 +512 @@
     public event EventHandler ExperimentChanged;
     protected virtual void OnExperimentChanged() {
-      log.LogMessage("Experiment changed");
+      LogMessage("Experiment changed");
       EventHandler handler = ExperimentChanged;
       if (handler != null) handler(this, EventArgs.Empty);