Changeset 4092 for branches/3.3-HiveMigration/sources/HeuristicLab.Hive/HeuristicLab.Hive.Server.Core/3.3/ClientCommunicator.cs

Timestamp:

07/23/10 14:17:20 (14 years ago)

Author:

cneumuel

Message:

replaced transaction- and context management from Spring-advice by custom context management (see ContextFactory) (#1098)

File:

• branches/3.3-HiveMigration/sources/HeuristicLab.Hive/HeuristicLab.Hive.Server.Core/3.3/ClientCommunicator.cs (modified) (7 diffs)

branches/3.3-HiveMigration/sources/HeuristicLab.Hive/HeuristicLab.Hive.Server.Core/3.3/ClientCommunicator.cs

@@ -40 +40 @@
   public class ClientCommunicator : IClientCommunicator,
     IInternalClientCommunicator {
-    private static Dictionary<Guid, DateTime> lastHeartbeats =
-      new Dictionary<Guid, DateTime>();
-    private static Dictionary<Guid, int> newAssignedJobs =
-      new Dictionary<Guid, int>();
-    private static Dictionary<Guid, int> pendingJobs =
-      new Dictionary<Guid, int>();
-
-    private static ReaderWriterLockSlim heartbeatLock =
-      new ReaderWriterLockSlim(LockRecursionPolicy.SupportsRecursion);
+    private static Dictionary<Guid, DateTime> lastHeartbeats = new Dictionary<Guid, DateTime>();
+    private static Dictionary<Guid, int> newAssignedJobs = new Dictionary<Guid, int>();
+    private static Dictionary<Guid, int> pendingJobs = new Dictionary<Guid, int>();
+
+    private static ReaderWriterLockSlim heartbeatLock = new ReaderWriterLockSlim(LockRecursionPolicy.SupportsRecursion);
 
     //private ISessionFactory factory;
@@ -81 +77 @@
       Logger.Debug("Server Heartbeat ticked");
 
+      // [chn] why is transaction management done here
       using (TransactionScope scope = new TransactionScope(TransactionScopeOption.Required, new TransactionOptions { IsolationLevel = ApplicationConstants.ISOLATION_LEVEL_SCOPE })) {
-
         List<ClientDto> allClients = new List<ClientDto>(DaoLocator.ClientDao.FindAll());
 
@@ -144 +140 @@
         }
         CheckForPendingJobs();
-        DaoLocator.DestroyContext();
+//        DaoLocator.DestroyContext();
         scope.Complete();
       }
@@ -595 +591 @@
     }
 
-
     /// <summary>
     /// the client can send job results during calculating 
@@ -616 +611 @@
     }
 
-
     public ResponseResultReceived ProcessSnapshot(Guid clientId, Guid jobId, byte[] result, double percentage, Exception exception) {
       return ProcessJobResult(clientId, jobId, result, percentage, exception, false);
@@ -628 +622 @@
     /// <returns></returns>                       
     public Response Logout(Guid clientId) {
-
       Logger.Info("Client logged out " + clientId);
 
@@ -720 +713 @@
 
       return response;
-
     }