Changeset 3627 for trunk/sources/HeuristicLab.PluginInfrastructure/Advanced/UploadPluginsView.cs

Timestamp:

05/05/10 11:37:57 (14 years ago)

Author:

gkronber

Message:

Refactored class names and fixed a dependency-selection bug. #994 (Clean up plugin infrastructure project)

File:

• trunk/sources/HeuristicLab.PluginInfrastructure/Advanced/UploadPluginsView.cs (moved) (moved from trunk/sources/HeuristicLab.PluginInfrastructure/Advanced/PluginEditor.cs) (5 diffs)

trunk/sources/HeuristicLab.PluginInfrastructure/Advanced/UploadPluginsView.cs

@@ -34 +34 @@
 
 namespace HeuristicLab.PluginInfrastructure.Advanced {
-  internal partial class PluginEditor : InstallationManagerControl {
+  internal partial class UploadPluginsView : InstallationManagerControl {
     private const string UploadMessage = "Uploading plugins...";
     private const string RefreshMessage = "Downloading plugin information from deployment service...";
@@ -48 +48 @@
     }
 
-    public PluginEditor() {
+    public UploadPluginsView() {
       InitializeComponent();
       pluginImageList.Images.Add(HeuristicLab.PluginInfrastructure.Resources.Resources.plugin_16);
@@ -192 +192 @@
           if (!modifiedPlugins.Contains(plugin))
             modifiedPlugins.Add(plugin);
-          foreach (var dep in GetAllDependencies(plugin)) {
+          foreach (var dep in Util.GetAllDependencies(plugin)) {
             if (!modifiedPlugins.Contains(dep))
               modifiedPlugins.Add(dep);
@@ -204 +204 @@
           if (!modifiedPlugins.Contains(plugin))
             modifiedPlugins.Add(plugin);
-          foreach (var dep in GetAllDependents(plugin)) {
+          foreach (var dep in Util.GetAllDependents(plugin, localAndServerPlugins.Keys)) {
             if (!modifiedPlugins.Contains(dep))
               modifiedPlugins.Add(dep);
@@ -242 +242 @@
       Util.ResizeColumns(listView.Columns.OfType<ColumnHeader>());
       ignoreItemCheckedEvents = false;
-    }
-
-    private IEnumerable<IPluginDescription> GetAllDependents(IPluginDescription plugin) {
-      return from p in localAndServerPlugins.Keys
-             let matchingEntries = from dep in GetAllDependencies(p)
-                                   where dep.Name == plugin.Name
-                                   where dep.Version == plugin.Version
-                                   select dep
-             where matchingEntries.Any()
-             select p;
-    }
-
-    private IEnumerable<IPluginDescription> GetAllDependencies(IPluginDescription plugin) {
-      foreach (var dep in plugin.Dependencies) {
-        foreach (var recDep in GetAllDependencies(dep)) {
-          yield return recDep;
-        }
-        yield return dep;
-      }
     }