Changeset 3627 for trunk/sources/HeuristicLab.PluginInfrastructure/Advanced/InstalledPluginsView.cs

Timestamp:

05/05/10 11:37:57 (15 years ago)

Author:

gkronber

Message:

Refactored class names and fixed a dependency-selection bug. #994 (Clean up plugin infrastructure project)

File:

• trunk/sources/HeuristicLab.PluginInfrastructure/Advanced/InstalledPluginsView.cs (moved) (moved from trunk/sources/HeuristicLab.PluginInfrastructure/Advanced/LocalPluginsView.cs) (3 diffs)

trunk/sources/HeuristicLab.PluginInfrastructure/Advanced/InstalledPluginsView.cs

@@ -34 +34 @@
 
 namespace HeuristicLab.PluginInfrastructure.Advanced {
-  internal partial class LocalPluginsView : InstallationManagerControl {
+  internal partial class InstalledPluginsView : InstallationManagerControl {
     private const string CheckingPluginsMessage = "Checking for updated plugins...";
     private const string NoUpdatesAvailableMessage = "No updates available.";
@@ -58 +58 @@
     }
 
-    public LocalPluginsView()
+    public InstalledPluginsView()
       : base() {
       InitializeComponent();
@@ -171 +171 @@
         List<ListViewItem> modifiedItems = new List<ListViewItem>();
         foreach (ListViewItem item in localPluginsListView.SelectedItems) {
-          var plugin = (IPluginDescription)item.Tag;
           modifiedItems.Add(item);
-          // also uncheck all dependent plugins
-          foreach (ListViewItem dependentItem in localPluginsListView.Items) {
-            var dependent = (IPluginDescription)dependentItem.Tag;
-            if (!dependentItem.Checked && (from dep in dependent.Dependencies
-                                           where dep.Name == plugin.Name
-                                           where dep.Version == plugin.Version
-                                           select dep).Any()) {
-              modifiedItems.Add(dependentItem);
+          int oldItemsCount = 0;
+          while (oldItemsCount < modifiedItems.Count) {
+            oldItemsCount = modifiedItems.Count;
+            var oldModifiedItems = new List<ListViewItem>(modifiedItems);
+            foreach (var modifiedItem in oldModifiedItems) {
+              var plugin = (IPluginDescription)modifiedItem.Tag;
+              // also check all dependent plugins
+              foreach (ListViewItem dependentItem in localPluginsListView.Items) {
+                var dependent = (IPluginDescription)dependentItem.Tag;
+                if (!modifiedItems.Contains(dependentItem) &&
+                  !dependentItem.Checked && (from dep in dependent.Dependencies
+                                             where dep.Name == plugin.Name
+                                             where dep.Version == plugin.Version
+                                             select dep).Any()) {
+                  modifiedItems.Add(dependentItem);
+                }
+              }
             }
           }