Changeset 3627 for trunk/sources/HeuristicLab.PluginInfrastructure/Advanced/EditProductsView.cs

Timestamp:

05/05/10 11:37:57 (14 years ago)

Author:

gkronber

Message:

Refactored class names and fixed a dependency-selection bug. #994 (Clean up plugin infrastructure project)

File:

• trunk/sources/HeuristicLab.PluginInfrastructure/Advanced/EditProductsView.cs (moved) (moved from trunk/sources/HeuristicLab.PluginInfrastructure/Advanced/ProductEditor.cs) (5 diffs)

trunk/sources/HeuristicLab.PluginInfrastructure/Advanced/EditProductsView.cs

@@ -32 +32 @@
 
 namespace HeuristicLab.PluginInfrastructure.Advanced {
-  internal partial class ProductEditor : InstallationManagerControl {
+  internal partial class EditProductsView : InstallationManagerControl {
     private const string RefreshMessage = "Downloading product and plugin information...";
     private const string UploadMessage = "Uploading product and plugin information...";
@@ -45 +45 @@
     private HashSet<DeploymentService.ProductDescription> dirtyProducts;
 
-    public ProductEditor() {
+    public EditProductsView() {
       InitializeComponent();
 
@@ -384 +384 @@
           if (!modifiedPlugins.Contains(plugin))
             modifiedPlugins.Add(plugin);
-          foreach (var dep in GetAllDependencies(plugin)) {
+          foreach (var dep in Util.GetAllDependencies(plugin)) {
             if (!modifiedPlugins.Contains(dep))
               modifiedPlugins.Add(dep);
@@ -397 +397 @@
           if (!modifiedPlugins.Contains(plugin))
             modifiedPlugins.Add(plugin);
-          foreach (var dep in GetAllDependents(plugin)) {
+          foreach (var dep in Util.GetAllDependents(plugin, plugins.Cast<IPluginDescription>())) {
             if (!modifiedPlugins.Contains(dep))
               modifiedPlugins.Add(dep);
@@ -412 +412 @@
 
     #region helper
-    private IEnumerable<IPluginDescription> GetAllDependents(IPluginDescription plugin) {
-      return from p in plugins
-             let matchingEntries = from dep in GetAllDependencies(p)
-                                   where dep.Name == plugin.Name
-                                   where dep.Version == plugin.Version
-                                   select dep
-             where matchingEntries.Any()
-             select p as IPluginDescription;
-    }
-
-    private IEnumerable<IPluginDescription> GetAllDependencies(IPluginDescription plugin) {
-      HashSet<IPluginDescription> yieldedPlugins = new HashSet<IPluginDescription>();
-      foreach (var dep in plugin.Dependencies) {
-        foreach (var recDep in GetAllDependencies(dep)) {
-          if (!yieldedPlugins.Contains(recDep)) {
-            yieldedPlugins.Add(recDep);
-            yield return recDep;
-          }
-        }
-        if (!yieldedPlugins.Contains(dep)) {
-          yieldedPlugins.Add(dep);
-          yield return dep;
-        }
-      }
-    }
     private void MarkProductDirty(HeuristicLab.PluginInfrastructure.Advanced.DeploymentService.ProductDescription activeProduct) {
       if (!dirtyProducts.Contains(activeProduct)) {