Changeset 3577 for trunk/sources/HeuristicLab.Persistence/3.3/Default/CompositeSerializers/Storable/StorableSerializer.cs

Timestamp:

05/01/10 12:37:16 (15 years ago)

Author:

epitzer

Message:

throw Exception if class is marked [Storable] but cannot be serialized with the StorableSerializer (#548)

File:

• trunk/sources/HeuristicLab.Persistence/3.3/Default/CompositeSerializers/Storable/StorableSerializer.cs (modified) (3 diffs)

trunk/sources/HeuristicLab.Persistence/3.3/Default/CompositeSerializers/Storable/StorableSerializer.cs

@@ -39 +39 @@
     /// </returns>
     public bool CanSerialize(Type type) {
+      bool markedStorable = StorableReflection.HasStorableClassAttribute(type);
       if (GetConstructor(type) == null)
-        return false;
-      return StorableReflection.IsEmptyOrStorableType(type, true);
+        if (markedStorable)
+          throw new Exception("[Storable] type has no default constructor and no [StorableConstructor]");
+        else
+          return false;
+      if (!StorableReflection.IsEmptyOrStorableType(type, true))
+        if (markedStorable)
+          throw new Exception("[Storable] type has non emtpy, non [Storable] base classes");
+        else
+          return false;
+      return true;
     }
 
@@ -53 +62 @@
     /// </returns>
     public string JustifyRejection(Type type) {
+      StringBuilder sb = new StringBuilder();
       if (GetConstructor(type) == null)
-        return "no default constructor and no storable constructor";
+        sb.Append("class has no default constructor and no [StorableConstructor]");
       if (!StorableReflection.IsEmptyOrStorableType(type, true))
-        return "class is not marked with the storable class attribute";
-      return "no reason";
+        sb.Append("class (or one of its bases) is not empty and not marked [Storable]; ");      
+      return sb.ToString();
     }
 
@@ -154 +164 @@
 
     private Dictionary<HookDesignator, List<StorableReflection.Hook>> hookCache =
-      new Dictionary<HookDesignator, List<StorableReflection.Hook>>();
+      new Dictionary<HookDesignator, List<StorableReflection.Hook>>();    
 
     #endregion