Changeset 3179 for trunk/sources/HeuristicLab.PluginAdministrator/3.3/PluginListView.cs

Timestamp:

03/22/10 16:53:27 (14 years ago)

Author:

gkronber

Message:

Improved controls for deployment service interaction.
Increased max values for message sizes and related limits in the deployment service configuration.
Recreated proxy classes for the deployment service.

#891 (Refactor GUI for plugin management)

File:

• trunk/sources/HeuristicLab.PluginAdministrator/3.3/PluginListView.cs (modified) (6 diffs)

trunk/sources/HeuristicLab.PluginAdministrator/3.3/PluginListView.cs

@@ -47 +47 @@
     }
 
-    private List<IPluginDescription> checkedPlugins = new List<IPluginDescription>();
+    private Dictionary<IPluginDescription, bool> checkedPlugins = new Dictionary<IPluginDescription, bool>();
     public IEnumerable<IPluginDescription> CheckedPlugins {
       get {
-        return checkedPlugins;
+        return from pair in checkedPlugins
+               where pair.Value
+               select pair.Key;
       }
     }
@@ -77 +79 @@
     private ListViewItem CreateListViewItem(IPluginDescription plugin) {
       var item = new ListViewItem(new string[] { plugin.Name, plugin.Version.ToString() });
-      item.Checked = (from p in checkedPlugins where p.Name == plugin.Name where p.Version == plugin.Version select p).Any();
+      item.Checked = checkedPlugins.ContainsKey(plugin) ? checkedPlugins[plugin] : false;
       item.Tag = plugin;
       return item;
@@ -89 +91 @@
           // also check all dependencies
           MarkPluginChecked(plugin);
-          modifiedPlugins.Add(plugin);
+          if (!modifiedPlugins.Contains(plugin))
+            modifiedPlugins.Add(plugin);
           foreach (var dep in GetAllDependencies(plugin)) {
             MarkPluginChecked(dep);
-            modifiedPlugins.Add(dep);
+            if (!modifiedPlugins.Contains(dep))
+              modifiedPlugins.Add(dep);
           }
         }
@@ -102 +106 @@
           // also uncheck all dependent plugins
           MarkPluginUnchecked(plugin);
-          modifiedPlugins.Add(plugin);
+          if (!modifiedPlugins.Contains(plugin))
+            modifiedPlugins.Add(plugin);
           foreach (var dep in GetAllDependents(plugin)) {
             MarkPluginUnchecked(dep);
-            modifiedPlugins.Add(dep);
+            if (!modifiedPlugins.Contains(dep))
+              modifiedPlugins.Add(dep);
           }
 
@@ -115 +121 @@
 
     private void MarkPluginChecked(IPluginDescription plugin) {
-      var matching = from p in checkedPlugins
-                     where p.Name == plugin.Name
-                     where p.Version == plugin.Version
-                     select p;
-      if (!matching.Any()) checkedPlugins.Add(plugin);
+      checkedPlugins[plugin] = true;
     }
 
     private void MarkPluginUnchecked(IPluginDescription plugin) {
-      checkedPlugins = (from p in checkedPlugins
-                        where p.Name != plugin.Name ||
-                              p.Version != plugin.Version
-                        select p).ToList();
+      checkedPlugins[plugin] = false;
     }
 
@@ -148 +147 @@
 
     private IEnumerable<IPluginDescription> GetAllDependencies(IPluginDescription plugin) {
+      HashSet<IPluginDescription> yieldedPlugins = new HashSet<IPluginDescription>();
       foreach (var dep in plugin.Dependencies) {
         foreach (var recDep in GetAllDependencies(dep)) {
-          yield return recDep;
+          if (!yieldedPlugins.Contains(recDep)) {
+            yieldedPlugins.Add(recDep);
+            yield return recDep;
+          }
         }
-        yield return dep;
+        if (!yieldedPlugins.Contains(dep)) {
+          yieldedPlugins.Add(dep);
+          yield return dep;
+        }
       }
     }