Changeset 2559

Timestamp:

12/15/09 13:22:12 (14 years ago)

Author:

mkommend

Message:

fixed memory leak in VariableImpactCalculators by cloning the IPredictor (ticket #815)

Location:

trunk/sources/HeuristicLab.Modeling/3.2

Files:

• VariableEvaluationImpactCalculator.cs (modified) (2 diffs)
• VariableQualityImpactCalculator.cs (modified) (2 diffs)

trunk/sources/HeuristicLab.Modeling/3.2/VariableEvaluationImpactCalculator.cs

@@ -84 +84 @@
       Dictionary<string, double> evaluationImpacts = new Dictionary<string, double>();
       Dataset dirtyDataset = (Dataset)dataset.Clone();
+      IPredictor dirtyPredictor = (IPredictor)predictor.Clone();
       double[] referenceValues = predictor.Predict(dataset, start, end);
 
@@ -100 +101 @@
             mean = dataset.GetMean(variableName, start, end);
             oldValues = dirtyDataset.ReplaceVariableValues(variableName, Enumerable.Repeat(mean, end - start), start, end);
-            newValues = predictor.Predict(dirtyDataset, start, end);
+            newValues = dirtyPredictor.Predict(dirtyDataset, start, end);
             evaluationImpacts[variableName] = 1 - CalculateVAF(referenceValues, newValues);
             dirtyDataset.ReplaceVariableValues(variableName, oldValues, start, end);

trunk/sources/HeuristicLab.Modeling/3.2/VariableQualityImpactCalculator.cs

@@ -83 +83 @@
       Dictionary<string, double> evaluationImpacts = new Dictionary<string, double>();
       Dataset dirtyDataset = (Dataset)dataset.Clone();
+      IPredictor dirtyPredictor = (IPredictor)predictor.Clone();
 
       double[] predictedValues = predictor.Predict(dataset, start, end);
@@ -104 +105 @@
           mean = dataset.GetMean(variableName, start, end);
           oldValues = dirtyDataset.ReplaceVariableValues(variableName, Enumerable.Repeat(mean, end - start), start, end);
-          predictedValues = predictor.Predict(dirtyDataset, start, end);
+          predictedValues = dirtyPredictor.Predict(dirtyDataset, start, end);
           newMSE = CalculateMSE(predictedValues, targetValues);
           evaluationImpacts[variableName] = newMSE / oldMSE;