Changeset 17444 for branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface.OptimizerIntegration/ViewModels/JsonItemVMBase.cs

Timestamp:

02/18/20 16:28:53 (4 years ago)

Author:

dpiringe

Message:

#3026:

• added two new methods in IJsonItem -> FixatePath and LoosenPath to fixate/loosen the path (to enable name changing without effects on path)
• set IsInRange to virtual and made overrides for IntMatrixJsonItem and DoubleMatrixJsonItem (IsInRange is a bad name and needs to be renamed in future versions)
• implemented basic validation feedback with ErrorProvider for some inputs (templateName, Name, Range)
• now all items gets validated before export (validation errors are shown with ErrorHandling.ShowErrorDialog)
• added a check in AlgorithmConverter to prevent an exception for accessing the first element of an empty IEnumerable

File:

• branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface.OptimizerIntegration/ViewModels/JsonItemVMBase.cs (modified) (3 diffs)

branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface.OptimizerIntegration/ViewModels/JsonItemVMBase.cs

@@ -9 +9 @@
 
 namespace HeuristicLab.JsonInterface.OptimizerIntegration {
-  public class JsonItemVMBase : INotifyPropertyChanged {
+  public class JsonItemVMBase : INotifyPropertyChanged, IDisposable {
     public event PropertyChangedEventHandler PropertyChanged;
     public event Action ItemChanged;
@@ -17 +17 @@
       get => item;
       set {
+        item?.LoosenPath();
         item = value;
+        item.FixatePath();
         ItemChanged?.Invoke();
       }
@@ -80 +82 @@
     }
 
+    #region IDisposable Support
+    private bool disposedValue = false; // To detect redundant calls
+
+    protected virtual void Dispose(bool disposing) {
+      if (!disposedValue) {
+        if (disposing) {
+          item.LoosenPath();
+          item = null;
+        }
+        disposedValue = true;
+      }
+    }
+
+    // This code added to correctly implement the disposable pattern.
+    public void Dispose() {
+      // Do not change this code. Put cleanup code in Dispose(bool disposing) above.
+      Dispose(true);
+    }
+    #endregion
   }
 }