Changeset 17374 for branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/Converters/ParameterizedItemConverter.cs

Timestamp:

12/06/19 14:39:00 (4 years ago)

Author:

dpiringe

Message:

#3026:

• extended the BaseConverter class to set the type of the extracted value and removed the assignment of type in all other converters
• fixed a bug in ConfigurableConverter -> now it correctly iterates through all items from an IEnumerable and calls the extract callback
• MultiCheckedOperatorConverter:
  • deleted unnecessary code line
  • now adds operators to parameters (instead of operator list, because the operator list will get removed in a future commit)
  • does not set the path of its added items anymore
• ParameterBaseConverter removed unnecessary code lines
• deleted ParameterBaseConverter
• reimplemented StorableConverter to test it again (still not really useable, because it bloats the template massively)
• fixed a pathing bug in ValueParameterConverter (extended ValueRangeConverter, ValueTypeArrayConverter, ValueTypeMatrixConverter, ValueTypeValueConverter to archive this)
• JCGenerator now only writes a single array with parameters (only FreeParameters) and saves a .hl File to test a new type of implementation of the whole JsonInterface
• fixed a bug in JsonItem -> now it replaces the name in path of the item (not the whole path as it was before)

File:

• branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/Converters/ParameterizedItemConverter.cs (modified) (1 diff)

branches/3026_IntegrationIntoSymSpace/HeuristicLab.JsonInterface/Converters/ParameterizedItemConverter.cs

@@ -20 +20 @@
     public override JsonItem ExtractData(IItem value) {
       JsonItem item = new JsonItem();
-      item.Name = value.ItemName;
-      item.Type = value.GetType().AssemblyQualifiedName;
+      var parameterizedItem = value as IParameterizedItem;
 
-      foreach (var param in value.Cast<IParameterizedItem>().Parameters) {
-        JsonItem data = JsonItemConverter.Extract(param);
-        data.Name = param.Name;
-        
-        if (item.Parameters == null)
-          item.Parameters = new List<JsonItem>();
-        item.Parameters.Add(data);
+      foreach (var param in parameterizedItem.Parameters) {
+        if(!param.Hidden) {
+          JsonItem data = JsonItemConverter.Extract(param);
+          //data.Name = param.Name;
+
+          if (item.Parameters == null)
+            item.Parameters = new List<JsonItem>();
+          item.Parameters.Add(data);
+        }
       }
       return item;