Changeset 16993 for branches/2924_DotNetCoreMigration/HeuristicLab.PluginInfrastructure/3.3/Isolation/RunnerHost.cs

Timestamp:

05/29/19 12:16:15 (5 years ago)

Author:

dpiringe

Message:

#2924:

• added IEnumerable<T> GetInstances<T>(params object[] args) where T: class and IEnumerable<object> GetInstances(Type type, params object[] args) method to IApplicationManager and implemented them in LightweightApplicationManager -> to instantiate types with specific constructor arguments
• added RunnerState State { get; } property in IRunnerHost, was already in RunnerHost
• added user authentication for NativeRunnerHost
• added optional check for a running docker daemon and available image for type DockerRunnerHost + Exception DockerException
• added caching of the saved IApplication in ApplicationRunner to prevent a new instance every get call
• removed System.ServiceModel.Primitives NuGet package
• lots of formatting

File:

• branches/2924_DotNetCoreMigration/HeuristicLab.PluginInfrastructure/3.3/Isolation/RunnerHost.cs (modified) (3 diffs)

branches/2924_DotNetCoreMigration/HeuristicLab.PluginInfrastructure/3.3/Isolation/RunnerHost.cs

@@ -74 +74 @@
           UserName = string.IsNullOrEmpty(UserName) ? null : UserName,
           PasswordInClearText = string.IsNullOrEmpty(Password) ? null : Password,
-          Domain = string.IsNullOrEmpty(Domain) ? null: Domain,
+          Domain = string.IsNullOrEmpty(Domain) ? null : Domain,
           WorkingDirectory = Directory.GetCurrentDirectory()
         },
@@ -86 +86 @@
       Runner.Serialize(runner, process.StandardInput.BaseStream);
 
+      process.BeginOutputReadLine();
+      process.BeginErrorReadLine();
+
       if (!runner.QuietMode) {
-        process.BeginOutputReadLine();
-        process.BeginErrorReadLine();
         process.OutputDataReceived += (s, e) => Console.WriteLine(e.Data);
         process.ErrorDataReceived += (s, e) => Console.WriteLine(e.Data);
@@ -124 +125 @@
     /// When the child process gets finished without requested cancellation, the linked token gets cancelled and a result set. 
     /// </summary>
-    /// <param name="token"></param>
-    /// <returns></returns>
     private Task<bool> RegisterCancellation(CancellationToken token) {
       if (process != null && State == RunnerState.Starting) {