Changeset 16117 for trunk/HeuristicLab.Clients.Hive.Administrator/3.3/Views/ProjectsView.cs

Timestamp:

08/30/18 11:32:56 (6 years ago)

Author:

jkarder

Message:

#2839: merged [15377-16116/branches/2839_HiveProjectManagement] into trunk

Location:

trunk

Files:

• . (modified) (1 prop)
• HeuristicLab.Clients.Hive.Administrator (modified) (1 prop)
• HeuristicLab.Clients.Hive.Administrator/3.3/Views/ProjectsView.cs (copied) (copied from branches/HiveProjectManagement/HeuristicLab.Clients.Hive.Administrator/3.3/Views/ProjectsView.cs) (20 diffs)

trunk/HeuristicLab.Clients.Hive.Administrator/3.3/Views/ProjectsView.cs

@@ -1 +1 @@
 #region License Information
 /* HeuristicLab
- * Copyright (C) 2002-2017 Heuristic and Evolutionary Algorithms Laboratory (HEAL)
+ * Copyright (C) 2002-2018 Heuristic and Evolutionary Algorithms Laboratory (HEAL)
  *
  * This file is part of HeuristicLab.
@@ -40 +40 @@
     private const int greenFlagImageIndex = 0;
     private const int redFlagImageIndex = 1;
-
-    private readonly Color changedColor = Color.FromArgb(255, 87, 191, 193); // #57bfc1
-    private readonly Color selectedColor = Color.FromArgb(255, 240, 194, 59); // #f0c23b
+    private const string SELECTED_TAG = ""; // " [selected]";
+    private const string NOT_STORED_TAG = "*"; // " [not stored]";
+    private const string CHANGES_NOT_STORED_TAG = "*"; // " [changes not stored]";
+
+    private readonly Color selectedBackColor = Color.DodgerBlue;
+    private readonly Color selectedForeColor = Color.White;
+    private readonly Color grayTextColor = SystemColors.GrayText;
+
     private Project selectedProject = null;
+    public Project SelectedProject {
+      get { return selectedProject; }
+      set { if (selectedProject != value) ChangeSelectedProject(value); }
+    }
 
     private readonly object locker = new object();
@@ -92 +101 @@
         projectPermissionsView.Content = null;
         projectResourcesView.Content = null;
+        projectJobsView.Content = null;
+        selectedProject = null;
       } else {
-        var top = BuildProjectTree(Content);
-        projectView.Content = top;
-        projectPermissionsView.Content = top;
-        projectResourcesView.Content = top;
-
-        if(top != null && top.Id == Guid.Empty) {
-          projectPermissionsView.Locked = true;
-          projectResourcesView.Locked = true;
-        }
+        BuildProjectTree(Content);
       }
     }
@@ -107 +110 @@
     protected override void SetEnabledStateOfControls() {
       base.SetEnabledStateOfControls();
-      bool enabled = Content != null && !ReadOnly;
-      refreshButton.Enabled = enabled;
-      addButton.Enabled = enabled;
-      removeButton.Enabled = enabled;
-      saveProjectButton.Enabled = enabled;
-      projectView.Enabled = enabled;
-      projectPermissionsView.Enabled = enabled;
-      projectResourcesView.Enabled = enabled;
+      bool selectedProjectExists = selectedProject != null && selectedProject.Id != Guid.Empty && Content.Contains(selectedProject);
+      bool projectIsNew = selectedProject != null && selectedProject.Id == Guid.Empty;
+      bool locked = Content == null || selectedProject == null || Locked || ReadOnly;
+      bool parentOwner = HiveAdminClient.Instance.CheckOwnershipOfParentProject(selectedProject, UserInformation.Instance.User.Id);
+      bool saveLocked = locked || (!IsAdmin() && selectedProject.OwnerUserId != UserInformation.Instance.User.Id && !parentOwner);
+      bool addLocked = saveLocked || projectIsNew || selectedProject.Id == Guid.Empty;
+      bool deleteLocked = locked || (!IsAdmin() && !parentOwner) || Content.Where(x => x.ParentProjectId == selectedProject.Id).Any();
+
+      var now = DateTime.Now;
+      if (!addLocked && (now < selectedProject.StartDate || now > selectedProject.EndDate)) addLocked = true;
+
+      addButton.Enabled = !addLocked;
+      removeButton.Enabled = !deleteLocked;
+      saveProjectButton.Enabled = !saveLocked;
+      projectView.Enabled = !locked;
+      projectPermissionsView.Enabled = !locked;
+      projectResourcesView.Enabled = !locked;
+      projectJobsView.Enabled = !locked;
+
+      projectView.Locked = locked;
+      projectPermissionsView.Locked = locked;
+      projectResourcesView.Locked = locked;
+      projectJobsView.Locked = locked;
     }
     #endregion
@@ -194 +212 @@
     }
 
-    private void addButton_Click(object sender, EventArgs e) {
-      Guid? parentProjectId = null;
-
+    private void addButton_Click(object sender, EventArgs e) {      
+
+      if (selectedProject == null && !IsAdmin()) {
+        MessageBox.Show(
+          "You are not allowed to add a root project - please select a parent project.",
+          "HeuristicLab Hive Administrator",
+          MessageBoxButtons.OK,
+          MessageBoxIcon.Information);
+        return;
+      }
+      
       if (selectedProject != null && selectedProject.Id == Guid.Empty) {
         MessageBox.Show(
@@ -206 +232 @@
       }
 
-      if (selectedProject != null) parentProjectId = selectedProject.Id;
       var project = new Project {
         Name = "New Project",
-        OwnerUserId = UserInformation.Instance.User.Id,
-        ParentProjectId = parentProjectId
+        OwnerUserId = UserInformation.Instance.User.Id,        
       };
-
-      selectedProject = project;
+      if(selectedProject != null) {
+        project.ParentProjectId = selectedProject.Id;
+        project.EndDate = selectedProject.EndDate;
+      }
+
+      SelectedProject = project;
       Content.Add(project);
     }
@@ -221 +249 @@
 
       lock (locker) {
+        // for details go to ChangeSelectedProject(..)
         if (!removeButton.Enabled) return;
         removeButton.Enabled = false;
       }
 
-      if(!IsAdmin() 
-        && HiveAdminClient.Instance.CheckOwnershipOfParentProject(selectedProject, 
-          UserInformation.Instance.User.Id)) {
+      // double check of ChangeSelectedProject(..):
+      // if the user is no admin nor owner of a parent project
+      if (!IsAdmin() && !HiveAdminClient.Instance.CheckOwnershipOfParentProject(selectedProject, UserInformation.Instance.User.Id)) {
         MessageBox.Show(
-          "Only subprojects of owned projects can be deleted.",
+          "Only admins and owners of parent projects are allowed to delete this project.",
           "HeuristicLab Hive Administrator",
           MessageBoxButtons.OK,
           MessageBoxIcon.Error);
         return;
-      }
-
-      if (!IsAdmin() && Content.Any(x => x.ParentProjectId == selectedProject.Id)) {
+      }            
+
+
+      if (Content.Any(x => x.ParentProjectId == selectedProject.Id) 
+          || HiveAdminClient.Instance.ProjectDescendants[selectedProject.Id].Any()) {
         MessageBox.Show(
           "Only empty projects can be deleted.",
@@ -245 +276 @@
       }
 
+      if (HiveAdminClient.Instance.Jobs.ContainsKey(selectedProject.Id) 
+        && HiveAdminClient.Instance.Jobs[selectedProject.Id] != null 
+        && HiveAdminClient.Instance.Jobs[selectedProject.Id].Any()) {
+        MessageBox.Show(
+          "There are " + HiveAdminClient.Instance.Jobs[selectedProject.Id].Count + " job(s) using this project and/or child-projects. It is necessary to delete them before the project.",
+          "HeuristicLab Hive Administrator",
+          MessageBoxButtons.OK,
+          MessageBoxIcon.Error);
+        return;
+      }
+
       var result = MessageBox.Show(
         "Do you really want to delete " + selectedProject.Name + "?",
@@ -253 +295 @@
       if (result == DialogResult.Yes) {
         await SecurityExceptionUtil.TryAsyncAndReportSecurityExceptions(
-          action: () => RemoveProject(selectedProject),
+          action: () => {
+            RemoveProject(selectedProject);  
+          },
           finallyCallback: () => {
             removeButton.Enabled = true;
           });
+      } else {
+        removeButton.Enabled = true;
       }
     }
@@ -268 +314 @@
       await SecurityExceptionUtil.TryAsyncAndReportSecurityExceptions(
         action: () => {
+          //if (selectedProject != null && selectedProject.Id == Guid.Empty)
+          //  SelectedProject = HiveAdminClient.Instance.GetAvailableProjectAncestors(selectedProject.Id).LastOrDefault();
           var projectsToSave = Content.Where(x => x.Id == Guid.Empty || x.Modified);
           foreach (var project in projectsToSave)
             project.Store();
+          
           UpdateProjects();
         },
@@ -278 +327 @@
     }
 
-    private void projectsTreeView_AfterSelect(object sender, TreeViewEventArgs e) {
-      ChangeSelectedProjectNode(e.Node);
-
-      //if (projectView.Content != null)
-      //  projectView.Content.PropertyChanged -= ProjectViewContent_PropertyChanged;
-
-      projectView.Content = selectedProject;
-      projectPermissionsView.Content = selectedProject;
-      projectResourcesView.Content = selectedProject;
-
-      //if (selectedProject != null)
-      //  selectedProject.PropertyChanged += ProjectViewContent_PropertyChanged;
+    private void projectsTreeView_MouseDown(object sender, MouseEventArgs e) {
+      var node = projectsTreeView.GetNodeAt(e.Location);
+      if (node == null) return;
+      var p = (Project)node.Tag;
+      if(!HiveAdminClient.Instance.DisabledParentProjects.Contains(p)) ChangeSelectedProjectNode(node);
+    }
+
+    private void projectsTreeView_BeforeSelect(object sender, TreeViewCancelEventArgs e) {
+      e.Cancel = true;
     }
 
     private void projectsTreeView_DragDrop(object sender, DragEventArgs e) {
+      if (e.Effect == DragDropEffects.None) return;
+
       var sourceNode = (TreeNode)e.Data.GetData(typeof(TreeNode));
       if (sourceNode == null) return;
-      var sourceResource = ((Project)sourceNode.Tag);
-      if (sourceResource == null) return;
+      var sourceProject = ((Project)sourceNode.Tag);
+      if (sourceProject == null) return;
 
       var treeView = (TreeView)sender;
@@ -304 +352 @@
       var targetNode = treeView.GetNodeAt(targetPoint);
 
-      if (sourceNode == targetNode) return;
       var targetProject = (targetNode != null) ? (Project)targetNode.Tag : null;
 
-      if(targetProject != null && targetProject.Id == Guid.Empty) {
+      if (!HiveAdminClient.Instance.CheckParentChange(sourceProject, targetProject)) {
         MessageBox.Show(
-          "You cannot drag projects to a not yet stored project.",
+          "You cannot drag projects to this project.",
           "HeuristicLab Hive Administrator",
           MessageBoxButtons.OK,
           MessageBoxIcon.Information);
-            return;
+        return;
       }
 
@@ -320 +367 @@
       } else {
         sourceNode.Parent.Nodes.Remove(sourceNode);
-        sourceResource.ParentProjectId = null;
+        sourceProject.ParentProjectId = null;
       }
 
@@ -327 +374 @@
       } else if(targetProject.Id != Guid.Empty) {
         targetNode.Nodes.Add(sourceNode);
-        sourceResource.ParentProjectId = targetProject.Id;
-      }
-
-      selectedProject = sourceResource;
+        sourceProject.ParentProjectId = targetProject.Id;
+      }
+
+      SelectedProject = sourceProject;
       OnContentChanged();
     }
@@ -340 +387 @@
     }
 
-    private void projectsTreeView_DragEnter(object sender, DragEventArgs e) {
+    private void projectsTreeView_DragEnterOver(object sender, DragEventArgs e) {
       e.Effect = DragDropEffects.Move;
-    }
-
-    private void projectsTreeView_DragOver(object sender, DragEventArgs e) {
-      e.Effect = DragDropEffects.Move;
+
+      var sourceNode = (TreeNode)e.Data.GetData(typeof(TreeNode));
+      var sourceProject = ((Project)sourceNode.Tag);
+
+      var targetPoint = projectsTreeView.PointToClient(new Point(e.X, e.Y));
+      var targetNode = projectsTreeView.GetNodeAt(targetPoint);
+      var targetProject = (targetNode != null) ? (Project)targetNode.Tag : null;
+
+      if ((!IsAdmin() && (targetNode == null || targetProject == null))
+      || sourceNode == null
+      || sourceProject == null
+      || sourceNode == targetNode
+      || !HiveAdminClient.Instance.CheckParentChange(sourceProject, targetProject)) {
+        e.Effect = DragDropEffects.None;
+      }
     }
 
@@ -354 +412 @@
 
     #region Helpers
-    private void ResetTreeNodes(TreeNodeCollection nodes, Color c1, Color c2, bool resetText) {
-      foreach (TreeNode n in nodes) {
-        var pro = ((Project)n.Tag);
-        if (n.BackColor.Equals(c1)) {
-          n.BackColor = c2;
-        }
-        if (resetText) {
-          n.Text = pro.Name;
-
-          if (pro.Id == Guid.Empty) {
-            n.Text += " [not stored]";
-          } else if (pro.Modified) {
-            n.Text += " [changes not stored]";
-          }
-        }
-        if (n.Nodes.Count > 0) {
-          ResetTreeNodes(n.Nodes, c1, c2, resetText);
-        }
-      }
-    }
-
-    private void ChangeSelectedProjectNode(TreeNode projectNode) {
-      selectedProject = (Project)projectNode.Tag;
-      ResetTreeNodes(projectsTreeView.Nodes, selectedColor, Color.Transparent, true);
-      projectNode.BackColor = selectedColor;
-      projectNode.Text += " [selected]";
-    }
-
-    private Project BuildProjectTree(IEnumerable<Project> projects) {
+    private void BuildProjectTree(IEnumerable<Project> projects) {
       projectsTreeView.Nodes.Clear();
-      if (!projects.Any()) return null;
-
+      if (!projects.Any()) return;
+
+      var disabledParentProjects = HiveAdminClient.Instance.DisabledParentProjects;
       var mainProjects = new HashSet<Project>(projects.Where(x => x.ParentProjectId == null));
-      var parentedMainProjects = new HashSet<Project>(projects
-        .Where(x => x.ParentProjectId.HasValue
-        && !projects.Select(y => y.Id).Contains(x.ParentProjectId.Value)));
-            mainProjects.UnionWith(parentedMainProjects);
-      var subProbjects = new HashSet<Project>(projects.Except(mainProjects));
+      //var parentedMainProjects = new HashSet<Project>(projects
+      //  .Where(x => x.ParentProjectId.HasValue
+      //  && !projects.Select(y => y.Id).Contains(x.ParentProjectId.Value)));
+      //mainProjects.UnionWith(parentedMainProjects);
+      var mainDisabledParentProjects = new HashSet<Project>(disabledParentProjects.Where(x => x.ParentProjectId == null || x.ParentProjectId == Guid.Empty));
+      mainProjects.UnionWith(mainDisabledParentProjects);
+      var subProbjects = new HashSet<Project>(projects.Union(disabledParentProjects).Except(mainProjects));
 
       var stack = new Stack<Project>(mainProjects.OrderByDescending(x => x.Name));
-      if (selectedProject != null) selectedProject = projects.Where(x => x.Id == selectedProject.Id).FirstOrDefault();
+      if (selectedProject != null) SelectedProject = projects.Where(x => x.Id == selectedProject.Id).FirstOrDefault();
       bool nodeSelected = false;
 
       TreeNode currentNode = null;
       Project currentProject = null;
-      
+
       while (stack.Any()) {
         var newProject = stack.Pop();
         var newNode = new TreeNode(newProject.Name) { Tag = newProject };
-
-        if (newProject.Id == Guid.Empty) {
-          newNode.Text += " [not stored]";
-        } else if(newProject.Modified) {
-          newNode.Text += " [changes not stored]";
-        }
-        if (selectedProject == null) {
-          selectedProject = newProject;
-        }
-        if (newProject.Id == selectedProject.Id && !nodeSelected) {
-          newNode.BackColor = selectedColor;
-          newNode.Text += " [selected]";
+        StyleTreeNode(newNode, newProject);
+      
+        if (selectedProject == null && !disabledParentProjects.Contains(newProject)) {
+          SelectedProject = newProject;
+        }
+        if (!nodeSelected && selectedProject != null && selectedProject.Id == newProject.Id) {
+          newNode.BackColor = selectedBackColor;
+          newNode.ForeColor = selectedForeColor;
+          newNode.Text += SELECTED_TAG;
           nodeSelected = true;
         }
@@ -435 +465 @@
 
         newNode.SelectedImageIndex = newNode.ImageIndex;
+
+        if (disabledParentProjects.Contains(newProject)) {
+          newNode.Checked = false;
+          newNode.ForeColor = grayTextColor;
+        }
 
         var childProjects = subProbjects.Where(x => x.ParentProjectId == newProject.Id);
@@ -448 +483 @@
 
       projectsTreeView.ExpandAll();
-
-      return selectedProject;
+    }
+
+    private void StyleTreeNode(TreeNode n, Project p) {
+      n.Text = p.Name;
+      n.BackColor = Color.Transparent;
+      n.ForeColor = Color.Black;
+
+      if (HiveAdminClient.Instance.DisabledParentProjects.Select(x => x.Id).Contains(p.Id)) {
+        n.ForeColor = grayTextColor;
+      } else if (p.Id == Guid.Empty) {
+        n.Text += NOT_STORED_TAG;
+      } else if (p.Modified) {
+        n.Text += CHANGES_NOT_STORED_TAG;
+      }
+    }
+
+    private void ResetTreeNodes(TreeNodeCollection nodes) {
+      foreach (TreeNode n in nodes) {
+        StyleTreeNode(n, (Project)n.Tag);
+        if (n.Nodes.Count > 0) {
+          ResetTreeNodes(n.Nodes);
+        }
+      }
+    }
+
+    private void ChangeSelectedProject(Project project) {
+      projectView.Content = project;
+      projectPermissionsView.Content = project;
+      projectResourcesView.Content = project;
+      projectJobsView.Content = project;
+      selectedProject = project;
+      SetEnabledStateOfControls();
+    }
+
+    private void ChangeSelectedProjectNode(TreeNode projectNode) {
+      if (projectNode == null) return;
+      SelectedProject = (Project)projectNode.Tag;
+      ResetTreeNodes(projectsTreeView.Nodes);
+      projectNode.BackColor = selectedBackColor;
+      projectNode.ForeColor = selectedForeColor;
+      projectNode.Text += SELECTED_TAG;
     }
 
@@ -462 +536 @@
 
     private void RemoveProject(Project project) {
-      if (project == null || project.Id == Guid.Empty) return;
+      if (project == null) return;
 
       try {
-        HiveAdminClient.Delete(project);
-        Content.Remove(selectedProject);
+        if (project.Id != Guid.Empty) {
+          var projectsToSave = Content.Where(x => x.Id == Guid.Empty || x.Modified);
+          foreach (var p in projectsToSave)
+            p.Store();
+
+          SelectedProject = HiveAdminClient.Instance.GetAvailableProjectAncestors(project.Id).LastOrDefault();
+          HiveAdminClient.Delete(project);          
+          UpdateProjects();
+        } else {
+          Content.Remove(project);
+        }
       } catch (AnonymousUserException) {
         ShowHiveInformationDialog();
@@ -474 +557 @@
     private bool IsAuthorized(Project project) {
       return project != null && UserInformation.Instance.UserExists;
-          //&& (project.OwnerUserId == UserInformation.Instance.User.Id || HiveRoles.CheckAdminUserPermissions());
     }