Changeset 15742 for branches/HiveProjectManagement/HeuristicLab.Clients.Hive.Administrator/3.3/Views/ProjectsView.cs

Timestamp:

02/09/18 07:56:01 (7 years ago)

Author:

jzenisek

Message:

#2839 worked on HiveAdministrator:

• corrected and modified CRUD operations
• improved usability by providing detailed state information, adding dialogs etc.

File:

• branches/HiveProjectManagement/HeuristicLab.Clients.Hive.Administrator/3.3/Views/ProjectsView.cs (modified) (19 diffs)

branches/HiveProjectManagement/HeuristicLab.Clients.Hive.Administrator/3.3/Views/ProjectsView.cs

@@ -40 +40 @@
     private const int greenFlagImageIndex = 0;
     private const int redFlagImageIndex = 1;
+
     private readonly Color changedColor = Color.FromArgb(255, 87, 191, 193); // #57bfc1
     private readonly Color selectedColor = Color.FromArgb(255, 240, 194, 59); // #f0c23b
+    private Project selectedProject = null;
 
     private readonly object locker = new object();
-
-    private Project selectedProject = null;
 
     public new IItemList<Project> Content {
@@ -173 +173 @@
     private async void ProjectsView_Load(object sender, EventArgs e) {
       await SecurityExceptionUtil.TryAsyncAndReportSecurityExceptions(
-        action: () => UpdateProjects(),
-        finallyCallback: () => Content = HiveAdminClient.Instance.Projects);
+        action: () => UpdateProjects());
     }
 
@@ -186 +185 @@
         action: () => UpdateProjects(),
         finallyCallback: () => {
-          Content = HiveAdminClient.Instance.Projects;
           refreshButton.Enabled = true;
         });
@@ -193 +191 @@
     private void addButton_Click(object sender, EventArgs e) {
       Guid? parentProjectId = null;
+
+      if (selectedProject != null && selectedProject.Id == Guid.Empty) {
+        MessageBox.Show(
+          "You cannot add a project to a not yet stored project.",
+          "HeuristicLab Hive Administrator",
+          MessageBoxButtons.OK,
+          MessageBoxIcon.Information);
+        return;
+      }
+
       if (selectedProject != null) parentProjectId = selectedProject.Id;
       var project = new Project {
@@ -199 +207 @@
         ParentProjectId = parentProjectId
       };
+
+      selectedProject = project;
       Content.Add(project);
     }
 
     private async void removeButton_Click(object sender, EventArgs e) {
+      if (selectedProject == null) return;
+
       lock (locker) {
         if (!removeButton.Enabled) return;
@@ -208 +220 @@
       }
 
-      var selectedNode = projectsTreeView.SelectedNode;
-      if (selectedNode == null || selectedNode.Tag == null) return;
-
-      var project = (Project)selectedNode.Tag;
+      if(!IsAdmin() 
+        && HiveAdminClient.Instance.CheckOwnershipOfParentProject(selectedProject, 
+          UserInformation.Instance.User.Id)) {
+        MessageBox.Show(
+          "Only subprojects of owned projects can be deleted.",
+          "HeuristicLab Hive Administrator",
+          MessageBoxButtons.OK,
+          MessageBoxIcon.Error);
+        return;
+      }
+
+      if (!IsAdmin() && Content.Any(x => x.ParentProjectId == selectedProject.Id)) {
+        MessageBox.Show(
+          "Only empty projects can be deleted.",
+          "HeuristicLab Hive Administrator",
+          MessageBoxButtons.OK,
+          MessageBoxIcon.Error);
+        return;
+      }
+
       var result = MessageBox.Show(
-        "Do you really want to delete " + project.Name + "?",
+        "Do you really want to delete " + selectedProject.Name + "?",
         "HeuristicLab Hive Administrator",
         MessageBoxButtons.YesNo,
@@ -219 +247 @@
 
       if (result == DialogResult.Yes) {
-        if (Content.Any(x => x.ParentProjectId == project.Id)) {
-          MessageBox.Show(
-            "Only empty projects can be deleted.",
-            "HeuristicLab Hive Administrator",
-            MessageBoxButtons.OK,
-            MessageBoxIcon.Error);
-        } else {
-          await SecurityExceptionUtil.TryAsyncAndReportSecurityExceptions(
-            action: () => RemoveProject(project),
-            finallyCallback: () => {
-              Content.Remove(project);
-              removeButton.Enabled = true;
-            });
-        }
+        await SecurityExceptionUtil.TryAsyncAndReportSecurityExceptions(
+          action: () => RemoveProject(selectedProject),
+          finallyCallback: () => {
+            removeButton.Enabled = true;
+          });
       }
     }
@@ -247 +266 @@
           foreach (var project in projectsToSave)
             project.Store();
+          UpdateProjects();
         },
         finallyCallback: () => saveProjectButton.Enabled = true);
@@ -254 +274 @@
 
     private void projectsTreeView_AfterSelect(object sender, TreeViewEventArgs e) {
-      selectedProject = (Project)e.Node.Tag;
-      ReColorTreeNodes(projectsTreeView.Nodes, selectedColor, Color.Transparent, true);
-      e.Node.BackColor = selectedColor;
-      e.Node.Text += " [selected]";
-      
+      ChangeSelectedProjectNode(e.Node);
 
       //if (projectView.Content != null)
@@ -269 +285 @@
       //if (selectedProject != null)
       //  selectedProject.PropertyChanged += ProjectViewContent_PropertyChanged;
-
-      //if (IsAuthorized(selectedProject)) {
-      //  if (!tabControl.TabPages.Contains(permissionsTabPage))
-      //    tabControl.TabPages.Add(permissionsTabPage);
-      //  if (!tabControl.TabPages.Contains(resourcesTabPage))
-      //    tabControl.TabPages.Add(resourcesTabPage);
-      //} else {
-      //  if (tabControl.TabPages.Contains(permissionsTabPage))
-      //    tabControl.TabPages.Remove(permissionsTabPage);
-      //  if (tabControl.TabPages.Contains(resourcesTabPage))
-      //    tabControl.TabPages.Remove(resourcesTabPage);
-      //}
     }
 
@@ -286 +290 @@
       var sourceNode = (TreeNode)e.Data.GetData(typeof(TreeNode));
       if (sourceNode == null) return;
+      var sourceResource = ((Project)sourceNode.Tag);
+      if (sourceResource == null) return;
 
       var treeView = (TreeView)sender;
@@ -294 +300 @@
 
       if (sourceNode == targetNode) return;
-
-      if (sourceNode.Parent == null)
+      var targetProject = (targetNode != null) ? (Project)targetNode.Tag : null;
+
+      if(targetProject != null && targetProject.Id == Guid.Empty) {
+        MessageBox.Show(
+          "You cannot drag projects to a not yet stored project.",
+          "HeuristicLab Hive Administrator",
+          MessageBoxButtons.OK,
+          MessageBoxIcon.Information);
+            return;
+      }
+
+      if (sourceNode.Parent == null) {
         treeView.Nodes.Remove(sourceNode);
-      else {
+      } else {
         sourceNode.Parent.Nodes.Remove(sourceNode);
-        ((Project)sourceNode.Tag).ParentProjectId = null;
+        sourceResource.ParentProjectId = null;
       }
 
       if (targetNode == null) {
         treeView.Nodes.Add(sourceNode);
-      } else {
+      } else if(targetProject.Id != Guid.Empty) {
         targetNode.Nodes.Add(sourceNode);
-        ((Project)sourceNode.Tag).ParentProjectId = ((Project)targetNode.Tag).Id;
-      }
+        sourceResource.ParentProjectId = targetProject.Id;
+      }
+
+      selectedProject = sourceResource;
+      OnContentChanged();
     }
 
@@ -330 +349 @@
 
     #region Helpers
-    private void ReColorTreeNodes(TreeNodeCollection nodes, Color c1, Color c2, bool resetText) {
-      foreach(TreeNode n in nodes) {
-        if(n.BackColor.Equals(c1)) {
+    private void ResetTreeNodes(TreeNodeCollection nodes, Color c1, Color c2, bool resetText) {
+      foreach (TreeNode n in nodes) {
+        var pro = ((Project)n.Tag);
+        if (n.BackColor.Equals(c1)) {
           n.BackColor = c2;
-          if (resetText) n.Text = ((Project)n.Tag).Name;
+        }
+        if (resetText) {
+          n.Text = pro.Name;
+
+          if (pro.Id == Guid.Empty) {
+            n.Text += " [not stored]";
+          } else if (pro.Modified) {
+            n.Text += " [changes not stored]";
+          }
         }
         if (n.Nodes.Count > 0) {
-          ReColorTreeNodes(n.Nodes, c1, c2, resetText);
-        }
-      }
+          ResetTreeNodes(n.Nodes, c1, c2, resetText);
+        }
+      }
+    }
+
+    private void ChangeSelectedProjectNode(TreeNode projectNode) {
+      selectedProject = (Project)projectNode.Tag;
+      ResetTreeNodes(projectsTreeView.Nodes, selectedColor, Color.Transparent, true);
+      projectNode.BackColor = selectedColor;
+      projectNode.Text += " [selected]";
     }
 
@@ -354 +389 @@
 
       var stack = new Stack<Project>(mainProjects.OrderByDescending(x => x.Name));
-      Project top = null;
+      if (selectedProject != null) selectedProject = projects.Where(x => x.Id == selectedProject.Id).FirstOrDefault();
 
       TreeNode currentNode = null;
@@ -362 +397 @@
         var newProject = stack.Pop();
         var newNode = new TreeNode(newProject.Name) { Tag = newProject };
-        if (top == null) {
-          top = newProject;
+
+        if (newProject.Id == Guid.Empty) {
+          newNode.Text += " [not stored]";
+        } else if(newProject.Modified) {
+          newNode.Text += " [changes not stored]";
+        }
+        if (selectedProject == null) {
+          selectedProject = newProject;
+        }
+        if (newProject.Id == selectedProject.Id) {
           newNode.BackColor = selectedColor;
           newNode.Text += " [selected]";
         }
 
+        // search for parent node of newNode and save in currentNode
+        // necessary since newNodes (stack top items) might be siblings
+        // or grand..grandparents of previous node (currentNode)
         while (currentNode != null && newProject.ParentProjectId != currentProject.Id) {
           currentNode = currentNode.Parent;
@@ -396 +442 @@
       projectsTreeView.ExpandAll();
 
-      return top;
+      return selectedProject;
     }
 
@@ -402 +448 @@
       try {
         HiveAdminClient.Instance.Refresh();
+        Content = HiveAdminClient.Instance.Projects;
       } catch (AnonymousUserException) {
         ShowHiveInformationDialog();
@@ -408 +455 @@
 
     private void RemoveProject(Project project) {
+      if (project == null || project.Id == Guid.Empty) return;
+
       try {
         HiveAdminClient.Delete(project);
+        Content.Remove(selectedProject);
       } catch (AnonymousUserException) {
         ShowHiveInformationDialog();
@@ -420 +470 @@
     }
 
+    private bool IsAdmin() {
+      return HiveRoles.CheckAdminUserPermissions();
+    }
+
     private void ShowHiveInformationDialog() {
       if (InvokeRequired) Invoke((Action)ShowHiveInformationDialog);