Changeset 15376

Timestamp:

09/20/17 15:56:34 (7 years ago)

Author:

jkarder

Message:

#2831: changed exception handling in engines

Location:

trunk/sources

Files:

• HeuristicLab.DebugEngine/3.3/DebugEngine.cs (modified) (1 diff)
• HeuristicLab.ParallelEngine/3.3/ParallelEngine.cs (modified) (3 diffs)
• HeuristicLab.SequentialEngine/3.3/SequentialEngine.cs (modified) (1 diff)

trunk/sources/HeuristicLab.DebugEngine/3.3/DebugEngine.cs

@@ -308 +308 @@
           CurrentOperation = null;
         } catch (Exception ex) {
-          if (ex is OperationCanceledException) throw ex;
+          if (ex is OperationCanceledException) throw;
           else throw new OperatorExecutionException(operation.Operator, ex);
         }

trunk/sources/HeuristicLab.ParallelEngine/3.3/ParallelEngine.cs

@@ -101 +101 @@
             try {
               Parallel.ForEach(stacks, parallelOptions, Run);
-            }
-            catch (Exception ex) {
-              OperationCollection remaining = new OperationCollection() { Parallel = true };
-              for (int i = 0; i < stacks.Length; i++) {
-                if (stacks[i].Count == 1)
-                  remaining.Add(stacks[i].Pop());
-                if (stacks[i].Count > 1) {
-                  OperationCollection ops = new OperationCollection();
-                  while (stacks[i].Count > 0)
-                    ops.Add(stacks[i].Pop());
-                  remaining.Add(ops);
-                }
-              }
-              if (remaining.Count > 0) executionStack.Push(remaining);
+            } catch (OperationCanceledException) {
+              RepairStack(executionStack, stacks);
+              throw;
+            } catch (AggregateException) {
+              RepairStack(executionStack, stacks);
               throw;
             }
@@ -128 +119 @@
           catch (Exception ex) {
             executionStack.Push(operation);
-            if (ex is OperationCanceledException) throw ex;
+            if (ex is OperationCanceledException) throw;
             else throw new OperatorExecutionException(operation.Operator, ex);
           }
@@ -135 +126 @@
       }
     }
+
+    private static void RepairStack(Stack<IOperation> executionStack, Stack<IOperation>[] parallelExecutionStacks) {
+      OperationCollection remaining = new OperationCollection() { Parallel = true };
+      for (int i = 0; i < parallelExecutionStacks.Length; i++) {
+        if (parallelExecutionStacks[i].Count == 1)
+          remaining.Add(parallelExecutionStacks[i].Pop());
+        if (parallelExecutionStacks[i].Count > 1) {
+          OperationCollection ops = new OperationCollection();
+          while (parallelExecutionStacks[i].Count > 0)
+            ops.Add(parallelExecutionStacks[i].Pop());
+          remaining.Add(ops);
+        }
+      }
+      if (remaining.Count > 0) executionStack.Push(remaining);
+    }
   }
 }

trunk/sources/HeuristicLab.SequentialEngine/3.3/SequentialEngine.cs

@@ -62 +62 @@
           catch (Exception ex) {
             ExecutionStack.Push(operation);
-            if (ex is OperationCanceledException) throw ex;
+            if (ex is OperationCanceledException) throw;
             else throw new OperatorExecutionException(operation.Operator, ex);
           }