Changeset 15217 for stable/HeuristicLab.Encodings.RealVectorEncoding

Timestamp:

07/12/17 21:02:01 (7 years ago)

Author:

abeham

Message:

#2666, #2706, #2730, #2736: merged revisions 14412, 14475, 14476, 14659, 14660, 14663, 14779, 14780, 14912, 15050, 15067, 15069, 15079, 15162, 15166, 15172, 15173 to stable

Location:

stable

Files:

• . (modified) (1 prop)
• HeuristicLab.Encodings.RealVectorEncoding (modified) (1 prop)
• HeuristicLab.Encodings.RealVectorEncoding/3.3/HeuristicLab.Encodings.RealVectorEncoding-3.3.csproj (modified) (2 diffs)
• HeuristicLab.Encodings.RealVectorEncoding/3.3/RealVectorEqualityComparer.cs (copied) (copied from trunk/sources/HeuristicLab.Encodings.RealVectorEncoding/3.3/RealVectorEqualityComparer.cs) (1 diff)
• HeuristicLab.Encodings.RealVectorEncoding/3.3/SimilarityCalculators (copied) (copied from trunk/sources/HeuristicLab.Encodings.RealVectorEncoding/3.3/SimilarityCalculators)
• HeuristicLab.Encodings.RealVectorEncoding/3.3/SimilarityCalculators/EuclideanSimilarityCalculator.cs (copied) (copied from trunk/sources/HeuristicLab.Encodings.RealVectorEncoding/3.3/SimilarityCalculators/EuclideanSimilarityCalculator.cs)
• HeuristicLab.Encodings.RealVectorEncoding/3.3/SimilarityCalculators/HammingSimilarityCalculator.cs (modified) (1 diff)

stable/HeuristicLab.Encodings.RealVectorEncoding/3.3/HeuristicLab.Encodings.RealVectorEncoding-3.3.csproj

@@ -137 +137 @@
     <Compile Include="Properties\AssemblyInfo.cs" />
     <Compile Include="RealVectorEncoding.cs" />
+    <Compile Include="RealVectorEqualityComparer.cs" />
     <Compile Include="RealVectorManipulator.cs" />
   </ItemGroup>
@@ -182 +183 @@
     <Compile Include="ReflectiveBoundsChecker.cs" />
     <Compile Include="ShakingOperators\RealVectorShakingOperator.cs" />
+    <Compile Include="SimilarityCalculators\EuclideanSimilarityCalculator.cs" />
+    <Compile Include="SimilarityCalculators\HammingSimilarityCalculator.cs" />
     <Compile Include="StrategyParameters\StdDevStrategyVectorCreator.cs" />
     <Compile Include="StrategyParameters\StdDevStrategyVectorCrossover.cs" />

stable/HeuristicLab.Encodings.RealVectorEncoding/3.3/RealVectorEqualityComparer.cs

@@ -20 +20 @@
 #endregion
 
+using System;
 using System.Collections.Generic;
+using HeuristicLab.PluginInfrastructure;
 
 namespace HeuristicLab.Encodings.RealVectorEncoding {
+  [NonDiscoverableType]
   public class RealVectorEqualityComparer : EqualityComparer<RealVector> {
     public override bool Equals(RealVector x, RealVector y) {
-      if (x == null && y == null) return true;
+      if (ReferenceEquals(x, y)) return true;
       if (x == null || y == null) return false;
       if (x.Length != y.Length) return false;
       for (var i = 0; i < x.Length; i++)
-        if (x[i] == y[i]) return false;
+        if (x[i] != y[i]) return false;
       return true;
     }
 
     public override int GetHashCode(RealVector obj) {
+      if (obj == null) throw new ArgumentNullException("obj", "RealVectorEqualityComparer: Cannot compute hash value of null.");
       unchecked {
         int hash = 17;

stable/HeuristicLab.Encodings.RealVectorEncoding/3.3/SimilarityCalculators/HammingSimilarityCalculator.cs

@@ -45 +45 @@
     public static double CalculateSimilarity(RealVector left, RealVector right) {
       if (left == null || right == null)
-        throw new ArgumentException("Cannot calculate similarity because one or both of the provided scopes is null.");
+        throw new ArgumentException("Cannot calculate similarity because one or both of the provided solutions is null.");
       if (left.Length != right.Length)
         throw new ArgumentException("Cannot calculate similarity because the provided solutions have different lengths.");
-      if (left == right) return 1.0;
+      if (left.Length == 0)
+        throw new ArgumentException("Cannot calculate similarity because solutions are of length 0.");
+      if (ReferenceEquals(left, right)) return 1.0;
 
       double similarity = 0.0;