Changeset 13806 for branches/HeuristicLab.VariableInteractionNetworks/HeuristicLab.VariableInteractionNetworks/3.3/CreateTargetVariationExperimentDialog.cs

Timestamp:

04/27/16 17:17:00 (8 years ago)

Author:

bburlacu

Message:

#2288: Remove TinySet.cs in favor of a more general method for generating k-combinations. Improve target variation experiment generation. Refactored code and avoided some corner case exceptions.

File:

• branches/HeuristicLab.VariableInteractionNetworks/HeuristicLab.VariableInteractionNetworks/3.3/CreateTargetVariationExperimentDialog.cs (modified) (6 diffs)

branches/HeuristicLab.VariableInteractionNetworks/HeuristicLab.VariableInteractionNetworks/3.3/CreateTargetVariationExperimentDialog.cs

@@ -24 +24 @@
 using System.Linq;
 using System.Windows.Forms;
+using HeuristicLab.Common;
 using HeuristicLab.MainForm;
 using HeuristicLab.Optimization;
@@ -32 +33 @@
     public Experiment Experiment { get; private set; }
     private int repetitions;
-    private int binomialCoefficient;
+    private int combinationGroupSize;
 
     public CreateTargetVariationExperimentDialog() : this(null) { }
@@ -38 +39 @@
       InitializeComponent();
       repetitions = (int)repetitionsNumericUpDown.Value;
+      combinationGroupSize = (int)combinationGroupSizeNumericUpDown.Value;
+
+      var problem = alg.Problem as IDataAnalysisProblem;
+      var inputCount = problem.ProblemData.AllowedInputVariables.Count();
+      if (combinationGroupSize > inputCount)
+        combinationGroupSize = inputCount;
+      warningLabel.Text = string.Format("Warning: this will create {0} combinations.", EnumerableExtensions.BinomialCoefficient(inputCount, combinationGroupSize));
 
       Experiment = null;
       okButton.Enabled = alg != null;
-    }
-
-    private void repetitionsNumericUpDown_Validated(object sender, EventArgs e) {
-      if (repetitionsNumericUpDown.Text == string.Empty)
-        repetitionsNumericUpDown.Text = repetitionsNumericUpDown.Value.ToString();
-      repetitions = (int)repetitionsNumericUpDown.Value;
-    }
-
-    private void binomialCoefficientNumericUpDown_Validated(object sender, EventArgs e) {
-      if (binomialCoeffNumericUpDown.Text == string.Empty)
-        binomialCoeffNumericUpDown.Text = binomialCoeffNumericUpDown.Value.ToString();
-      binomialCoefficient = (int)binomialCoeffNumericUpDown.Value;
     }
 
@@ -61 +57 @@
         throw new ArgumentNullException("The algorithm parameter must be a valid IAlgorithm instance.");
 
-      var regressionProblem = algorithm.Problem as IRegressionProblem;
-      if (regressionProblem == null)
-        throw new ArgumentNullException("The algorithm does not contain a valid problem instance.");
+      var problem = (IDataAnalysisProblem)algorithm.Problem;
+      var problemData = problem.ProblemData;
 
-      var problemData = regressionProblem.ProblemData;
-      var variables = problemData.Dataset.DoubleVariables.ToList();
+      var variables = problemData.AllowedInputVariables.ToList();
 
       for (int i = 0; i < variables.Count; i++) {
         var target = variables[i];
         var inputs = variables.Where(x => x != target).ToList();
-        var combinations = Util.Combinations(inputs, binomialCoefficient);
+        if (combinationGroupSize > inputs.Count)
+          combinationGroupSize = inputs.Count;
+
+        var combinations = inputs.Combinations(combinationGroupSize);
 
         foreach (var combination in combinations) {
           var h = new HashSet<string>(combination);
           var alg = (IAlgorithm)algorithm.Clone();
-          var pd = ((IRegressionProblem)alg.Problem).ProblemData;
-          pd.TargetVariable = target;
-          alg.Name += "{Target = " + target + ", Inputs = (" + combination.Aggregate((a, b) => a + "," + b) + ")}";
-
-          foreach (var item in pd.InputVariables) {
-            pd.InputVariables.SetItemCheckedState(item, h.Contains(item.Value));
+          alg.Name += " {Target = " + target + ", Inputs = (" + combination.Aggregate((a, b) => a + "," + b) + ")}";
+          problem = (IDataAnalysisProblem)alg.Problem;
+          problemData = problem.ProblemData;
+          foreach (var item in problemData.InputVariables) {
+            problemData.InputVariables.SetItemCheckedState(item, h.Contains(item.Value));
           }
+          SetTargetName(problemData, target);
 
           var batchrun = new BatchRun(string.Format("Batchrun {0}", i + 1)) {
@@ -95 +92 @@
     }
 
+    private static string GetTargetName(IDataAnalysisProblemData problemData) {
+      var regressionProblemData = problemData as IRegressionProblemData;
+      if (regressionProblemData != null)
+        return regressionProblemData.TargetVariable;
+      var classificationProblemData = problemData as IClassificationProblemData;
+      if (classificationProblemData != null)
+        return classificationProblemData.TargetVariable;
+      throw new ArgumentException("The provided argument must be either a regression or classification problem data.");
+    }
+
+    private static void SetTargetName(IDataAnalysisProblemData problemData, string targetName) {
+      var regressionProblemData = problemData as IRegressionProblemData;
+      if (regressionProblemData != null) {
+        regressionProblemData.TargetVariable = targetName;
+        return;
+      }
+      var classificationProblemData = problemData as IClassificationProblemData;
+      if (classificationProblemData != null) {
+        classificationProblemData.TargetVariable = targetName;
+        return;
+      }
+      throw new ArgumentException("The provided argument must be either a regression or classification problem data.");
+    }
+
+    #region events
     private void okButton_Click(object sender, EventArgs e) {
       IContentView activeView = MainFormManager.MainForm.ActiveView as IContentView;
-      if ((activeView != null) && (activeView.Content != null) && (activeView.Content is IOptimizer) && !activeView.Locked) {
+      if ((activeView != null) && (activeView.Content != null) && (activeView.Content is IAlgorithm) && !activeView.Locked) {
         Experiment = CreateVariableCombinations((IAlgorithm)activeView.Content);
         DialogResult = DialogResult.OK;
@@ -103 +125 @@
       }
     }
+
+    private void combinationGroupSizeNumericUpDown_Validating(object sender, System.ComponentModel.CancelEventArgs e) {
+      IContentView activeView = MainFormManager.MainForm.ActiveView as IContentView;
+      if (activeView == null) return;
+      var algorithm = (IAlgorithm)activeView.Content;
+      var problem = algorithm.Problem as IDataAnalysisProblem;
+      if (problem == null) return;
+      var inputCount = problem.ProblemData.AllowedInputVariables.Count();
+      if (combinationGroupSizeNumericUpDown.Value > inputCount)
+        combinationGroupSizeNumericUpDown.Value = inputCount;
+    }
+
+    private void repetitionsNumericUpDown_Validated(object sender, EventArgs e) {
+      if (repetitionsNumericUpDown.Text == string.Empty)
+        repetitionsNumericUpDown.Text = repetitionsNumericUpDown.Value.ToString();
+      repetitions = (int)repetitionsNumericUpDown.Value;
+    }
+
+    private void combinationGroupSizeNumericUpDown_Validated(object sender, EventArgs e) {
+      if (combinationGroupSizeNumericUpDown.Text == string.Empty)
+        combinationGroupSizeNumericUpDown.Text = combinationGroupSizeNumericUpDown.Value.ToString();
+      combinationGroupSize = (int)combinationGroupSizeNumericUpDown.Value;
+      IContentView activeView = MainFormManager.MainForm.ActiveView as IContentView;
+      if (activeView == null) return;
+      var algorithm = (IAlgorithm)activeView.Content;
+      var problem = (IDataAnalysisProblem)algorithm.Problem;
+      var inputCount = problem.ProblemData.AllowedInputVariables.Count();
+      warningLabel.Text = string.Format("Warning: this will create {0} combinations.", EnumerableExtensions.BinomialCoefficient(inputCount, combinationGroupSize));
+    }
+    #endregion
   }
 }