Changeset 12949 for branches/crossvalidation-2434/HeuristicLab.Optimization/3.3/MetaOptimizers/Experiment.cs

Timestamp:

09/14/15 14:28:38 (9 years ago)

Author:

gkronber

Message:

#2061: fixed a contention problem when updating the execution time of an experiment with many concurrent optimizers

File:

• branches/crossvalidation-2434/HeuristicLab.Optimization/3.3/MetaOptimizers/Experiment.cs (modified) (5 diffs)

branches/crossvalidation-2434/HeuristicLab.Optimization/3.3/MetaOptimizers/Experiment.cs

@@ -24 +24 @@
 using System.Drawing;
 using System.Linq;
+using System.Threading;
 using HeuristicLab.Collections;
 using HeuristicLab.Common;
@@ -345 +346 @@
 
     private readonly object locker = new object();
+    private readonly object runsLocker = new object();
     private void optimizer_ExceptionOccurred(object sender, EventArgs<Exception> e) {
       lock (locker)
@@ -350 +352 @@
     }
     private void optimizer_ExecutionTimeChanged(object sender, EventArgs e) {
-      lock (locker)
-        ExecutionTime = Optimizers.Aggregate(TimeSpan.Zero, (t, o) => t + o.ExecutionTime);
+      // only wait for maximally 100ms to acquire lock, otherwise return and don't update the execution time 
+      var success = Monitor.TryEnter(locker, 100);
+      if (!success) return;
+      ExecutionTime = Optimizers.Aggregate(TimeSpan.Zero, (t, o) => t + o.ExecutionTime);
+      Monitor.Exit(locker);
     }
     private void optimizer_Paused(object sender, EventArgs e) {
@@ -378 +383 @@
     }
     private void optimizer_Runs_CollectionReset(object sender, CollectionItemsChangedEventArgs<IRun> e) {
-      lock (locker) {
+      lock (runsLocker) {
         Runs.RemoveRange(e.OldItems);
         Runs.AddRange(e.Items);
@@ -384 +389 @@
     }
     private void optimizer_Runs_ItemsAdded(object sender, CollectionItemsChangedEventArgs<IRun> e) {
-      lock (locker)
+      lock (runsLocker)
         Runs.AddRange(e.Items);
     }
     private void optimizer_Runs_ItemsRemoved(object sender, CollectionItemsChangedEventArgs<IRun> e) {
-      lock (locker)
+      lock (runsLocker)
         Runs.RemoveRange(e.Items);
     }