Changeset 12660

Timestamp:

07/07/15 17:46:58 (9 years ago)

Author:

gkronber

Message:

#2261: minor change if(!rows.Any()) return ...

File:

• branches/GBT-trunkintegration/HeuristicLab.Algorithms.DataAnalysis/3.4/GradientBoostedTrees/GradientBoostedTreesModel.cs (modified) (1 diff)

branches/GBT-trunkintegration/HeuristicLab.Algorithms.DataAnalysis/3.4/GradientBoostedTrees/GradientBoostedTreesModel.cs

@@ -63 +63 @@
     public IEnumerable<double> GetEstimatedValues(IDataset dataset, IEnumerable<int> rows) {
       // allocate target array go over all models and add up weighted estimation for each row
+      if (!rows.Any()) return Enumerable.Empty<double>(); // return immediately if rows is empty. This prevents multiple iteration over lazy rows enumerable.
+                                                          // (which essentially looks up indexes in a dictionary)
       var res = new double[rows.Count()];
-      if (res.Length == 0) return res; // return immediately if rows is empty. This prevents multiple iteration over lazy rows enumerable.
-                                       // (which essentially looks up indexes in a dictionary)
       for (int i = 0; i < models.Count; i++) {
         var w = weights[i];