Changeset 11437 for trunk/sources

Timestamp:

10/09/14 18:12:20 (10 years ago)

Author:

jkarder

Message:

#2239: applied a slightly modified version of bburlacu's patch

File:

• trunk/sources/HeuristicLab.Scripting.Views/3.3/VariableStoreView.cs (modified) (3 diffs)

trunk/sources/HeuristicLab.Scripting.Views/3.3/VariableStoreView.cs

@@ -40 +40 @@
   [Content(typeof(VariableStore), true)]
   public partial class VariableStoreView : AsynchronousContentView {
-    protected Dictionary<string, ListViewItem> itemListViewItemMapping;
+    protected readonly Dictionary<string, ListViewItem> itemListViewItemMapping;
+    protected readonly Dictionary<Type, bool> serializableLookup;
     protected TypeSelectorDialog typeSelectorDialog;
     protected bool validDragOperation;
@@ -56 +57 @@
       InitializeComponent();
       itemListViewItemMapping = new Dictionary<string, ListViewItem>();
+      serializableLookup = new Dictionary<Type, bool>();
       variableListView.SmallImageList.Images.AddRange(new Image[] {
         HeuristicLab.Common.Resources.VSImageLibrary.Error,
@@ -397 +399 @@
 
     private bool IsSerializable(KeyValuePair<string, object> variable) {
+      var type = variable.Value.GetType();
+      bool serializable;
+      if (serializableLookup.TryGetValue(type, out serializable))
+        return serializable;
       var ser = new Serializer(variable, ConfigurationService.Instance.GetDefaultConfig(new XmlFormat()), "ROOT", true);
       try {
-        return ser.Count() > 0;
+        return serializableLookup[type] = ser.Any();
       } catch (PersistenceException) {
-        return false;
+        return serializableLookup[type] = false;
       }
     }