Change Dataset of RegressionModel

[sforsten]

A new button will be added in the RegressionSolutionView to import a new data set to a regression model to easily test models with different data set.

The new data sets will be checked if they fit the model, before they are applied.

The import will be able to load .hl files with problem data or problems, where they problem data of the Problem is loaded.

[sforsten]

r7338: first version to change the data set in a model has been implemented

[sforsten]

r7347:

• Bug fix in ItemCollectionView: Content events are deregistered in Dispose method
• Bug fix in ItemCollectionView: Item events are deregistered in OnContentChanged method
• small changes in RegressionSolutionView

[sforsten]

r7399:

• implemented SetEnabledStateOfControls in RegressionSolutionView
• fixed bug in NamedDataAnalysisSolutionView (If OnContentChanged creates a new DataAnalysisSolutionView, it sets Locked and ReadOnly as it is set in the current view.)

[sforsten]

r7404:

• branch has been adjusted
• bug fix in DataAnalysisSolutionView

[mkommend]

r7468: Minor code improvements (variable naming, return conditions).

[mkommend]

Please look over the changes made in r7468. Additionally the import method should be separated from the reaction to the button click and a new method should be implemented which checks if the model can handle the loaded ProblemData.

[sforsten]

r7487: changes according to mkommend's reviewing comments have been made and catch blocks now only catch specific exceptions

[sforsten]

r8032:

• merged trunk r7330:8022 into branch
• importButton shows a message, if clicked and it can't be used

[gkronber]

This ticket contains only branch changes and will not be included in milestone 3.3.7.

[sforsten]

r8513: merged r8023:8509 from trunk to branch to make it useable again

[sforsten]

r8591: merged r8510:8590 from trunk to branch

[mkommend]

This ticket is rather outdated and contains modification which were applied already on the trunk. As the functionality is still important, I will extract the relevant changes and apply them directly at the trunk.

The changes above are obsolete and need not be reviewed.

[mkommend]

r10173: Extended the drap and drop functionality of DataAnalysisSolutionViews to allow dropping the problem itself in addition to the problem data.

[mkommend]

r10174: Added check of target and inputvariables of dropped ProblemData.

[mkommend]

r10175: Added button to load new data into data analysis solutions.

[mkommend]

r10176: Corrected plugin dependencies of "HeuristicLab.Problems.DataAnalysis.Views".

[mkommend]

Please review r10173, r10174, r10175, and r10176.

[mkommend]

The branch "ChangeDatasetOfRegressionModel" can be deleted when this ticket is ready to release.

[abeham]

• "Load Data" is not really a good indicator of what this action will be doing. It creates a new solution and doesn't alter the current solution as one might expect when clicking "Load Data". There is little indication why I should use and click this.
• Load Data should also consider that there is a ProblemData inside a saved data analysis solution. I first tried to load the data from a stored solution and got an error that there is no problem data.
• I think it's too generic to open ".hl" files. It's not clear to the user what kind of file can be opened or not. Would it also be feasible to use the instance importer to open files?
• The solutions gets a really long name if this feature is used: "GaussianProcessRegressionSolution with loaded problem data (System.Windows.Forms.OpenFileDialog: Title: Load new ProblemData or Problem..., FileName: C:\Users\somepath\ProblemData.hl)". Put some of this in the description and simplify the name. For example try to use load data in this view one more time, the name gets longer and longer.
• When one uses Drag and Drop to use new problem data, the name doesn't get changed. It potentially still says "with loaded problem data ..."
• It seems the Simplify button is one pixel less in height than the other buttons
• The Details text of the GroupBox is rather close to the "Load Data" button. Also it's kind of strange to have Simplify and Load Data on the left and the Export Button on the right and none of them have any icons. For solutions that are not simplifyable the layout has even more gaps.
• When I load an entirely different data set it only shows that the target variable is different, not the also the inputs are not compatible because CheckCompatibilityOfProblemData ignores errors in base classes when it finds and error itself.
• Not part of this ticket, but it's not clear what "Export" does until I clicked it and I saw that it creates an Excel file. Is it possible to add an Excel icon to this button? Also I think it's not really an "Export", but rather some kind of "continue analysing in Excel" feature. Technically it may be seen as an export though.

[mkommend]

r10540: Reimplemented functionality to load new problem data to data analysis solution and redesigned the according views.

• Added setter for the target variable of regression and classification problem data.
• Added functionality to check the compatibility of problem data.
• Added functionality to adjust the properties of a problem data.
• Added flowLayoutPanel with according buttons for loading a new problem data, simplifying and exporting data analysis solutions.
• TradingProblemData currently throws a NotSupportedException when the properties should be adjusted.

[mkommend]

r10541: Updated button tooltips.

[mkommend]

r10543: Corrected plugin dependencies in views plugins.

[mkommend]

r10545: Added icons to simplifier buttons (simplify, optimize).

[mkommend]

Replying to abeham:

• I think it's too generic to open ".hl" files. It's not clear to the user what kind of file can be opened or not. Would it also be feasible to use the instance importer to open files?

It is not feasible to reuse the instance importer, because otherwise the problem has to be configured again. IMHO loading HL files is fine.

All other review comments have been addressed in the previous commits.

[gkronber]

Reviewed r10173:10176 and r10540, r10541, r10543, and r10545.

[gkronber]

r11031: made appropriate changes to the problem data classes for trading and time series prognosis

[gkronber]

Please review if r11031 is ok with you. Other than that I think this ticket is ready for release.

[mkommend]

r11144: Merged r10173:10176 and r10540, r10541, r10543, r10545 and r11031 into stable.