Opened 6 years ago

Closed 5 years ago

#1651 closed defect (done)

TypeSelector and new item dialog are slow because they create instances

Reported by: gkronber Owned by: swagner
Priority: medium Milestone: HeuristicLab 3.3.6
Component: Core Version: 3.3.6
Keywords: Cc:

Description

This should be solve by detecting and listing only the available types. However, the image to display must be available so a static image property for items must be introduced. The virtual item image property should return the static image by default. But this behavior can be overridden in derived classes. If the static property is not available for an item the image of the base class should be discovered by a base class traversal in the default implementation for the item image property.

Change History (5)

comment:1 Changed 5 years ago by swagner

  • Status changed from new to accepted

comment:2 Changed 5 years ago by swagner

Implemented static item image properties to avoid instance creation in TypeSelector and NewItemDialog in r7201.

comment:3 Changed 5 years ago by swagner

  • Owner changed from swagner to ascheibe
  • Status changed from accepted to reviewing

comment:4 Changed 5 years ago by ascheibe

  • Owner changed from ascheibe to swagner
  • Status changed from reviewing to readytorelease

I have reviewed and tested the changes, looks good, very nice speed-up!

comment:5 Changed 5 years ago by swagner

  • Resolution set to done
  • Status changed from readytorelease to closed
  • Version changed from 3.3.5 to 3.3.6
Note: See TracTickets for help on using tickets.