Changeset 8550 for trunk/sources/HeuristicLab.Problems.DataAnalysis.Symbolic.Classification/3.4/SymbolicDiscriminantFunctionClassificationModel.cs

Timestamp:

08/31/12 13:52:24 (12 years ago)

Author:

mkommend

Message:

#1919: Changed threshold calculation methods to instance instead of static methods.

File:

• trunk/sources/HeuristicLab.Problems.DataAnalysis.Symbolic.Classification/3.4/SymbolicDiscriminantFunctionClassificationModel.cs (modified) (1 diff)

trunk/sources/HeuristicLab.Problems.DataAnalysis.Symbolic.Classification/3.4/SymbolicDiscriminantFunctionClassificationModel.cs

@@ -122 +122 @@
     #endregion
 
-    public static void SetAccuracyMaximizingThresholds(IDiscriminantFunctionClassificationModel model, IClassificationProblemData problemData) {
+    public void SetAccuracyMaximizingThresholds(IClassificationProblemData problemData) {
       double[] classValues;
       double[] thresholds;
       var targetClassValues = problemData.Dataset.GetDoubleValues(problemData.TargetVariable, problemData.TrainingIndices);
-      var estimatedTrainingValues = model.GetEstimatedValues(problemData.Dataset, problemData.TrainingIndices);
+      var estimatedTrainingValues = GetEstimatedValues(problemData.Dataset, problemData.TrainingIndices);
       AccuracyMaximizationThresholdCalculator.CalculateThresholds(problemData, estimatedTrainingValues, targetClassValues, out classValues, out thresholds);
 
-      model.SetThresholdsAndClassValues(thresholds, classValues);
-    }
-
-    public static void SetClassDistributionCutPointThresholds(IDiscriminantFunctionClassificationModel model, IClassificationProblemData problemData) {
+      SetThresholdsAndClassValues(thresholds, classValues);
+    }
+
+    public void SetClassDistributionCutPointThresholds(IClassificationProblemData problemData) {
       double[] classValues;
       double[] thresholds;
       var targetClassValues = problemData.Dataset.GetDoubleValues(problemData.TargetVariable, problemData.TrainingIndices);
-      var estimatedTrainingValues = model.GetEstimatedValues(problemData.Dataset, problemData.TrainingIndices);
+      var estimatedTrainingValues = GetEstimatedValues(problemData.Dataset, problemData.TrainingIndices);
       NormalDistributionCutPointsThresholdCalculator.CalculateThresholds(problemData, estimatedTrainingValues, targetClassValues, out classValues, out thresholds);
 
-      model.SetThresholdsAndClassValues(thresholds, classValues);
+      SetThresholdsAndClassValues(thresholds, classValues);
     }