Changeset 13013 for branches/Robocode.TrunkInt/HeuristicLab.Problems.Robocode/3.3/Interpreter.cs

Timestamp:

10/15/15 16:39:12 (9 years ago)

Author:

gkronber

Message:

#2069: reviewing and minor changes

File:

• branches/Robocode.TrunkInt/HeuristicLab.Problems.Robocode/3.3/Interpreter.cs (modified) (6 diffs)

branches/Robocode.TrunkInt/HeuristicLab.Problems.Robocode/3.3/Interpreter.cs

@@ -26 +26 @@
 using System.Linq;
 using System.Reflection;
-using HeuristicLab.Core;
-using HeuristicLab.Data;
 using HeuristicLab.Encodings.SymbolicExpressionTreeEncoding;
 
-namespace HeuristicLab.Problems.GeneticProgramming.RoboCode {
+namespace HeuristicLab.Problems.GeneticProgramming.Robocode {
   public static class Interpreter {
     public static double EvaluateTankProgram(ISymbolicExpressionTree tree, string path, EnemyCollection enemies, string robotName = null, bool showUI = false, int nrOfRounds = 3) {
@@ -47 +45 @@
       File.WriteAllText(srcRobotPath, interpretedProgram, System.Text.Encoding.Default);
 
+      // compile java source to class file
       ProcessStartInfo javaCompileInfo = new ProcessStartInfo();
       javaCompileInfo.FileName = "cmd.exe";
@@ -55 +54 @@
       javaCompileInfo.CreateNoWindow = true;
 
-      Process javaCompile = new Process();
-      javaCompile.StartInfo = javaCompileInfo;
-      javaCompile.Start();
+      using (Process javaCompile = new Process()) {
+        javaCompile.StartInfo = javaCompileInfo;
+        javaCompile.Start();
 
-      string cmdOutput = javaCompile.StandardOutput.ReadToEnd();
-      cmdOutput += javaCompile.StandardError.ReadToEnd();
+        string cmdOutput = javaCompile.StandardOutput.ReadToEnd();
+        cmdOutput += javaCompile.StandardError.ReadToEnd();
 
-      javaCompile.WaitForExit();
-      if (javaCompile.ExitCode != 0) {
-        DeleteRobotFiles(path, robotName);
-        throw new Exception("Compile Error: " + cmdOutput);
+        javaCompile.WaitForExit();
+        if (javaCompile.ExitCode != 0) {
+          DeleteRobotFiles(path, robotName);
+          throw new Exception("Compile Error: " + cmdOutput);
+        }
       }
 
       //parallel execution of multiple robocode instances can sometimes lead to a damaged robot.database
-      try { File.Delete(path + @"\robots\robot.database"); }
-      catch { }
+      var robotsDbFileName = Path.Combine(path, "robots", "robot.database");
+      if (File.Exists(robotsDbFileName))
+        File.Delete(robotsDbFileName);
 
       ProcessStartInfo evaluateCodeInfo = new ProcessStartInfo();
 
+      // execute a battle with numberOfRounds against a number of enemies
+      // TODO: seems there is a bug when selecting multiple enemies
       evaluateCodeInfo.FileName = "cmd.exe";
-      evaluateCodeInfo.Arguments = "/C java -cp " + battleRunnerPath + ";" + robocodeCoreJar + ";" + robocodeJar +
-                                  ";" + picocontainerJar + ";" + " BattleRunner Evaluation." + robotName + " " + path;
-
-      if (showUI) {
-        evaluateCodeInfo.Arguments += " true " + nrOfRounds + " ";
-      } else {
-        evaluateCodeInfo.Arguments += " false " + nrOfRounds + " ";
-      }
-
-      foreach (var enemy in enemies.CheckedItems)
-        evaluateCodeInfo.Arguments += enemy.Value + " ";
+      var classpath = string.Join(";", new[] { battleRunnerPath, robocodeCoreJar, robocodeJar, picocontainerJar });
+      var enemyRobotNames = string.Join(" ", enemies.CheckedItems.Select(i => i.Value));
+      evaluateCodeInfo.Arguments = string.Format("/C java -cp {0} BattleRunner Evaluation.{1} {2} {3} {4} {5}", classpath, robotName, path, showUI, nrOfRounds, enemyRobotNames);
 
       evaluateCodeInfo.RedirectStandardOutput = true;
@@ -92 +87 @@
       evaluateCodeInfo.CreateNoWindow = true;
 
-      Process evaluateCode = new Process();
-      evaluateCode.StartInfo = evaluateCodeInfo;
-      evaluateCode.Start();
-      evaluateCode.WaitForExit();
+      double evaluation;
+      using (Process evaluateCode = new Process()) {
+        evaluateCode.StartInfo = evaluateCodeInfo;
+        evaluateCode.Start();
+        evaluateCode.WaitForExit();
 
-      if (evaluateCode.ExitCode != 0) {
-        DeleteRobotFiles(path, robotName);
-        throw new Exception("Error running Robocode: " + evaluateCode.StandardError.ReadToEnd());
-      }
+        if (evaluateCode.ExitCode != 0) {
+          DeleteRobotFiles(path, robotName);
+          throw new Exception("Error running Robocode: " + evaluateCode.StandardError.ReadToEnd() + Environment.NewLine +
+                              evaluateCode.StandardOutput.ReadToEnd());
+        }
 
-      string scoreString = "";
-      double evaluation = -1.0;
-      try {
-        scoreString = evaluateCode.StandardOutput.ReadToEnd().Split(new string[] { Environment.NewLine }, StringSplitOptions.RemoveEmptyEntries).Last();
-        evaluation = Double.Parse(scoreString, CultureInfo.InvariantCulture);
-      }
-      catch (Exception ex) {
-        throw new Exception("Error parsing score string: " + ex.ToString());
-      }
-      finally {
-        DeleteRobotFiles(path, robotName);
+        try {
+          string scoreString =
+            evaluateCode.StandardOutput.ReadToEnd()
+              .Split(new string[] { Environment.NewLine }, StringSplitOptions.RemoveEmptyEntries)
+              .Last();
+          evaluation = Double.Parse(scoreString, CultureInfo.InvariantCulture);
+        }
+        catch (Exception ex) {
+          throw new Exception("Error parsing score string: " + ex);
+        }
+        finally {
+          DeleteRobotFiles(path, robotName);
+        }
       }
 
@@ -119 +118 @@
 
     private static void DeleteRobotFiles(string path, string outputname) {
-      try {
-        File.Delete(path + @"\robots\Evaluation\" + outputname + ".java");
-        File.Delete(path + @"\robots\Evaluation\" + outputname + ".class");
-      }
-      catch { }
+      File.Delete(path + @"\robots\Evaluation\" + outputname + ".java");
+      File.Delete(path + @"\robots\Evaluation\" + outputname + ".class");
     }
 
@@ -132 +128 @@
       }
       catch {
-        throw new Exception("Error finding required RoboCode files.");
+        throw new Exception("Error finding required Robocode files.");
       }
       return fileName;