Changeset 12858 for branches/HiveStatistics/sources/HeuristicLab.Services.WebApp.Statistics/3.3/WebApi/ExceptionController.cs

Timestamp:

08/13/15 15:22:51 (9 years ago)

Author:

ascheibe

Message:

#2388

• prevent disposing of hive data context
• more cleanups

File:

• branches/HiveStatistics/sources/HeuristicLab.Services.WebApp.Statistics/3.3/WebApi/ExceptionController.cs (modified) (1 diff)

branches/HiveStatistics/sources/HeuristicLab.Services.WebApp.Statistics/3.3/WebApi/ExceptionController.cs

@@ -35 +35 @@
 
     public DT.ExceptionPage GetExceptions(int page, int size) {
-      using (var pm = PersistenceManager) {
-        var dimClientDao = pm.DimClientDao;
-        var dimJobDao = pm.DimJobDao;
-        var factTaskDao = pm.FactTaskDao;
-        var tasks = factTaskDao.GetTasksWithException();
-        return pm.UseTransaction(() => new DT.ExceptionPage {
-          TotalExceptions = tasks.Count(),
-          Exceptions = (from factTask in tasks
-                        join dimJob in dimJobDao.GetAll() on factTask.JobId equals dimJob.JobId
-                        join dimClient in dimClientDao.GetAll() on factTask.LastClientId equals
-                          dimClient.Id into taskClientJoin
-                        from a in taskClientJoin.DefaultIfEmpty()
-                        let endTime = factTask.EndTime ?? DateTime.Now
-                        select new DT.Exception {
-                          TaskId = factTask.TaskId,
-                          JobId = factTask.JobId,
-                          JobName = dimJob.JobName,
-                          UserId = dimJob.UserId,
-                          UserName = dimJob.UserName,
-                          ClientId = factTask.LastClientId ?? default(Guid),
-                          ClientName = a != null ? a.Name : string.Empty,
-                          Date = endTime,
-                          Details = factTask.Exception
-                        })
-                        .OrderByDescending(x => x.Date)
-                        .Skip((page - 1) * size)
-                        .Take(size)
-                        .ToList()
-        });
-      }
+      var pm = PersistenceManager;
+      var dimClientDao = pm.DimClientDao;
+      var dimJobDao = pm.DimJobDao;
+      var factTaskDao = pm.FactTaskDao;
+      var tasks = factTaskDao.GetTasksWithException();
+      return pm.UseTransaction(() => new DT.ExceptionPage {
+        TotalExceptions = tasks.Count(),
+        Exceptions = (from factTask in tasks
+                      join dimJob in dimJobDao.GetAll() on factTask.JobId equals dimJob.JobId
+                      join dimClient in dimClientDao.GetAll() on factTask.LastClientId equals
+                        dimClient.Id into taskClientJoin
+                      from a in taskClientJoin.DefaultIfEmpty()
+                      let endTime = factTask.EndTime ?? DateTime.Now
+                      select new DT.Exception {
+                        TaskId = factTask.TaskId,
+                        JobId = factTask.JobId,
+                        JobName = dimJob.JobName,
+                        UserId = dimJob.UserId,
+                        UserName = dimJob.UserName,
+                        ClientId = factTask.LastClientId ?? default(Guid),
+                        ClientName = a != null ? a.Name : string.Empty,
+                        Date = endTime,
+                        Details = factTask.Exception
+                      })
+                      .OrderByDescending(x => x.Date)
+                      .Skip((page - 1) * size)
+                      .Take(size)
+                      .ToList()
+      });
     }
   }