Changeset 12858 for branches/HiveStatistics/sources/HeuristicLab.Services.Hive/3.3/Manager/AuthorizationManager.cs

Timestamp:

08/13/15 15:22:51 (9 years ago)

Author:

ascheibe

Message:

#2388

• prevent disposing of hive data context
• more cleanups

File:

• branches/HiveStatistics/sources/HeuristicLab.Services.Hive/3.3/Manager/AuthorizationManager.cs (modified) (1 diff)

branches/HiveStatistics/sources/HeuristicLab.Services.Hive/3.3/Manager/AuthorizationManager.cs

@@ -52 +52 @@
     public void AuthorizeForTask(Guid taskId, DT.Permission requiredPermission) {
       if (ServiceLocator.Instance.RoleVerifier.IsInRole(HiveRoles.Slave)) return; // slave-users can access all tasks
-      using (var pm = PersistenceManager) {
-        var taskDao = pm.TaskDao;
-        pm.UseTransaction(() => {
-          var task = taskDao.GetById(taskId);
-          if (task == null) throw new SecurityException(NOT_AUTHORIZED);
-          AuthorizeJob(pm, task.JobId, requiredPermission);
-        });
-      }
+      var pm = PersistenceManager;
+      var taskDao = pm.TaskDao;
+      pm.UseTransaction(() => {
+        var task = taskDao.GetById(taskId);
+        if (task == null) throw new SecurityException(NOT_AUTHORIZED);
+        AuthorizeJob(pm, task.JobId, requiredPermission);
+      });
     }
 
     public void AuthorizeForJob(Guid jobId, DT.Permission requiredPermission) {
-      using (var pm = PersistenceManager) {
-        pm.UseTransaction(() => {
-          AuthorizeJob(pm, jobId, requiredPermission);
-        });
-      }
+      var pm = PersistenceManager;
+      pm.UseTransaction(() => {
+        AuthorizeJob(pm, jobId, requiredPermission);
+      });
     }
 
     public void AuthorizeForResourceAdministration(Guid resourceId) {
-      using (var pm = PersistenceManager) {
-        var resourceDao = pm.ResourceDao;
-        pm.UseTransaction(() => {
-          var resource = resourceDao.GetById(resourceId);
-          if (resource == null) throw new SecurityException(NOT_AUTHORIZED);
-          if (resource.OwnerUserId != UserManager.CurrentUserId
-              && !RoleVerifier.IsInRole(HiveRoles.Administrator)) {
-            throw new SecurityException(NOT_AUTHORIZED);
-          }
-        });
-      }
+      var pm = PersistenceManager;
+      var resourceDao = pm.ResourceDao;
+      pm.UseTransaction(() => {
+        var resource = resourceDao.GetById(resourceId);
+        if (resource == null) throw new SecurityException(NOT_AUTHORIZED);
+        if (resource.OwnerUserId != UserManager.CurrentUserId
+            && !RoleVerifier.IsInRole(HiveRoles.Administrator)) {
+          throw new SecurityException(NOT_AUTHORIZED);
+        }
+      });
     }