Changes between Version 5 and Version 6 of ReviewHeuristicLab3.3.0CodeParameters

Timestamp:

03/15/10 16:33:51 (15 years ago)

Author:

mkommend

Comment:

--

ReviewHeuristicLab3.3.0CodeParameters

@@ -7 +7 @@
  * '''General''': Since a non-optional parameter could have the value null when it is constructed the optional parameter classes should be removed and all parameters should have the possibility of a null value.
  * '''General''': I would remove all default ctors of the parameter classes, so that a name must be specified during the construction.
+ * '''General''': A renaming of `OptionalXXXParameter` and `XXXParameter` should be considered. In my opinion it is more logical if `XXXParameter` could be null and `ObligateXXXParameter` must have a value specified.
 
  * '''IParameter''': The property `IItem ActualValue` should be renamed to `Value` unless there is a logical reason for the naming.
@@ -18 +19 @@
 
  * '''!OptionalValueParameter''': In the setter of the property `IItem IValueParameter.Value` it would be more readable to check the type with the `is` operator.
+ * '''!OptionalValueParamter''': A property `IsValueAssigned` or `ValueAssigned`, which checks if the value != null would be helpful and make the source code more readable.
 
  * '''!OptionalConstrainedValueParameter''': This class should be derived from `ValueParameter`.