Changes between Version 4 and Version 5 of ReviewHeuristicLab3.3.0CodeParameters

Timestamp:

03/12/10 14:16:45 (15 years ago)

Author:

mkommend

Comment:

--

ReviewHeuristicLab3.3.0CodeParameters

@@ -28 +28 @@
  * '''!LookupParameter''': A null check for the `ExecutionContext` should be inserted in every method which accesses it.
  * '''!LookupParameter''': As far as I understand the code, the `TranslateName` and the `GetParameter` method can be unified if `ValueLookupParameter` do not exists.
- 
- * to be continued: `ValueLookupParameter` and `SubScopesLookupParameter` are still waiting for their review
+ * '''!LookupParameter''': Why is the public static string `TranslateName` located in the `LookupParameter`? Is this the correct place or should it be located elsewhere (`IExecutionContext`)?
+
+ * '''!SubScopesLookupParameter''': In the `GetActualValueMethod` the name is translated by the `TranslateName` method. The name is translated upwards in the `ExecutionContext` hierarchy, but I am not sure if this behavior is intended.
+ * '''!SubScopesLookupParameter''': The `SubScopesLookupParameter` should have a property which returns a concrete `ItemArray<T>` as the value.
+ * '''!SubScopesLookupParameter''': I think it would be better to skip a value with a different type instead of throwing an exception in the `GetActualValue` method. In the `SetActualValue` a type check should also be applied to avoid exceptions.
 ----