Changes between Version 3 and Version 4 of ReviewHeuristicLab3.3.0CodeCore


Ignore:
Timestamp:
04/08/10 20:50:08 (11 years ago)
Author:
swagner
Comment:

--

Legend:

Unmodified
Added
Removed
Modified
  • ReviewHeuristicLab3.3.0CodeCore

    v3 v4  
    2424   * swagner: This is not allowed as `operator` is a reserved key word.
    2525
    26  * '''!ItemArray, !ItemCollection, !ItemList, !ItemSet, !NamedItemCollection''': Contain a misused property {{{private object RestoreEvents}}}. The functionality is used to register events on contained items after the object has been restored by the persistence framework. In my opinion the persistence framework should provide a more general mechanism to perform configurations / initialization tasks after the object creation.
     26 * '''!NamedItemCollection''': Contains a misused property {{{private object RestoreEvents}}}. The functionality is used to register events on contained items after the object has been restored by the persistence framework. In my opinion the persistence framework should provide a more general mechanism to perform configurations / initialization tasks after the object creation.
     27   * swagner: Changed in r3287. Used a `StorableHook` instead to register events after deserialization.
    2728
    2829 * '''!NamedItem''': The field {{{protected string name}}} should be private instead of protected. The intention was obviously to provide access to the field without firing events. However the field is only used in clone methods and ctors of derived classes and at this time no events listeners are registered. Hence the field could be made private without side effects. The same arguments apply for {{{protected string description field}}}.