Changes between Version 1 and Version 2 of ReviewHeuristicLab3.3.0CodeCore

Timestamp:

04/05/10 17:59:45 (15 years ago)

Author:

gkronber

Comment:

Added an issue with cloning of NamedItemCollections

ReviewHeuristicLab3.3.0CodeCore

@@ -31 +31 @@
  * '''!NamedItemCollection''': {{{NamedItemCollection}}} should implement {{{IItem}}}, because then the {{{IItem}}} implementation could be removed from the derived classes {{{VariableCollection}}} and {{{ParameterCollection}}}.
    * swagner: Done in r2790.
+
+== Reviewer: gkronber ==
+ * Implementation of `Clone()` in `NamedItemCollection` assumes that any class extending `NamedItemCollection` has a constructor with one argument of type `IEnumerable<T>`. This cannot be enforced in `NamedItemCollection` and leads to exceptions if a constructor with this signature is not available.