Version 2 (modified by swagner, 15 years ago) (diff) |
---|
Reviews - HeuristicLab 3.3.0 Application Review - Implemented Review Comments
Reviewer: abeham
Priority: HIGH
- Creating a new TSP problem and viewing the parameter "Coordinates": The view can be switched to an "OptionalValueParameterView" which adds a button to delete the value. However when clicked an exception is thrown that the value cannot be null. The OptionalValueParameterView should not be selectable (Coordinates is not an optional parameter). This also holds for other parameters like the SolutionCreator.
- swagner: Changed in r2948.
- When one creates a new user defined algorithm, the user finds a button called "Create User Defined Algorithm" button on the form. This feels strange.
- swagner: Set the button to be invisible in r2947.
- In the user defined algorithm:
- On the parameter tab: I press "+" to add a new Parameter. I select a ValueParameter, term it "MutationRate" and select DoubleData as type I get a MissingMethodException (Constructor on type ValueParameter not found).
- swagner: Fixed in r2948.
- On the parameter tab: I press "+" to add a new Parameter. I select a ValueParameter, term it "MutationRate" and select DoubleData as type I get a MissingMethodException (Constructor on type ValueParameter not found).
- The operator graph view is a bit confusing:
- Selecting an operator in "Operator Graph" does not bring up the details in the details view.
- swagner: Fixed in r2949.
- Should there really be a view host in the operator graph group box? It's confusing being able to switch views there (also because these are always just views on the initial operator which can be viewed with view host in the details group box as well).
- swagner: Removed view host in r2947.
- Selecting an operator in "Operator Graph" does not bring up the details in the details view.
- Creating a user defined algorithm from the SGA doesn't reconfigure the SGA operator with the parameters set in the SGA interface.
- swagner: Fixed as described in ticket #898.
Priority: MEDIUM
- The TSP problem view:
- How do I set the (allowed) evaluation operator?
- swagner: Enabled changing values of value parameters in r2948.
- How do I set the (allowed) evaluation operator?
- The ViewHost menu contains a lot of views which are quite similar. ItemView doesn't display anything, should it be selectable? ParameterView and NamedItemView are very similar. Sometimes there are only very fine differences between the views (e.g. a ParameterView and a NamedItemView).
- In my user defined algorithm:
- After selecting CurrentScope, all further parameters will be displayed as ParameterView and appear as if they cannot be changed. I had to change the view manually in the view host. Sometimes it seems to select the "wrong" default views. It reverts back to ParameterView as default as soon as CurrentScope is clicked again.
- swagner: Fixed in r2949.
- InversionManipulator has the "correct" actual name set already (Permutation), however in OrderCrossover the default names are "Parents" and "Child" which have to be changed to Permutation. This isn't obvious right away when the string description of the parameter says: "Child: Child (Permutation)".
- swagner: Set the actual name of the parents and child parameter to "Permutation" by default in r2947.
- After selecting CurrentScope, all further parameters will be displayed as ParameterView and appear as if they cannot be changed. I had to change the view manually in the view host. Sometimes it seems to select the "wrong" default views. It reverts back to ParameterView as default as soon as CurrentScope is clicked again.
- I'd wish there was just a value view as well. Sometimes I want to hide name, description, type, set, remove, ... elements and just display the value (e.g. when viewing the quality chart) (we discussed this)
- swagner: Added VariableValueView in r2989.
Priority: LOW
- Sequential engine should probably not be createable. At least currently there's nothing one could do with just an engine.
- swagner: Removed Creatable attribute in r2924.
- When creating e.g. a new TSP in the parameter collection view the tool tip doesn't really display the description of the parameter but just a very generic one.
- swagner: Changed to more specific tool tips in r2947.
- There is a typo in the description of the parameters (tooltips), it says "it" instead of "in".
- swagner: Fixed in r2947.
- "Breakpoint" doesn't explain if it breaks before or after executing the operator.
- swagner: Added tool tip in r2949.
- The available parameters view lists just one namespace which is collapsed by default (should be expanded if it's just this one).
- swagner: Changed in r2953.
- When you remove the value of the results (such as "BestQuality") the text in the box does not update.
- swagner: Fixed updating in r2989.
Reviewer: gkronber
Priority: HIGH
Priority: MEDIUM
- The execution state of an engine (e.g. Execution Time, Log...) is not persisted or restored correctly.
- swagner: Fixed storing and loading of an engine's execution time and state in r2933. The log is not stored and loaded at the moment, as it is not persisted in an engine but is only generated and shown in the view.
Priority: LOW
- Are keyboard shortcuts for groupboxes necessary? E.g. Details groupbox and Description shortcuts are conflicting. Value groupbox and Value textbox are conflicting.
- swagner: Removed keyboard shortcuts for all groupboxes in r2924.
- Description of RandomCreator should contain a hint about the type of PRNG that is created.
- swagner: Done in r2924.
Reviewer: swinkler
Priority: HIGH
- After starting an SGA the user is able to add a new problem; the OK button in the following dialog is initially enabled, clicking it causes no (?) action.
- swagner: Fixed in r2924.
- Adding a new parameter, for example a ValueParameter<IntData>, leads to an exception.
- swagner: Fixed in r2948.
- After starting a SGA with 130 cities TSP and population size 100 the memory consumption is 1.2 GB after approx. 6500 generations.
- swagner: Memory and runtime performance has been drastically improved in r2932.
Priority: MEDIUM
- After starting a new SGA and loading a problem the "play" button is enabled; clicking it leads to a error report that might be not interpretable by each potential user. A rather complicated check of all parameters would be needed here (as we had it for example in HL 2) - this might be not essentially necessary for the initial release (?), but maybe we could keep it in mind.
- swagner: This issue is similar to one of the issues described by maffenze. Changed in r2924 that a selection and a crossover operator are automatically selected if available to avoid the cryptic error message. In general I would prefer to set reasonable parameters by default instead of implementing some (probably quite sophisticated) parameter validation procedure.
- After starting the SGA the current generation index is not displayed; I have to switch to the qualities chart to see the current generation.
- swagner: Added generations counter to results in r2924.
- During the run of an algorithm the values displayed for the variables BestQuality, AverageQuality, and WorstQuality flicker.
- swagner: Fixed in r2924.
Priority: LOW
Reviewer: maffenze
Priority: HIGH
- When no crossover is selected an error message is thrown which gives no hint about the reason.
- swagner: This issue is similar to one of the issues described by swinkler. Changed in r2924 that a selection and a crossover operator are automatically selected if available to avoid the cryptic error message.
Priority: MEDIUM
Priority: LOW
- It is not obvious what is meant with the breakpoint option in an operator.
- swagner: Added tool tip in r2949.