19 | | * I don't really get the benefit of the Convert class, besides listing somehow related conversion operations. |
20 | | * AFAIK the TreeSimplifier is stateless? If that's the case why don't we provide a static method for simplification. e.g. {{{ var simplifiedTree = TreeSimplifier.Simplify(originalTree);}}}. |
21 | | * TreeToAutoDiffTermConverter encapsulates the functionality nicely. This new refactoring would also enable to use exception for control flow handling in TryConvertToAutoDiff(node,term) instead of always checking the transformation result (true or false). |
| 19 | * ~~I don't really get the benefit of the Convert class, besides listing somehow related conversion operations.~~ \\ gkronber: addressed with comment:22 |
| 20 | * ~~AFAIK the TreeSimplifier is stateless? If that's the case why don't we provide a static method for simplification. e.g. {{{ var simplifiedTree = TreeSimplifier.Simplify(originalTree);}}}.~~ \\ gkronber: addressed with comment:23 |
| 21 | * ~~TreeToAutoDiffTermConverter encapsulates the functionality nicely. This new refactoring would also enable to use exception for control flow handling in TryConvertToAutoDiff(node,term) instead of always checking the transformation result (true or false).~~ \\ gkronber: addressed with comment:24 |