Free cookie consent management tool by TermsFeed Policy Generator

Changes between Version 5 and Version 6 of Ticket #2697, comment 18


Ignore:
Timestamp:
05/09/17 20:10:35 (7 years ago)
Author:
gkronber
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #2697, comment 18

    v5 v6  
    1717
    1818=== Converters ===
    19 * I don't really get the benefit of the Convert class, besides listing somehow related conversion operations.
    20 * AFAIK the TreeSimplifier is stateless? If that's the case why don't we provide a static method for simplification. e.g. {{{ var simplifiedTree = TreeSimplifier.Simplify(originalTree);}}}.
    21 * TreeToAutoDiffTermConverter encapsulates the functionality nicely. This new refactoring would also enable to use exception for control flow handling in TryConvertToAutoDiff(node,term) instead of always checking the transformation result (true or false).
     19* ~~I don't really get the benefit of the Convert class, besides listing somehow related conversion operations.~~ \\ gkronber: addressed with comment:22
     20* ~~AFAIK the TreeSimplifier is stateless? If that's the case why don't we provide a static method for simplification. e.g. {{{ var simplifiedTree = TreeSimplifier.Simplify(originalTree);}}}.~~ \\ gkronber: addressed with comment:23
     21* ~~TreeToAutoDiffTermConverter encapsulates the functionality nicely. This new refactoring would also enable to use exception for control flow handling in TryConvertToAutoDiff(node,term) instead of always checking the transformation result (true or false).~~ \\ gkronber: addressed with comment:24
    2222
    2323