Free cookie consent management tool by TermsFeed Policy Generator

Changes between Initial Version and Version 1 of Ticket #1631, comment 10


Ignore:
Timestamp:
12/01/11 15:25:30 (13 years ago)
Author:
abeham
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1631, comment 10

    initial v1  
    33 * I would propose to make the class `sealed` and change the `protected` modifiers to `private`.
    44 * There's no need to implement `IDeepCloneable` yet again (in the class declaration) as `Item` and therefor `Log` already implement `IDeepCloneable`.
     5 * (I find it nicer to put the finally block on the same line as the closing brace.)
    56
    67Not related to these changes, but I think Log isn't a very fast implementation. It should actually use a `LinkedList<T>` instead of a `List<T>`. Correct me if I am wrong, but it seems that it is only performing operations at the ends of the list.