Free cookie consent management tool by TermsFeed Policy Generator

Opened 14 years ago

Closed 14 years ago

#1239 closed defect (done)

Some plugins have unnecessary or missing references / dependencies

Reported by: abeham Owned by: mkommend
Priority: low Milestone: HeuristicLab 3.3.2
Component: General Version: 3.3.2
Keywords: Cc: svonolfe

Description

I stumbled upon a reference / dependency bug in HeuristicLab.Problems.Knapsack.Views and HeuristicLab.Problems.OneMax.Views. Both plugins reference HeuristicLab.Optimizer which is not necessary. Also both views have a reference to HeuristicLab.Persistence which is also unnecessary as views are not serializable. There are several more probably unecessary dependencies such as to HeuristicLab.Collections, HeuristicLab.Optimization, or HeuristicLab.Optimization.Views that can be removed.

Change History (15)

comment:1 Changed 14 years ago by abeham

  • Status changed from new to accepted

comment:2 Changed 14 years ago by abeham

  • Owner changed from abeham to swagner
  • Status changed from accepted to reviewing

r4627

  • For HeuristicLab.Problems.(Knapsack|OneMax).Views removed dependencies to:
    • HeuristicLab.Collections
    • HeuristicLab.Common.Resources
    • HeuristicLab.Optimization.Views
    • HeuristicLab.Optimization
    • HeuristicLab.Optimizer
    • HeuristicLab.Persistence (only the project reference)

comment:3 Changed 14 years ago by mkommend

  • Owner changed from swagner to mkommend
  • Status changed from reviewing to assigned

comment:4 Changed 14 years ago by mkommend

  • Status changed from assigned to accepted

comment:5 Changed 14 years ago by mkommend

Corrected PluginDependenciesTest to check unnecessary dependencies with 4164.

Version 0, edited 14 years ago by mkommend (next)

comment:6 Changed 14 years ago by mkommend

Corrected all plugin frame files according to the results of the unit test with r4633.

comment:7 Changed 14 years ago by mkommend

  • Owner changed from mkommend to abeham
  • Status changed from accepted to reviewing

comment:8 Changed 14 years ago by mkommend

  • Owner changed from abeham to mkommend
  • Status changed from reviewing to assigned

comment:9 Changed 14 years ago by mkommend

The HL3.3 tests project does not reference all projects present in the trunk solution.

comment:10 Changed 14 years ago by mkommend

  • Status changed from assigned to accepted

comment:11 Changed 14 years ago by mkommend

  • Owner changed from mkommend to abeham
  • Status changed from accepted to reviewing

Updated test project references and corrected previously untested frame files with r4634.

comment:12 follow-up: Changed 14 years ago by abeham

  • Owner changed from abeham to mkommend
  • Status changed from reviewing to assigned

Ok. Please include project references to recently added plugins such as allele frequency analysis and diversity analysis or tell and show the owners of these plugins to do it.

comment:13 in reply to: ↑ 12 Changed 14 years ago by mkommend

  • Status changed from assigned to accepted

Replying to abeham:

Ok. Please include project references to recently added plugins such as allele frequency analysis and diversity analysis or tell and show the owners of these plugins to do it.

comment:14 Changed 14 years ago by mkommend

  • Status changed from accepted to readytorelease

All projects in the trunk solution are referenced by the HL3.Tests project. The allele frequency as well as the diversity analysis are not implemented as single plugins, but have been included into HL.Analysis which was already referenced.

comment:15 Changed 14 years ago by swagner

  • Resolution set to done
  • Status changed from readytorelease to closed
  • Version changed from 3.3.1 to 3.3.2
Note: See TracTickets for help on using tickets.