Changeset 9744

Timestamp:

07/24/13 12:51:02 (6 years ago)

Author:

gkronber

Message:

#1508 refactoring: removed unused classes, unified calculation of profits and signals, implemented profit-evaluator.

Location:

branches/HeuristicLab.Problems.DataAnalysis.Trading/HeuristicLab.Problems.DataAnalysis.Trading/3.4

Files:

• Calculators/OnlineProfitCalculator.cs (modified) (6 diffs)
• Calculators/OnlineSharpeRatioCalculator.cs (modified) (4 diffs)
• HeuristicLab.Problems.DataAnalysis.Trading-3.4.csproj (modified) (3 diffs)
• Interfaces/ITradingEnsembleModel.cs (deleted)
• Symbolic/SingleObjective/ProfitEvaluator.cs (added)
• Symbolic/SingleObjective/SymbolicTradingSingleObjectiveSharpeRatioEvaluator.cs (modified) (1 diff)
• Symbolic/SymbolicTradingModel.cs (modified) (1 diff)
• Symbolic/SymbolicTradingSolution.cs (modified) (4 diffs)
• TradingEnsembleModel.cs (deleted)
• TradingProblemData.cs (modified) (4 diffs)
• TradingSolution.cs (modified) (2 diffs)
• Views/TradingSolutionLineChartView.cs (modified) (5 diffs)

branches/HeuristicLab.Problems.DataAnalysis.Trading/HeuristicLab.Problems.DataAnalysis.Trading/3.4/Calculators/OnlineProfitCalculator.cs

@@ -22 +22 @@
 using System;
 using System.Collections.Generic;
+using System.Linq;
 using HeuristicLab.Common;
 
@@ -28 +29 @@
 
     private int p;
-    private double transactionCost;
+    private readonly double transactionCost;
     private int c;
     private double sum;
@@ -63 +64 @@
         } else if (p == 0 && signal.IsAlmost(1)) {
           p = 1;
+          iterationReturn = -transactionCost;
         } else if (p == 0 && signal.IsAlmost(-1)) {
           p = -1;
+          iterationReturn = -transactionCost;
         } else if (p == 1 && signal.IsAlmost(1)) {
           iterationReturn = actualReturn;
@@ -89 +92 @@
 
     public static double Calculate(IEnumerable<double> returns, IEnumerable<double> signals, double transactionCost, out OnlineCalculatorError errorState) {
+      errorState = OnlineCalculatorError.None;
+      return GetProfits(returns, signals, transactionCost).Sum();
+    }
+
+    public static IEnumerable<double> GetProfits(IEnumerable<double> returns, IEnumerable<double> signals, double transactionCost) {
+      var calc = new OnlineProfitCalculator(transactionCost);
+
       IEnumerator<double> returnsEnumerator = returns.GetEnumerator();
       IEnumerator<double> signalsEnumerator = signals.GetEnumerator();
-      OnlineProfitCalculator calculator = new OnlineProfitCalculator(transactionCost);
 
       // always move forward both enumerators (do not use short-circuit evaluation!)
@@ -97 +106 @@
         double signal = signalsEnumerator.Current;
         double @return = returnsEnumerator.Current;
-        calculator.Add(@return, signal);
+
+        double prevTotalProfit = calc.Profit;
+        calc.Add(@return, signal);
+        double curTotalProfit = calc.Profit;
+
+        yield return curTotalProfit - prevTotalProfit;
       }
 
@@ -103 +117 @@
       if (returnsEnumerator.MoveNext() || signalsEnumerator.MoveNext()) {
         throw new ArgumentException("Number of elements in first and second enumeration doesn't match.");
-      } else {
-        errorState = calculator.ErrorState;
-        return calculator.Profit;
       }
     }

branches/HeuristicLab.Problems.DataAnalysis.Trading/HeuristicLab.Problems.DataAnalysis.Trading/3.4/Calculators/OnlineSharpeRatioCalculator.cs

@@ -22 +22 @@
 using System;
 using System.Collections.Generic;
-using HeuristicLab.Common;
 
 namespace HeuristicLab.Problems.DataAnalysis.Trading {
   public class OnlineSharpeRatioCalculator : IOnlineCalculator {
 
-    private int p;
-    private double transactionCost;
-    private int c;
     private OnlineMeanAndVarianceCalculator meanAndVarianceCalculator;
+    private OnlineProfitCalculator profitCalculator;
+
     public double SharpeRatio {
       get {
@@ -40 +38 @@
 
     public OnlineSharpeRatioCalculator(double transactionCost) {
-      this.transactionCost = transactionCost;
       this.meanAndVarianceCalculator = new OnlineMeanAndVarianceCalculator();
+      this.profitCalculator = new OnlineProfitCalculator(transactionCost);
       Reset();
     }
@@ -48 +46 @@
     public OnlineCalculatorError ErrorState {
       get {
-        return meanAndVarianceCalculator.MeanErrorState | meanAndVarianceCalculator.VarianceErrorState;
+        return meanAndVarianceCalculator.MeanErrorState | meanAndVarianceCalculator.VarianceErrorState | profitCalculator.ErrorState;
       }
     }
@@ -55 +53 @@
     }
     public void Reset() {
-      p = 0;
-      c = 0;
+      profitCalculator.Reset();
       meanAndVarianceCalculator.Reset();
     }
 
     public void Add(double actualReturn, double signal) {
-      double iterationReturn = 0.0;
-      if (c == 0) {
-        p = (int)signal;
-        iterationReturn = 0;
-        c++;
-      } else {
-        if (p == 0 && signal.IsAlmost(0)) {
-        } else if (p == 0 && signal.IsAlmost(1)) {
-          p = 1;
-        } else if (p == 0 && signal.IsAlmost(-1)) {
-          p = -1;
-        } else if (p == 1 && signal.IsAlmost(1)) {
-          iterationReturn = actualReturn;
-        } else if (p == 1 && signal.IsAlmost(0)) {
-          iterationReturn = actualReturn - transactionCost;
-          p = 0;
-        } else if (p == 1 && signal.IsAlmost(-1)) {
-          iterationReturn = actualReturn - transactionCost;
-          p = -1;
-        } else if (p == -1 && signal.IsAlmost(-1)) {
-          iterationReturn = -actualReturn;
-        } else if (p == -1 && signal.IsAlmost(0)) {
-          iterationReturn = -actualReturn - transactionCost;
-          p = 0;
-        } else if (p == -1 && signal.IsAlmost(1)) {
-          iterationReturn = -actualReturn - transactionCost;
-          p = 1;
-        }
-        c++;
-      }
-      meanAndVarianceCalculator.Add(iterationReturn);
+      double prevTotalProfit = profitCalculator.Profit;
+      profitCalculator.Add(actualReturn, signal);
+      double curTotalProfit = profitCalculator.Profit;
+
+      meanAndVarianceCalculator.Add(curTotalProfit - prevTotalProfit);
     }
     #endregion

branches/HeuristicLab.Problems.DataAnalysis.Trading/HeuristicLab.Problems.DataAnalysis.Trading/3.4/HeuristicLab.Problems.DataAnalysis.Trading-3.4.csproj

@@ -161 +161 @@
     <Compile Include="Calculators\OnlineProfitCalculator.cs" />
     <Compile Include="HeuristicLabProblemsDataAnalysisTradingPlugin.cs" />
-    <Compile Include="Interfaces\ITradingEnsembleModel.cs" />
     <Compile Include="Interfaces\ITradingModel.cs" />
     <Compile Include="Interfaces\ITradingProblem.cs" />
@@ -171 +170 @@
     <Compile Include="Symbolic\Interfaces\ISymbolicTradingSingleObjectiveEvaluator.cs" />
     <Compile Include="Symbolic\Interfaces\ISymbolicTradingSolution.cs" />
+    <Compile Include="Symbolic\SingleObjective\ProfitEvaluator.cs" />
     <Compile Include="Symbolic\SingleObjective\SymbolicTradingSingleObjectiveEvaluator.cs" />
     <Compile Include="Symbolic\SingleObjective\SymbolicTradingSingleObjectiveProblem.cs" />
@@ -184 +184 @@
       <DependentUpon>SymbolicTradingSolutionView.cs</DependentUpon>
     </Compile>
-    <Compile Include="TradingEnsembleModel.cs" />
     <Compile Include="TradingProblem.cs" />
     <Compile Include="TradingProblemData.cs" />

branches/HeuristicLab.Problems.DataAnalysis.Trading/HeuristicLab.Problems.DataAnalysis.Trading/3.4/Symbolic/SingleObjective/SymbolicTradingSingleObjectiveSharpeRatioEvaluator.cs

@@ -68 +68 @@
 
     private static IEnumerable<double> GetSignals(ISymbolicDataAnalysisExpressionTreeInterpreter interpreter, ISymbolicExpressionTree solution, Dataset dataset, IEnumerable<int> rows) {
-      return from x in interpreter.GetSymbolicExpressionTreeValues(solution, dataset, rows)
-             select x > 0.5 ? 1.0 : x < 0.5 ? -1.0 : 0.0;
+      return SymbolicTradingModel.GetSignals(interpreter.GetSymbolicExpressionTreeValues(solution, dataset, rows));
     }
 
     public override double Evaluate(IExecutionContext context, ISymbolicExpressionTree tree, ITradingProblemData problemData, IEnumerable<int> rows) {
       SymbolicDataAnalysisTreeInterpreterParameter.ExecutionContext = context;
-
       double sharpRatio = Calculate(SymbolicDataAnalysisTreeInterpreterParameter.ActualValue, tree, problemData, rows);
-
       SymbolicDataAnalysisTreeInterpreterParameter.ExecutionContext = null;
-
       return sharpRatio;
     }

branches/HeuristicLab.Problems.DataAnalysis.Trading/HeuristicLab.Problems.DataAnalysis.Trading/3.4/Symbolic/SymbolicTradingModel.cs

@@ -49 +49 @@
       ISymbolicDataAnalysisExpressionTreeInterpreter interpreter = Interpreter;
       ISymbolicExpressionTree tree = SymbolicExpressionTree;
-      return from x in interpreter.GetSymbolicExpressionTreeValues(tree, dataset, rows)
-             select x > 0.66 ? 1.0 : x < 0.33 ? -1.0 : 0.0;
+      return GetSignals(interpreter.GetSymbolicExpressionTreeValues(tree, dataset, rows));
+    }
+
+    // Transforms an enumerable of real values to an enumerable of trading signals (buy(1) / hold(0) / sell(-1))
+    public static IEnumerable<double> GetSignals(IEnumerable<double> xs) {
+      // two iterations over xs
+      // 1) determine min / max to calculate the mid-range value
+      // 2) range is split into three thirds
+      double max = double.NegativeInfinity;
+      double min = double.PositiveInfinity;
+      foreach (var x in xs) {
+        if (x > max) max = x;
+        if (x < min) min = x;
+      }
+      if (double.IsInfinity(max) || double.IsNaN(max) || double.IsInfinity(min) || double.IsNaN(min))
+        return xs.Select(x => 0.0);
+
+      double range = (max - min);
+      double midRange = range / 2.0 + min;
+      double offset = range / 6.0;
+      return from x in xs
+             select x > midRange + offset ? 1.0 : x < midRange - offset ? -1.0 : 0.0;
     }
   }

branches/HeuristicLab.Problems.DataAnalysis.Trading/HeuristicLab.Problems.DataAnalysis.Trading/3.4/Symbolic/SymbolicTradingSolution.cs

@@ -32 +32 @@
   /// </summary>
   [StorableClass]
-  [Item(Name = "SymbolicTradingSolution", Description = "Represents a symbolic trading solution (model + data) and attributes of the solution like accuracy and complexity.")]
+  [Item(Name = "SymbolicTradingSolution",
+    Description =
+      "Represents a symbolic trading solution (model + data) and attributes of the solution like accuracy and complexity."
+    )]
   public sealed class SymbolicTradingSolution : TradingSolution, ISymbolicTradingSolution {
     private const string ModelLengthResultName = "Model Length";
@@ -41 +44 @@
       set { base.Model = value; }
     }
+
     ISymbolicDataAnalysisModel ISymbolicDataAnalysisSolution.Model {
       get { return (ISymbolicDataAnalysisModel)base.Model; }
     }
+
     public int ModelLength {
       get { return ((IntValue)this[ModelLengthResultName].Value).Value; }
@@ -55 +60 @@
 
     [StorableConstructor]
-    private SymbolicTradingSolution(bool deserializing) : base(deserializing) { }
+    private SymbolicTradingSolution(bool deserializing)
+      : base(deserializing) {
+    }
+
     private SymbolicTradingSolution(SymbolicTradingSolution original, Cloner cloner)
       : base(original, cloner) {
     }
+
     public SymbolicTradingSolution(ISymbolicTradingModel model, ITradingProblemData problemData)
       : base(model, problemData) {
@@ -75 +84 @@
     }
 
-    private new void RecalculateResults() {
+    protected override void RecalculateResults() {
+      base.RecalculateResults();
+      CalculateResults();
+    }
+
+    private void CalculateResults() {
       ModelLength = Model.SymbolicExpressionTree.Length;
       ModelDepth = Model.SymbolicExpressionTree.Depth;

branches/HeuristicLab.Problems.DataAnalysis.Trading/HeuristicLab.Problems.DataAnalysis.Trading/3.4/TradingProblemData.cs

@@ -37 +37 @@
 
     #region default data
-    private static double[,] audInUsd = new double[,] {
+    private static double[,] audInUsdDiff = new double[,] {
     { 0.0000},
     { 0.0003},
@@ -1589 +1589 @@
 
     static TradingProblemData() {
-      defaultDataset = new Dataset(new string[] { "AUD" }, audInUsd);
+      defaultDataset = new Dataset(new string[] { "AUD" }, audInUsdDiff);
       defaultDataset.Name = "AUD in USD";
       defaultDataset.Description = "Price of Australian dollar in US dollar.";
@@ -1630 +1630 @@
       : base(dataset, allowedInputVariables) {
       var variables = InputVariables.Select(x => x.AsReadOnly()).ToList();
-      Parameters.Add(new ConstrainedValueParameter<StringValue>(PriceVariableParameterName, new ItemSet<StringValue>(variables), variables.Where(x => x.Value == targetVariable).First()));
+      Parameters.Add(new ConstrainedValueParameter<StringValue>(PriceVariableParameterName, new ItemSet<StringValue>(variables), variables.First(x => x.Value == targetVariable)));
       Parameters.Add(new FixedValueParameter<DoubleValue>(TransactionCostsParameterName, "The absolute cost of on buy/sell transaction (assumed to be constant and independent of transaction volume)", new DoubleValue(0.0002)));
       RegisterParameterEvents();
@@ -1646 +1646 @@
       OnChanged();
     }
-
-    
-
-
-    //#region Import from file
-    //public static TradingProblemData ImportFromFile(string fileName) {
-    //  TableFileParser csvFileParser = new TableFileParser();
-    //  csvFileParser.Parse(fileName);
-
-    //  Dataset dataset = new Dataset(csvFileParser.VariableNames, csvFileParser.Values);
-    //  dataset.Name = Path.GetFileName(fileName);
-
-    //  TradingProblemData problemData = new TradingProblemData(dataset, dataset.VariableNames.Skip(1), dataset.VariableNames.First());
-    //  problemData.Name = "Data imported from " + Path.GetFileName(fileName);
-    //  return problemData;
-    //}
-    //#endregion
   }
 }

branches/HeuristicLab.Problems.DataAnalysis.Trading/HeuristicLab.Problems.DataAnalysis.Trading/3.4/TradingSolution.cs

@@ -78 +78 @@
       Add(new Result(TrainingProfitResultName, "Profit of the model on the training partition", new DoubleValue()));
       Add(new Result(TestProfitResultName, "Profit of the model on the test partition", new DoubleValue()));
-
-      RecalculateResults();
     }
 
@@ -94 +92 @@
 
     protected override void RecalculateResults() {
+      CalculateTradingResults();
+    }
+
+    protected void CalculateTradingResults() {
       double[] trainingSignals = TrainingSignals.ToArray(); // cache values
       IEnumerable<double> trainingReturns = ProblemData.Dataset.GetDoubleValues(ProblemData.PriceVariable, ProblemData.TrainingIndices);

branches/HeuristicLab.Problems.DataAnalysis.Trading/HeuristicLab.Problems.DataAnalysis.Trading/3.4/Views/TradingSolutionLineChartView.cs

@@ -25 +25 @@
 using System.Windows.Forms;
 using System.Windows.Forms.DataVisualization.Charting;
-using HeuristicLab.Common;
 using HeuristicLab.MainForm;
-using HeuristicLab.MainForm.WindowsForms;
 using HeuristicLab.Problems.DataAnalysis.Views;
 
@@ -61 +59 @@
       this.chart.Series.Clear();
       if (Content != null) {
-        //this.chart.Series.Add(PRICEVARIABLE_SERIES_NAME);
-        //this.chart.Series[PRICEVARIABLE_SERIES_NAME].LegendText = Content.ProblemData.PriceVariable;
-        //this.chart.Series[PRICEVARIABLE_SERIES_NAME].ChartType = SeriesChartType.FastLine;
-        //this.chart.Series[PRICEVARIABLE_SERIES_NAME].Points.DataBindY(Content.ProblemData.Dataset.GetVariableValues(Content.ProblemData.PriceVariable));
-
-
         this.chart.Series.Add(SIGNALS_SERIES_NAME);
         this.chart.Series[SIGNALS_SERIES_NAME].LegendText = SIGNALS_SERIES_NAME;
@@ -80 +72 @@
         this.chart.Series[PRICEVARIABLE_SERIES_NAME].Tag = Content;
 
-        IEnumerable<double> profit = GetProfits(Content.ProblemData.Dataset.GetDoubleValues(Content.ProblemData.PriceVariable), Content.Signals, Content.ProblemData.TransactionCosts);
+        IEnumerable<double> profit = OnlineProfitCalculator.GetProfits(Content.ProblemData.Dataset.GetDoubleValues(Content.ProblemData.PriceVariable), Content.Signals, Content.ProblemData.TransactionCosts);
         IEnumerable<double> accumulatedProfits = GetAccumulatedPrices(profit);
         this.chart.Series.Add(ASSET_SERIES_NAME);
@@ -89 +81 @@
 
         this.UpdateStripLines();
-
-        // UpdateCursorInterval();
-      }
-    }
-
-    private IEnumerable<double> GetProfits(IEnumerable<double> returns, IEnumerable<double> signals, double transactionCost) {
-      int p = (int)signals.First();
-      yield return 0.0;
-      foreach (var signalReturn in returns.Skip(1).Zip(signals.Skip(1), (r, s) => new { Return = r, Signal = s })) {
-        double iterationReturn = 0;
-        double signal = signalReturn.Signal;
-        double actualReturn = signalReturn.Return;
-        if (p == 0 && signal.IsAlmost(0)) {
-        } else if (p == 0 && signal.IsAlmost(1)) {
-          iterationReturn = 0;
-          p = 1;
-        } else if (p == 0 && signal.IsAlmost(-1)) {
-          iterationReturn = 0;
-          p = -1;
-        } else if (p == 1 && signal.IsAlmost(1)) {
-          iterationReturn = actualReturn;
-        } else if (p == 1 && signal.IsAlmost(0)) {
-          iterationReturn = actualReturn - transactionCost;
-          p = 0;
-        } else if (p == 1 && signal.IsAlmost(-1)) {
-          iterationReturn = actualReturn - transactionCost;
-          p = -1;
-        } else if (p == -1 && signal.IsAlmost(-1)) {
-          iterationReturn = -actualReturn;
-        } else if (p == -1 && signal.IsAlmost(0)) {
-          iterationReturn = -actualReturn - transactionCost;
-          p = 0;
-        } else if (p == -1 && signal.IsAlmost(1)) {
-          iterationReturn = -actualReturn - transactionCost;
-          p = 1;
-        }
-        yield return iterationReturn;
       }
     }
@@ -136 +91 @@
       }
     }
-
-    //private void UpdateCursorInterval() {
-    //  var estimatedValues = this.chart.Series[SIGNALS_SERIES_NAME].Points.Select(x => x.YValues[0]).DefaultIfEmpty(1.0);
-    //  var targetValues = this.chart.Series[PRICEVARIABLE_SERIES_NAME].Points.Select(x => x.YValues[0]).DefaultIfEmpty(1.0);
-    //  double estimatedValuesRange = estimatedValues.Max() - estimatedValues.Min();
-    //  double targetValuesRange = targetValues.Max() - targetValues.Min();
-    //  double interestingValuesRange = Math.Min(Math.Max(targetValuesRange, 1.0), Math.Max(estimatedValuesRange, 1.0));
-    //  double digits = (int)Math.Log10(interestingValuesRange) - 3;
-    //  double yZoomInterval = Math.Max(Math.Pow(10, digits), 10E-5);
-    //  this.chart.ChartAreas[0].CursorY.Interval = yZoomInterval;
-    //}
 
     #region events