Changeset 937

Timestamp:

12/10/08 13:47:17 (16 years ago)

Author:

msteinbi

Message:

Implementation of UserRoleManager (#417)

Location:

trunk/sources

Files:

• HeuristicLab.Hive.Contracts/ApplicationConstants.cs (modified) (1 diff)
• HeuristicLab.Hive.Contracts/BusinessObjects/ClientGroup.cs (modified) (1 diff)
• HeuristicLab.Hive.Contracts/HiveServerMessages.resx (modified) (1 diff)
• HeuristicLab.Hive.Server.Core/ClientManager.cs (modified) (2 diffs)
• HeuristicLab.Hive.Server.Core/UserRoleManager.cs (modified) (3 diffs)

trunk/sources/HeuristicLab.Hive.Contracts/ApplicationConstants.cs

@@ -19 +19 @@
     public static string RESPONSE_USERROLE_PERMISSIONOWNER_ADDED = "UserRole.PermissionOwnerAdded";
     public static string RESPONSE_USERROLE_GET_ALL_USERGROUPS = "UserRole.AllUserGroupsReturned";
+    public static string RESPONSE_USERROLE_ID_MUST_NOT_BE_SET = "UserRole.IdMustNotBeSet";
 
     public static string RESPONSE_CLIENT_GET_ALL_CLIENTS = "Client.GetAllClients";

trunk/sources/HeuristicLab.Hive.Contracts/BusinessObjects/ClientGroup.cs

@@ -31 +31 @@
   public class ClientGroup : Resource {
     [DataMember]
-    public long ClientGroupId { get; set; }
-    [DataMember]
     public List<Resource> Resources { get; set; }
 

trunk/sources/HeuristicLab.Hive.Contracts/HiveServerMessages.resx

@@ -178 +178 @@
     <value>User successfully added to database</value>
   </data>
+  <data name="UserRole.IdMustNotBeSet" xml:space="preserve">
+    <value>In this context the id must not be set</value>
+  </data>
 </root>

trunk/sources/HeuristicLab.Hive.Server.Core/ClientManager.cs

@@ -43 +43 @@
       clientGroups = new List<ClientGroup>();
 
-      ClientGroup cg = new ClientGroup { ResourceId = 4, Name = "SuperGroup", ClientGroupId = 1 };
+      ClientGroup cg = new ClientGroup { ResourceId = 4, Name = "SuperGroup" };
       cg.Resources = new List<Resource>();
 
@@ -78 +78 @@
 
     public Response AddClientGroup(ClientGroup clientGroup) {
-      throw new NotImplementedException();
+      Response response = new Response();
+
+      ClientGroup clientGroupFromDb = clientGroupAdapter.GetClientGroupById(clientGroup.ResourceId);
+      
+
+      return response;
     }
 

trunk/sources/HeuristicLab.Hive.Server.Core/UserRoleManager.cs

@@ -37 +37 @@
       Response response = new Response();
 
-      User dbUser = userAdapter.GetUserByName(user.Name);
-      if (dbUser != null) {
+      if (user.PermissionOwnerId != null) {
         response.Success = false;
-        response.StatusMessage = ApplicationConstants.RESPONSE_USERROLE_USER_EXISTS_ALLREADY;
+        response.StatusMessage = ApplicationConstants.RESPONSE_USERROLE_ID_MUST_NOT_BE_SET;
         return response;
       }
@@ -77 +76 @@
     public Response AddNewUserGroup(UserGroup userGroup) {
       Response response = new Response();
-
-      UserGroup userGroupFromDb = userGroupAdapter.GetUserGroupById(userGroup.PermissionOwnerId);
-      if (userGroupFromDb != null) {
+      
+      if (userGroup.PermissionOwnerId != null) {
         response.Success = false;
-        response.StatusMessage = ApplicationConstants.RESPONSE_USERROLE_USERGROUP_EXISTS_ALLREADY;
+        response.StatusMessage = ApplicationConstants.RESPONSE_USERROLE_ID_MUST_NOT_BE_SET;
         return response;
       }
@@ -109 +107 @@
     public Response AddPermissionOwnerToGroup(long groupId, PermissionOwner permissionOwner) {
       Response response = new Response();
-      
+
+      if (permissionOwner.PermissionOwnerId != null) {
+        response.Success = false;
+        response.StatusMessage = ApplicationConstants.RESPONSE_USERROLE_ID_MUST_NOT_BE_SET;
+        return response;
+      }
+
       UserGroup userGroup = userGroupAdapter.GetUserGroupById(groupId);
       if (userGroup == null) {