Changeset 8707 for branches/HiveTaskScheduler/HeuristicLab.Services.Hive

Timestamp:

09/28/12 10:49:02 (12 years ago)

Author:

jkarder

Message:

#1712: added user queue used to schedule tasks

Location:

branches/HiveTaskScheduler/HeuristicLab.Services.Hive/3.3

Files:

• Convert.cs (modified) (2 diffs)
• DataTransfer/UserPriority.cs (modified) (1 diff)
• HiveDao.cs (modified) (2 diffs)
• Interfaces/IHiveDao.cs (modified) (1 diff)
• Manager/HeartbeatManager.cs (modified) (3 diffs)
• Properties/Settings.Designer.cs (modified) (2 diffs)
• Properties/Settings.settings (modified) (1 diff)
• Scheduler/RoundRobinTaskScheduler.cs (modified) (3 diffs)
• app.config (modified) (1 diff)

branches/HiveTaskScheduler/HeuristicLab.Services.Hive/3.3/Convert.cs

@@ -531 +531 @@
     public static DT.UserPriority ToDto(DB.UserPriority source) {
       if (source == null) return null;
-      return new DT.UserPriority() { UserId = source.UserId };
+      return new DT.UserPriority() { Id = source.UserId, DateEnqueued = source.DateEnqueued };
     }
     public static DB.UserPriority ToEntity(DT.UserPriority source) {
@@ -540 +540 @@
     public static void ToEntity(DT.UserPriority source, DB.UserPriority target) {
       if ((source != null) && (target != null)) {
-        target.UserId = source.UserId;
+        target.UserId = source.Id;
+        target.DateEnqueued = source.DateEnqueued;
       }
     }

branches/HiveTaskScheduler/HeuristicLab.Services.Hive/3.3/DataTransfer/UserPriority.cs

@@ -28 +28 @@
   public class UserPriority : HiveItem {
     [DataMember]
-    public Guid UserId { get; set; }
+    public DateTime DateEnqueued { get; set; }
   }
 }

branches/HiveTaskScheduler/HeuristicLab.Services.Hive/3.3/HiveDao.cs

@@ -259 +259 @@
         var entity = DT.Convert.ToEntity(dto);
         db.Jobs.InsertOnSubmit(entity);
+        if (!db.Jobs.Any(x => x.OwnerUserId == dto.OwnerUserId))
+          EnqueueUserPriority(new DT.UserPriority { Id = dto.OwnerUserId, DateEnqueued = dto.DateCreated });
         db.SubmitChanges();
         return entity.JobId;
@@ -863 +865 @@
       }
     }
+
+    public void EnqueueUserPriority(DT.UserPriority dto) {
+      using (var db = CreateContext()) {
+        var entity = db.UserPriorities.FirstOrDefault(x => x.UserId == dto.Id);
+        if (entity == null) db.UserPriorities.InsertOnSubmit(DT.Convert.ToEntity(dto));
+        else DT.Convert.ToEntity(dto, entity);
+        db.SubmitChanges();
+      }
+    }
     #endregion
 

branches/HiveTaskScheduler/HeuristicLab.Services.Hive/3.3/Interfaces/IHiveDao.cs

@@ -154 +154 @@
     #region UserPriority Methods
     IEnumerable<DT.UserPriority> GetUserPriorities(Expression<Func<UserPriority, bool>> predicate);
+    void EnqueueUserPriority(DT.UserPriority userPriority);
     #endregion
   }

branches/HiveTaskScheduler/HeuristicLab.Services.Hive/3.3/Manager/HeartbeatManager.cs

@@ -23 +23 @@
 using System.Collections.Generic;
 using System.Linq;
+using System.Threading;
 using HeuristicLab.Services.Hive.DataTransfer;
 using DA = HeuristicLab.Services.Hive.DataAccess;
@@ -28 +29 @@
 namespace HeuristicLab.Services.Hive {
   public class HeartbeatManager {
+    private const string MutexName = "HiveTaskSchedulingMutex";
+
     private IHiveDao dao {
       get { return ServiceLocator.Instance.HiveDao; }
@@ -63 +66 @@
         // assign new task
         if (heartbeat.AssignJob && slave.IsAllowedToCalculate && heartbeat.FreeCores > 0) {
-          var availableJobs = taskScheduler.Schedule(dao.GetWaitingTasks(slave));
-          if (availableJobs.Any()) {
-            var job = availableJobs.First();
-            if (AssignJob(slave, job))
-              actions.Add(new MessageContainer(MessageContainer.MessageType.CalculateTask, job.Id));
+          bool mutexAquired = false;
+          var mutex = new Mutex(false, MutexName);
+          try {
+            mutexAquired = mutex.WaitOne(Properties.Settings.Default.SchedulingPatience);
+            if (!mutexAquired)
+              DA.LogFactory.GetLogger(this.GetType().Namespace).Log("HeartbeatManager: The mutex used for scheduling could not be aquired.");
+            else {
+              var availableJobs = taskScheduler.Schedule(dao.GetWaitingTasks(slave));
+              if (availableJobs.Any()) {
+                var job = availableJobs.First();
+                if (AssignJob(slave, job))
+                  actions.Add(new MessageContainer(MessageContainer.MessageType.CalculateTask, job.Id));
+              }
+            }
+          }
+          catch (AbandonedMutexException) {
+            DA.LogFactory.GetLogger(this.GetType().Namespace).Log("HeartbeatManager: The mutex used for scheduling has been abandoned.");
+          }
+          finally {
+            if (mutexAquired) mutex.ReleaseMutex();
           }
         }

branches/HiveTaskScheduler/HeuristicLab.Services.Hive/3.3/Properties/Settings.Designer.cs

@@ -2 +2 @@
 // <auto-generated>
 //     This code was generated by a tool.
-//     Runtime Version:4.0.30319.269
+//     Runtime Version:4.0.30319.17929
 //
 //     Changes to this file may cause incorrect behavior and will be lost if
@@ -77 +77 @@
             }
         }
+        
+        [global::System.Configuration.ApplicationScopedSettingAttribute()]
+        [global::System.Diagnostics.DebuggerNonUserCodeAttribute()]
+        [global::System.Configuration.DefaultSettingValueAttribute("00:00:20")]
+        public global::System.TimeSpan SchedulingPatience {
+            get {
+                return ((global::System.TimeSpan)(this["SchedulingPatience"]));
+            }
+        }
     }
 }

branches/HiveTaskScheduler/HeuristicLab.Services.Hive/3.3/Properties/Settings.settings

@@ -21 +21 @@
       <Value Profile="(Default)">3.00:00:00</Value>
     </Setting>
+    <Setting Name="SchedulingPatience" Type="System.TimeSpan" Scope="Application">
+      <Value Profile="(Default)">00:00:20</Value>
+    </Setting>
   </Settings>
 </SettingsFile>

branches/HiveTaskScheduler/HeuristicLab.Services.Hive/3.3/Scheduler/RoundRobinTaskScheduler.cs

@@ -20 +20 @@
 #endregion
 
+using System;
 using System.Collections.Generic;
 using System.Linq;
@@ -31 +32 @@
 
     public IEnumerable<Task> Schedule(IEnumerable<Task> tasks, int count = 1) {
-      var userPriorities = dao.GetUserPriorities(x => true).ToArray();
+      if (!tasks.Any()) return Enumerable.Empty<Task>();
+
+      var userPriorities = dao.GetUserPriorities(x => true).OrderBy(x => x.DateEnqueued).ToArray();
 
       var jobs = new List<Job>();
       foreach (var userPriority in userPriorities) {
         var closureUserPriority = userPriority;
-        jobs.AddRange(dao.GetJobs(x => x.OwnerUserId == closureUserPriority.UserId));
+        jobs.AddRange(dao.GetJobs(x => x.OwnerUserId == closureUserPriority.Id));
       }
 
@@ -43 +46 @@
         job => job.Id,
         (task, job) => new { Task = task, Job = job })
-        .ToDictionary(k => k, v => false);
+        .OrderByDescending(x => x.Task.Priority)
+        .ToList();
 
       var scheduledTasks = new List<Task>();
       int priorityIndex = 0;
+
       if (count == 0 || count > taskJobRelations.Count) count = taskJobRelations.Count;
+
       for (int i = 0; i < count; i++) {
-        var defaultEntry = taskJobRelations.First(x => !x.Value); // search first task which is not included yet
-        var priorityEntries = taskJobRelations.Where(x => !x.Value && x.Key.Job.OwnerUserId == userPriorities[priorityIndex].UserId).ToArray(); // search for tasks with desired user priority
-        while (!priorityEntries.Any() && priorityIndex < priorityEntries.Length)
-          priorityEntries = taskJobRelations.Where(x => !x.Value && x.Key.Job.OwnerUserId == userPriorities[++priorityIndex].UserId).ToArray();
+        var defaultEntry = taskJobRelations.First(); // search first task which is not included yet
+        var priorityEntries = taskJobRelations.Where(x => x.Job.OwnerUserId == userPriorities[priorityIndex].Id).ToArray(); // search for tasks with desired user priority
+        while (!priorityEntries.Any() && ++priorityIndex < userPriorities.Length)
+          priorityEntries = taskJobRelations.Where(x => x.Job.OwnerUserId == userPriorities[priorityIndex].Id).ToArray();
         if (priorityEntries.Any()) { // tasks with desired user priority found
-          var priorityEntry = priorityEntries.OrderByDescending(x => x.Key.Task.Priority).ThenBy(x => x.Key.Task.DateCreated).First();
-          if (defaultEntry.Key.Task.Priority <= priorityEntry.Key.Task.Priority) {
-            taskJobRelations[priorityEntry.Key] = true;
-            scheduledTasks.Add(priorityEntry.Key.Task);
+          var priorityEntry = priorityEntries.OrderByDescending(x => x.Task.Priority).ThenBy(x => x.Job.DateCreated).First();
+          if (defaultEntry.Task.Priority <= priorityEntry.Task.Priority) {
+            taskJobRelations.Remove(priorityEntry);
+            scheduledTasks.Add(priorityEntry.Task);
             priorityIndex++;
-          } else { // there are other tasks with higher priority
-            taskJobRelations[defaultEntry.Key] = true;
-            scheduledTasks.Add(defaultEntry.Key.Task);
+          } else { // there are other tasks with higher priorities
+            taskJobRelations.Remove(defaultEntry);
+            scheduledTasks.Add(defaultEntry.Task);
           }
         } else {
-          taskJobRelations[defaultEntry.Key] = true;
-          scheduledTasks.Add(defaultEntry.Key.Task);
+          taskJobRelations.Remove(defaultEntry);
+          scheduledTasks.Add(defaultEntry.Task);
         }
       }
 
-      // dequeue and enqueue priorities [0, priorityIndex), i.e. {4,3,6,2,5,1} and priorityIndex = 3 -> {2,5,1,4,3,6}
-      // i don't know how to solve this yet ... (race conditions, locking?)
+      // requeue user priorities
+      if (priorityIndex < userPriorities.Length)
+        for (int i = 0; i < priorityIndex; i++) {
+          userPriorities[i].DateEnqueued = DateTime.Now;
+          dao.EnqueueUserPriority(userPriorities[i]);
+        }
 
       return scheduledTasks;

branches/HiveTaskScheduler/HeuristicLab.Services.Hive/3.3/app.config

@@ -26 +26 @@
                 <value>3.00:00:00</value>
             </setting>
+            <setting name="SchedulingPatience" serializeAs="String">
+                <value>00:00:20</value>
+            </setting>
         </HeuristicLab.Services.Hive.Properties.Settings>
     </applicationSettings>