Changeset 8193

Timestamp:

07/03/12 13:54:50 (12 years ago)

Author:

gkronber

Message:

#1887 fixed a problem in plugin loading which occurs if one of the assemblies shipped with HeuristicLab is already installed in the GAC of the machine.

Location:

trunk/sources/HeuristicLab.PluginInfrastructure/3.3/Manager

Files:

• PluginDescription.cs (modified) (1 diff)
• PluginValidator.cs (modified) (4 diffs)

trunk/sources/HeuristicLab.PluginInfrastructure/3.3/Manager/PluginDescription.cs

@@ -139 +139 @@
     }
 
+    /// <summary>
+    /// Gets and sets the list of assembly names for this plugin. Assembly names are only available after the plugin has been loaded.
+    /// </summary>
+    private List<string> assemblyNames;
+    public IEnumerable<string> AssemblyNames {
+      get { return assemblyNames; }
+      set { this.assemblyNames = new List<string>(value); }
+    }
+
     internal PluginDescription() {
       pluginState = PluginState.Undefined;

trunk/sources/HeuristicLab.PluginInfrastructure/3.3/Manager/PluginValidator.cs

@@ -506 +506 @@
       foreach (var desc in PluginDescriptionIterator.IterateDependenciesBottomUp(pluginDescriptions
                                                                                 .Where(x => x.PluginState != PluginState.Disabled))) {
+        // store the assembly names so that we can later retrieve the assemblies loaded in the appdomain by name
+        var assemblyNames = new List<string>();
         foreach (string assemblyLocation in desc.AssemblyLocations) {
           if (desc.PluginState != PluginState.Disabled) {
@@ -515 +517 @@
               // this can still lead to an exception
               // even when the assemby was successfully loaded into the reflection only context before 
-              var asm = Assembly.Load(assemblyName);
+              // when loading the assembly using it's assemblyName it can be loaded from a different location than before (e.g. the GAC)
+              Assembly.Load(assemblyName);
+              assemblyNames.Add(assemblyName);
             }
             catch (BadImageFormatException) {
@@ -535 +539 @@
           }
         }
+        desc.AssemblyNames = assemblyNames;
       }
     }
@@ -547 +552 @@
         if (desc.PluginState == PluginState.Enabled) {
           // cannot use ApplicationManager to retrieve types because it is not yet instantiated
-          foreach (string assemblyLocation in desc.AssemblyLocations) {
+          foreach (string assemblyName in desc.AssemblyNames) {
             var asm = (from assembly in assemblies
-                       where string.Equals(Path.GetFullPath(assembly.Location), Path.GetFullPath(assemblyLocation), StringComparison.CurrentCultureIgnoreCase)
+                       where assembly.FullName == assemblyName
                        select assembly)
                       .SingleOrDefault();
-            if (asm == null) throw new InvalidPluginException("Could not assembly " + assemblyLocation + " for plugin " + desc.Name);
+            if (asm == null) throw new InvalidPluginException("Could not assembly " + assemblyName + " for plugin " + desc.Name);
             foreach (Type pluginType in asm.GetTypes()) {
               if (typeof(IPlugin).IsAssignableFrom(pluginType) && !pluginType.IsAbstract && !pluginType.IsInterface && !pluginType.HasElementType) {