Changeset 8108

Timestamp:

06/25/12 17:21:36 (12 years ago)

Author:

abeham

Message:

#1869:

• Removed ToEnumerable extension method (I agree with gkronber and it's just one occurrence)
• Reset rowNumber to 0 when rebuilding the combined data table
• Some minor changes (moved ctor below variable/property declaration, replaced some obvious variable types with var)

Location:

trunk/sources

Files:

• HeuristicLab.Common/3.3/ObjectExtensions.cs (modified) (1 diff)
• HeuristicLab.Optimization.Views/3.3/RunCollectionViews/RunCollectionDataTableView.cs (modified) (9 diffs)

trunk/sources/HeuristicLab.Common/3.3/ObjectExtensions.cs

@@ -31 +31 @@
 namespace HeuristicLab.Common {
   public static class ObjectExtensions {
-    public static IEnumerable<T> ToEnumerable<T>(this T item) {
-      return new[] { item };
-    }
-
     public static IEnumerable<object> GetObjectGraphObjects(this object obj, HashSet<string> excludedMembers = null, bool excludeStaticMembers = false) {
       if (obj == null) return Enumerable.Empty<object>();

trunk/sources/HeuristicLab.Optimization.Views/3.3/RunCollectionViews/RunCollectionDataTableView.cs

@@ -26 +26 @@
 using HeuristicLab.Analysis;
 using HeuristicLab.Collections;
-using HeuristicLab.Common;
 using HeuristicLab.Core.Views;
 using HeuristicLab.MainForm;
@@ -36 +35 @@
     private const string AllDataRows = "All DataRows";
 
-    public RunCollectionDataTableView() {
-      InitializeComponent();
-      runMapping = new Dictionary<IRun, IEnumerable<DataRow>>();
-      combinedDataTable = new DataTable("Combined DataTable", "A data table containing all data rows from all run.");
-      viewHost.Content = combinedDataTable;
-      suppressUpdates = false;
-    }
-
     public new RunCollection Content {
       get { return (RunCollection)base.Content; }
@@ -49 +40 @@
     }
 
+    private int rowNumber = 0;
     private bool suppressUpdates;
     private readonly Dictionary<IRun, IEnumerable<DataRow>> runMapping;
@@ -54 +46 @@
     public DataTable CombinedDataTable {
       get { return combinedDataTable; }
+    }
+
+    public RunCollectionDataTableView() {
+      InitializeComponent();
+      runMapping = new Dictionary<IRun, IEnumerable<DataRow>>();
+      combinedDataTable = new DataTable("Combined DataTable", "A data table containing data rows from multiple runs.");
+      viewHost.Content = combinedDataTable;
+      suppressUpdates = false;
     }
 
@@ -111 +111 @@
     private void run_Changed(object sender, EventArgs e) {
       if (suppressUpdates) return;
-      IRun run = (IRun)sender;
-      UpdateRuns(run.ToEnumerable());
-
+      var run = (IRun)sender;
+      UpdateRuns(new IRun[] { run });
     }
     #endregion
@@ -131 +130 @@
     private void RebuildCombinedDataTable() {
       RemoveRuns(Content);
+      rowNumber = 0;
       AddRuns(Content);
     }
@@ -142 +142 @@
       combinedDataTable.Rows.AddRange(dataRows);
     }
+
     private void RemoveRuns(IEnumerable<IRun> runs) {
       var dataRows = runs.Where(r => runMapping.ContainsKey(r)).SelectMany(r => runMapping[r]).ToList();
@@ -165 +166 @@
     }
 
-    private int rowNumber = 0;
     private IEnumerable<DataRow> ExtractDataRowsFromRun(IRun run) {
-      string resultName = (string)dataTableComboBox.SelectedItem;
-      string rowName = (string)dataRowComboBox.SelectedItem;
+      var resultName = (string)dataTableComboBox.SelectedItem;
+      var rowName = (string)dataRowComboBox.SelectedItem;
       if (!run.Results.ContainsKey(resultName)) yield break;
 
-      DataTable dataTable = (DataTable)run.Results[resultName];
+      var dataTable = (DataTable)run.Results[resultName];
       foreach (var dataRow in dataTable.Rows) {
         if (dataRow.Name != rowName && rowName != AllDataRows) continue;
@@ -197 +197 @@
     private void UpdateDataRowComboBox() {
       dataRowComboBox.Items.Clear();
-      string resultName = (string)dataTableComboBox.SelectedItem;
+      var resultName = (string)dataTableComboBox.SelectedItem;
       var dataTables = from run in Content
                        where run.Results.ContainsKey(resultName)