Changeset 8031

Timestamp:

06/18/12 11:00:27 (13 years ago)

Author:

abeham

Message:

#1782:

• Changed tooltip generation in ProblemInstanceConsumerViewGeneric (typeof(T).Name doesn't work, because T doesn't change miraculously when the selected provider changes). The current solution might not be optimal, maybe include another property "FileFormat" in IProblemInstanceProvider that can then be TSPLIB, QAPLIB, CSV, etc.
• Set instances combobox to not display a selected instance initially and disabled button in this case. If that still doesn't reduce the confusion, then I think we have to add problem loading on selected index change and do away with the button.

Location:

trunk/sources/HeuristicLab.Problems.Instances.Views/3.3

Files:

• ProblemInstanceConsumerViewGeneric.cs (modified) (3 diffs)
• ProblemInstanceProviderViewGeneric.Designer.cs (modified) (1 diff)
• ProblemInstanceProviderViewGeneric.cs (modified) (3 diffs)

trunk/sources/HeuristicLab.Problems.Instances.Views/3.3/ProblemInstanceConsumerViewGeneric.cs

@@ -69 +69 @@
       importButton.Text = String.Empty;
       importButton.Image = VSImageLibrary.Open;
-      toolTip.SetToolTip(importButton, "Open a " + GetProblemType() + " problem from file.");
       exportButton.Text = String.Empty;
       exportButton.Image = VSImageLibrary.SaveAs;
-      toolTip.SetToolTip(exportButton, "Export currently loaded " + GetProblemType() + " problem to a file.");
       libraryInfoButton.Text = String.Empty;
       libraryInfoButton.Image = VSImageLibrary.Help;
@@ -160 +158 @@
 
     protected string GetProblemType() {
-      string dataTypeName = typeof(T).Name.Split(new char[] { '.' }, StringSplitOptions.RemoveEmptyEntries).Last();
-      if (dataTypeName.EndsWith("Data"))
-        return dataTypeName.Substring(0, dataTypeName.Length - "Data".Length);
-      else return dataTypeName;
+      return SelectedProvider.Name;
     }
 
@@ -169 +164 @@
     protected void SetTooltip() {
       toolTip.SetToolTip(problemInstanceProviderComboBox, GetProviderToolTip());
+      toolTip.SetToolTip(importButton, "Open a " + GetProblemType() + " problem from file.");
+      toolTip.SetToolTip(exportButton, "Export currently loaded " + GetProblemType() + " problem to a file.");
       if (SelectedProvider.WebLink != null)
         toolTip.SetToolTip(libraryInfoButton, "Browse to " + SelectedProvider.WebLink.ToString());

trunk/sources/HeuristicLab.Problems.Instances.Views/3.3/ProblemInstanceProviderViewGeneric.Designer.cs

@@ -85 +85 @@
       this.instancesComboBox.TabIndex = 7;
       this.instancesComboBox.DataSourceChanged += new System.EventHandler(this.instancesComboBox_DataSourceChanged);
+      this.instancesComboBox.SelectedIndexChanged += new System.EventHandler(this.instancesComboBox_SelectedIndexChanged);
       // 
       // openFileDialog

trunk/sources/HeuristicLab.Problems.Instances.Views/3.3/ProblemInstanceProviderViewGeneric.cs

@@ -65 +65 @@
         ShowInstanceLoad(dataDescriptors.Count() > 0);
         instancesComboBox.DataSource = dataDescriptors;
+        instancesComboBox.SelectedIndex = -1;
       }
     }
@@ -83 +84 @@
       base.SetEnabledStateOfControls();
       instancesComboBox.Enabled = !ReadOnly && !Locked && Content != null && GenericConsumer != null;
-      loadButton.Enabled = !ReadOnly && !Locked && Content != null && GenericConsumer != null;
+      loadButton.Enabled = !ReadOnly && !Locked && Content != null && GenericConsumer != null && instancesComboBox.SelectedIndex >= 0;
     }
 
@@ -102 +103 @@
         comboBox.Items.Clear();
     }
+
+    private void instancesComboBox_SelectedIndexChanged(object sender, System.EventArgs e) {
+      SetEnabledStateOfControls();
+    }
   }
 }