Changeset 732

Timestamp:

11/11/08 12:20:45 (15 years ago)

Author:

gkronber

Message:

fixed #337 (TryXXX methods in ConstrainedItemList do not return violated constraints correctly)

File:

• trunk/sources/HeuristicLab.Data/ConstrainedItemList.cs (modified) (4 diffs)

trunk/sources/HeuristicLab.Data/ConstrainedItemList.cs

@@ -114 +114 @@
     public bool TryInsert(int index, IItem item, out ICollection<IConstraint> violatedConstraints) {
       list.Insert(index, item);
+      violatedConstraints = new List<IConstraint>();
       if (!suspendConstraintCheck && IsValid(out violatedConstraints)) {
         OnItemAdded(item, index);
         return true;
       } else {
-        violatedConstraints = new List<IConstraint>();
         list.RemoveAt(index);
         return false;
@@ -127 +127 @@
       IItem item = list[index];
       list.RemoveAt(index);
+      violatedConstraints = new List<IConstraint>();
       if (!suspendConstraintCheck && IsValid(out violatedConstraints)) {
         OnItemRemoved(item, index);
         return true;
       } else {
-        violatedConstraints = new List<IConstraint>();
         list.Insert(index, item);
         return false;
@@ -144 +144 @@
       IItem backup = this[index];
       list[index] = item;
-      if (!suspendConstraintCheck && IsValid(out violatedConstraints)) {
-        return true;
-      } else {
-        violatedConstraints = new List<IConstraint>();
+      violatedConstraints = new List<IConstraint>();
+      if (!suspendConstraintCheck && IsValid(out violatedConstraints)) {
+        return true;
+      } else {
         list[index] = backup;
         return false;
@@ -155 +155 @@
     public bool TryAdd(IItem item, out ICollection<IConstraint> violatedConstraints) {
       list.Add(item);
+      violatedConstraints = new List<IConstraint>();
       if (!suspendConstraintCheck && IsValid(out violatedConstraints)) {
         OnItemAdded(item, list.Count - 1);
         return true;
       } else {
-        violatedConstraints = new List<IConstraint>();
         list.RemoveAt(list.Count - 1);
         return false;