Changeset 6756

Timestamp:

09/13/11 19:29:56 (13 years ago)

Author:

ascheibe

Message:

#1233 adapted Administrator UI to be more like OKB

Location:

branches/HeuristicLab.Hive-3.4/sources

Files:

• HeuristicLab.Clients.Hive.Administrator/3.3/HeuristicLab.Clients.Hive.Administrator-3.3.csproj (modified) (1 diff)
• HeuristicLab.Clients.Hive.Administrator/3.3/Views/Common/UpdateControl.cs (modified) (2 diffs)
• HeuristicLab.Clients.Hive.Administrator/3.3/Views/HiveAdministratorView.cs (modified) (1 diff)
• HeuristicLab.Clients.Hive.Administrator/3.3/Views/MenuItems/AdministratorMenuItem.cs (modified) (2 diffs)
• HeuristicLab.Clients.Hive.Administrator/3.3/Views/ResourcesView.Designer.cs (modified) (4 diffs)
• HeuristicLab.Clients.Hive.Administrator/3.3/Views/ResourcesView.cs (modified) (12 diffs)
• HeuristicLab.Clients.Hive.Administrator/3.3/Views/ScheduleView.cs (modified) (6 diffs)
• HeuristicLab.Clients.Hive/3.3/HeuristicLab.Clients.Hive-3.3.csproj (modified) (3 diffs)
• HeuristicLab.Clients.Hive/3.3/HiveAdminClient.cs (added)
• HeuristicLab.Clients.Hive/3.3/HiveClient.cs (modified) (2 diffs)
• HeuristicLab.Clients.Hive/3.3/ServiceClients/Downtime.cs (modified) (1 diff)
• HeuristicLab.Clients.Hive/3.3/ServiceClients/HiveItem.cs (modified) (1 diff)
• HeuristicLab.Clients.Hive/3.3/ServiceClients/Job.cs (copied) (copied from branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive/3.3/ServiceClients/HiveExperiment.cs)
• HeuristicLab.Clients.Hive/3.3/ServiceClients/JobPermission.cs (copied) (copied from branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive/3.3/ServiceClients/HiveExperimentPermission.cs)
• HeuristicLab.Clients.Hive/3.3/ServiceClients/Resource.cs (modified) (1 diff)
• HeuristicLab.Services.Hive.DataAccess/3.3/Enums/Permission.cs (modified) (1 diff)
• HeuristicLab.Services.Hive/3.3/HiveDao.cs (modified) (2 diffs)

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive.Administrator/3.3/HeuristicLab.Clients.Hive.Administrator-3.3.csproj

@@ -153 +153 @@
   </ItemGroup>
   <ItemGroup>
-    <Compile Include="HiveAdministratorClient.cs" />
     <Compile Include="Views\HiveAdministratorView.cs">
       <SubType>UserControl</SubType>

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive.Administrator/3.3/Views/Common/UpdateControl.cs

@@ -21 +21 @@
 
 using System;
+using System.Threading.Tasks;
 using System.Windows.Forms;
 using TS = System.Threading.Tasks;
@@ -58 +59 @@
 
         Action action = new Action(PrivUpdateAction);
-        TS.Task task = new TS.Task(action);
-        task.Start();
+        TS.Task.Factory.StartNew(action).ContinueWith((t) => {
+          throw t.Exception;
+        }, TaskContinuationOptions.OnlyOnFaulted);
       }
     }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive.Administrator/3.3/Views/HiveAdministratorView.cs

@@ -21 +21 @@
 
 using System.Windows.Forms;
-using HeuristicLab.Core.Views;
 using HeuristicLab.MainForm;
+using HeuristicLab.MainForm.WindowsForms;
 
 namespace HeuristicLab.Clients.Hive.Administrator.Views {
   [View("Hive Administrator")]
-  [Content(typeof(HiveAdministratorClient), IsDefaultView = true)]
-  public partial class HiveAdministratorView : ItemView {
-    public new HiveAdministratorClient Content {
-      get { return (HiveAdministratorClient)base.Content; }
+  [Content(typeof(HiveAdminClient), IsDefaultView = true)]
+  public partial class HiveAdministratorView : AsynchronousContentView {
+    public new HiveAdminClient Content {
+      get { return (HiveAdminClient)base.Content; }
       set { base.Content = value; }
     }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive.Administrator/3.3/Views/MenuItems/AdministratorMenuItem.cs

@@ -21 +21 @@
 
 using System.Collections.Generic;
-using HeuristicLab.Clients.Hive.Administrator;
+using HeuristicLab.Clients.Hive;
 using HeuristicLab.MainForm;
 
@@ -33 +33 @@
     }
     public override void Execute() {
-      MainFormManager.MainForm.ShowContent(new HiveAdministratorClient());
+      MainFormManager.MainForm.ShowContent(HiveAdminClient.Instance);
     }
     public override int Position {

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive.Administrator/3.3/Views/ResourcesView.Designer.cs

@@ -61 +61 @@
       this.updateScheduleControl = new HeuristicLab.Clients.Hive.Administrator.Views.Common.UpdateControl();
       this.scheduleView = new HeuristicLab.Clients.Hive.Administrator.Views.ScheduleView();
+      this.progressBar = new System.Windows.Forms.ProgressBar();
       ((System.ComponentModel.ISupportInitialize)(this.splitSlaves)).BeginInit();
       this.splitSlaves.Panel1.SuspendLayout();
@@ -86 +87 @@
       // splitSlaves.Panel1
       // 
+      this.splitSlaves.Panel1.Controls.Add(this.progressBar);
       this.splitSlaves.Panel1.Controls.Add(this.updateSlaveGroup);
       this.splitSlaves.Panel1.Controls.Add(this.btnSave);
@@ -224 +226 @@
       this.scheduleView.Name = "scheduleView";
       this.scheduleView.ReadOnly = false;
-      this.scheduleView.ResourceId = new System.Guid("00000000-0000-0000-0000-000000000000");
       this.scheduleView.Size = new System.Drawing.Size(568, 473);
       this.scheduleView.TabIndex = 0;
+      // 
+      // progressBar
+      // 
+      this.progressBar.Location = new System.Drawing.Point(176, 3);
+      this.progressBar.Name = "progressBar";
+      this.progressBar.Size = new System.Drawing.Size(70, 23);
+      this.progressBar.Style = System.Windows.Forms.ProgressBarStyle.Continuous;
+      this.progressBar.TabIndex = 7;
       // 
       // ResourcesView
@@ -261 +270 @@
     private System.Windows.Forms.Button btnSave;
     private UpdateControl updateSlaveGroup;
+    private System.Windows.Forms.ProgressBar progressBar;
   }
 }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive.Administrator/3.3/Views/ResourcesView.cs

@@ -23 +23 @@
 using System.Drawing;
 using System.Linq;
+using System.Threading;
+using System.Threading.Tasks;
 using System.Windows.Forms;
 using HeuristicLab.Clients.Hive.Views;
@@ -28 +30 @@
 using HeuristicLab.Core.Views;
 using HeuristicLab.MainForm;
+using TS = System.Threading.Tasks;
 
 namespace HeuristicLab.Clients.Hive.Administrator.Views {
-  [View("ResourcesView")]
+  [View("Resources View")]
   [Content(typeof(IItemList<Resource>), IsDefaultView = true)]
-  public partial class ResourcesView : ItemView {
+  public partial class ResourcesView : ItemView, IDisposable {
     public new IItemList<Resource> Content {
       get { return (IItemList<Resource>)base.Content; }
@@ -41 +44 @@
     private const int slaveImageIndex = 0;
     private const int slaveGroupImageIndex = 1;
+    private TS.Task progressTask;
+    private bool stopProgressTask;
 
 
@@ -47 +52 @@
       treeSlaveGroup.ImageList.Images.Add(HiveImageLibrary.Slave);
       treeSlaveGroup.ImageList.Images.Add(HiveImageLibrary.SlaveGroup);
+      //TODO: remove updatecontrol and replace with a regular button
       updateScheduleControl.UpdateAction = new Action(UpdateSchedule);
-      updateSlaveGroup.UpdateAction = new Action(UpdateSlaveGroups);
-
-      updateSlaveGroup.Update();
+      updateSlaveGroup.UpdateAction = new Action(UpdateResources);
+
+      HiveAdminClient.Instance.Refreshing += new EventHandler(Instance_Refreshing);
+      HiveAdminClient.Instance.Refreshed += new EventHandler(Instance_Refreshed);
+
+      UpdateResourcesAsync();
+    }
+
+    public new void Dispose() {
+      HiveAdminClient.Instance.Refreshing -= new EventHandler(Instance_Refreshing);
+      HiveAdminClient.Instance.Refreshed -= new EventHandler(Instance_Refreshed);
+    }
+
+    private void UpdateProgress() {
+      while (!stopProgressTask) {
+        int diff = (progressBar.Maximum - progressBar.Minimum) / 10;
+        progressBar.Value = (progressBar.Value + diff) % progressBar.Maximum;
+        //ok, this is not very clever...
+        Thread.Sleep(500);
+      }
+      progressBar.Value = progressBar.Minimum;
+    }
+
+    void Instance_Refreshing(object sender, EventArgs e) {
+      stopProgressTask = false;
+      progressTask = new TS.Task(UpdateProgress);
+      progressTask.Start();
+    }
+
+    void Instance_Refreshed(object sender, EventArgs e) {
+      stopProgressTask = true;
     }
 
@@ -142 +176 @@
 
       slaveView.Content = (Resource)e.Node.Tag;
-      scheduleView.ResourceId = ((Resource)e.Node.Tag).Id;
+      HiveAdminClient.Instance.DowntimeForResourceId = ((Resource)e.Node.Tag).Id;
 
       if (e.Node.Tag is SlaveGroup) {
@@ -149 +183 @@
 
       if (tabSlaveGroup.SelectedIndex == 1) {
-        UpdateSchedule();
+        UpdateScheduleAsync();
       }
     }
@@ -175 +209 @@
         Resource res = (Resource)treeSlaveGroup.SelectedNode.Tag;
 
-        DialogResult diagRes = MessageBox.Show("Do you really want to delete " + res.Name + "?", "HeuristicLab Hive Administration", MessageBoxButtons.YesNo, MessageBoxIcon.Question);
+        DialogResult diagRes = MessageBox.Show("Do you really want to delete " + res.Name + "?", "HeuristicLab Hive Administrator", MessageBoxButtons.YesNo, MessageBoxIcon.Question);
         if (diagRes == DialogResult.Yes) {
           if (res is Slave) {
             Content.Remove(res);
-            ServiceLocator.Instance.CallHiveService(service => service.DeleteSlave(res.Id));
+            HiveAdminClient.Delete(res);
           } else if (res is SlaveGroup) {
             //only delete empty groups
             if (Content.Where(s => s.ParentResourceId == res.Id).Count() < 1) {
               Content.Remove(res);
-              ServiceLocator.Instance.CallHiveService(service => service.DeleteSlaveGroup(res.Id));
+              HiveAdminClient.Delete(res);
             } else {
-              MessageBox.Show("Only empty groups can be deleted.", "HeuristicLab Hive Administration", MessageBoxButtons.OK, MessageBoxIcon.Error);
+              MessageBox.Show("Only empty groups can be deleted.", "HeuristicLab Hive Administrator", MessageBoxButtons.OK, MessageBoxIcon.Error);
             }
           }
@@ -197 +231 @@
         if (res is SlaveGroup && res.Id == Guid.Empty) {
           SlaveGroup slaveGroup = (SlaveGroup)res;
-          ServiceLocator.Instance.CallHiveService(service => slaveGroup.Id = service.AddSlaveGroup(slaveGroup));
+          slaveGroup.Store();
         }
         if (res.Id != Guid.Empty && res.Modified) {
-          if (res is SlaveGroup) {
-            ServiceLocator.Instance.CallHiveService(service => service.UpdateSlaveGroup((SlaveGroup)res));
-          } else if (res is Slave) {
-            ServiceLocator.Instance.CallHiveService(service => service.UpdateSlave((Slave)res));
-          }
+          res.Store();
         }
       }
@@ -218 +248 @@
           if (destNode.Text == ungroupedGroupName || (destNode.Parent != null && destNode.Parent.Text == ungroupedGroupName)) {
             MessageBox.Show(String.Format("You can't drag items to the {0} group.{1}This group only contains slaves which haven't yet been assigned to a real group.",
-              ungroupedGroupName, Environment.NewLine), "HeuristicLab Hive Administration", MessageBoxButtons.OK, MessageBoxIcon.Information);
+              ungroupedGroupName, Environment.NewLine), "HeuristicLab Hive Administrator", MessageBoxButtons.OK, MessageBoxIcon.Information);
             return;
           }
@@ -239 +269 @@
             //save parent group to get an id
             if (sgrp.Id == Guid.Empty) {
-              ServiceLocator.Instance.CallHiveService(service => sgrp.Id = service.AddSlaveGroup(sgrp));
+              sgrp.Store();
             }
 
@@ -300 +330 @@
       }
       slaveView.Content = null;
-      scheduleView.ResourceId = Guid.Empty;
-    }
-
-    private void UpdateSlaveGroups() {
+      if (scheduleView.Content != null) {
+        scheduleView.Content.Clear();
+      }
+      HiveAdminClient.Instance.ResetDowntime();
+    }
+
+    private void UpdateResources() {
       if (this.InvokeRequired) {
         this.Invoke(new Action(ResetView));
@@ -310 +343 @@
       }
 
-      IItemList<Resource> resources = new ItemList<Resource>();
-
-      ServiceLocator.Instance.CallHiveService(service => {
-        service.GetSlaveGroups().ForEach(g => resources.Add(g));
-        service.GetSlaves().ForEach(s => resources.Add(s));
-      });
-      Content = resources;
+      HiveAdminClient.Instance.Refresh();
+      Content = HiveAdminClient.Instance.Resources;
+    }
+
+    private void UpdateResourcesAsync() {
+      TS.Task.Factory.StartNew(UpdateResources).ContinueWith((t) => {
+        DisplayError(t.Exception);
+      }, TaskContinuationOptions.OnlyOnFaulted);
     }
 
     private void UpdateSchedule() {
-      Guid resourceId = scheduleView.ResourceId;
-      if (resourceId != null) {
-        ServiceLocator.Instance.CallHiveService(service => {
-          var appointments = service.GetDowntimesForResource(resourceId);
-          ItemList<Downtime> ias = new ItemList<Downtime>();
-          appointments.ForEach(a => ias.Add(a));
-          scheduleView.Invoke(new Action(() => scheduleView.Content = ias));
-        });
-      }
+      HiveAdminClient.Instance.RefreshCalendar();
+      scheduleView.Invoke(new Action(() => scheduleView.Content = HiveAdminClient.Instance.Downtimes));
+    }
+
+    private void UpdateScheduleAsync() {
+      TS.Task.Factory.StartNew(UpdateSchedule).ContinueWith((t) => {
+        DisplayError(t.Exception);
+      }, TaskContinuationOptions.OnlyOnFaulted);
+    }
+
+    private void DisplayError(Exception ex) {
+      MessageBox.Show("An error occured updating the schedule: " + Environment.NewLine + ex.ToString(), "HeuristicLab Hive Administrator");
     }
 
     private void tabSlaveGroup_SelectedIndexChanged(object sender, EventArgs e) {
       if (tabSlaveGroup.SelectedIndex == 1) {
-        UpdateSchedule();
+        UpdateScheduleAsync();
       }
     }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive.Administrator/3.3/Views/ScheduleView.cs

@@ -32 +32 @@
 
 namespace HeuristicLab.Clients.Hive.Administrator.Views {
-  [View("ScheduleView")]
+  [View("Schedule View")]
   [Content(typeof(IItemList<Downtime>), IsDefaultView = true)]
   public partial class ScheduleView : ItemView {
@@ -47 +47 @@
     public delegate void OnDialogClosedDelegate(RecurrentEvent e);
 
-    private Guid resourceId;
-    public Guid ResourceId {
-      get {
-        return resourceId;
-      }
-      set {
-        resourceId = value;
-      }
-    }
-
     public ScheduleView() {
       InitializeComponent();
@@ -93 +83 @@
     private void UpdateCalendarFromContent() {
       offlineTimes.Clear();
-      foreach (Downtime app in Content) {
-        offlineTimes.Add(new HiveAppointment {
-          AllDayEvent = app.AllDayEvent,
-          EndDate = app.EndDate,
-          StartDate = app.StartDate,
-          Recurring = app.Recurring,
-          RecurringId = app.RecurringId,
-          BorderColor = Color.Red,
-          Locked = true,
-          Subject = "Offline",
-          Changed = false,
-          Id = app.Id
-        });
+      if (Content != null) {
+        foreach (Downtime app in Content) {
+          offlineTimes.Add(ToHiveAppointment(app));
+        }
       }
       dvOnline.Invalidate();
@@ -233 +214 @@
     #region Register Content Events
     protected override void DeregisterContentEvents() {
-      // TODO: Deregister your event handlers on the Content here
       base.DeregisterContentEvents();
     }
     protected override void RegisterContentEvents() {
       base.RegisterContentEvents();
-      // TODO: Register your event handlers on the Content here
     }
     #endregion
@@ -244 +223 @@
     protected override void OnContentChanged() {
       base.OnContentChanged();
-      if (Content == null) {
-        // TODO: Put code here when content is null
-      } else {
-        UpdateCalendarFromContent();
-      }
+      UpdateCalendarFromContent();
     }
 
     protected override void SetEnabledStateOfControls() {
       base.SetEnabledStateOfControls();
-      // TODO: Put code here to enable or disable controls based on whether the Content is/not null or the view is ReadOnly
     }
 
@@ -333 +307 @@
       List<Downtime> appointments = new List<Downtime>();
       foreach (HiveAppointment app in offlineTimes) {
-        if (app.Deleted) {
-          ServiceLocator.Instance.CallHiveService(service => {
-            if (app.Id != Guid.Empty) {
-              service.DeleteDowntime(app.Id);
-            }
-          });
-        } else if (app.Changed) {
-          Downtime apdto = new Downtime {
-            AllDayEvent = app.AllDayEvent,
-            EndDate = app.EndDate,
-            Recurring = app.Recurring,
-            RecurringId = app.RecurringId,
-            StartDate = app.StartDate,
-            ResourceId = resourceId
-          };
-          appointments.Add(apdto);
-        }
-      }
-
-      if (appointments.Count > 0) {
-        //TODO: find a sane way to do this
-        ServiceLocator.Instance.CallHiveService(service => {
-          foreach (Downtime app in appointments) {
-            service.AddDowntime(app);
-          }
-        });
-      }
+        if (app.Deleted && app.Id != Guid.Empty) {
+          HiveAdminClient.Delete(ToDowntime(app));
+        } else if (app.Changed || app.Id == null || app.Id == Guid.Empty) {
+          Downtime dt = ToDowntime(app);
+          appointments.Add(dt);
+        }
+      }
+      foreach (Downtime dt in appointments) {
+        dt.Store();
+      }
+    }
+
+    private HiveAppointment ToHiveAppointment(Downtime downtime) {
+      HiveAppointment app = new HiveAppointment {
+        AllDayEvent = downtime.AllDayEvent,
+        EndDate = downtime.EndDate,
+        StartDate = downtime.StartDate,
+        Recurring = downtime.Recurring,
+        RecurringId = downtime.RecurringId,
+        Deleted = false,
+        BorderColor = Color.Red,
+        Locked = true,
+        Subject = "Offline",
+        Changed = downtime.Modified,
+        Id = downtime.Id
+      };
+      return app;
+    }
+
+    private Downtime ToDowntime(HiveAppointment app) {
+      Downtime downtime = new Downtime {
+        AllDayEvent = app.AllDayEvent,
+        EndDate = app.EndDate,
+        StartDate = app.StartDate,
+        Recurring = app.Recurring,
+        RecurringId = app.RecurringId,
+        ResourceId = HiveAdminClient.Instance.DowntimeForResourceId,
+        Id = app.Id
+      };
+      return downtime;
     }
   }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive/3.3/HeuristicLab.Clients.Hive-3.3.csproj

@@ -112 +112 @@
   </ItemGroup>
   <ItemGroup>
+    <Compile Include="HiveAdminClient.cs" />
     <Compile Include="HiveClient.cs" />
     <Compile Include="Settings.Designer.cs">
@@ -120 +121 @@
     <Compile Include="Tasks\ItemTask.cs" />
     <Compile Include="RefreshableJob.cs" />
-    <Compile Include="ServiceClients\HiveExperimentPermission.cs" />
+    <Compile Include="ServiceClients\JobPermission.cs" />
     <Compile Include="StateLogList.cs" />
     <Compile Include="StateLogListList.cs" />
@@ -167 +168 @@
     <Compile Include="ServiceClients\Resource.cs" />
     <Compile Include="ServiceClients\StateLog.cs" />
-    <Compile Include="ServiceClients\HiveExperiment.cs" />
+    <Compile Include="ServiceClients\Job.cs" />
     <Compile Include="ServiceClients\SlaveGroup.cs" />
     <Compile Include="ServiceClients\Slave.cs" />

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive/3.3/HiveClient.cs

@@ -75 +75 @@
     #endregion
 
-    public HiveClient() { }
+    private HiveClient() { }
 
     #region Refresh
@@ -101 +101 @@
         }
         // remove those which were not in the list of loaded hiveexperiments
-        foreach (var experiment in oldJobs) {
-          if (experiment.Id == Guid.Empty) {
+        foreach (var job in oldJobs) {
+          if (job.Id == Guid.Empty) {
             // experiment not uploaded... keep
-            jobs.Add(experiment);
+            jobs.Add(job);
           } else {
-            experiment.RefreshAutomatically = false; // stop results polling
+            job.RefreshAutomatically = false; // stop results polling
           }
         }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive/3.3/ServiceClients/Downtime.cs

@@ -27 +27 @@
     public Downtime() { }
 
+    public override void Store() {
+      HiveAdminClient.Store(this, new System.Threading.CancellationToken());
+      Modified = false;
+    }
+
     protected Downtime(Downtime original, Cloner cloner)
       : base(original, cloner) {

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive/3.3/ServiceClients/HiveItem.cs

@@ -85 +85 @@
     #endregion
 
-    public void Store() {
+    public virtual void Store() {
       HiveClient.Store(this, new System.Threading.CancellationToken());
       Modified = false;

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive/3.3/ServiceClients/Resource.cs

@@ -28 +28 @@
     public Resource() { }
 
+    public override void Store() {
+      HiveAdminClient.Store(this, new System.Threading.CancellationToken());
+      Modified = false;
+    }
+
     protected Resource(Resource original, Cloner cloner)
       : base(original, cloner) {

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.DataAccess/3.3/Enums/Permission.cs

@@ -31 +31 @@
 
     /// <summary>
-    /// User can only download and view experiments
+    /// User can only download and view jobs
     /// </summary>
     Read,
 
     /// <summary>
-    /// User can pause, stop, restart, delete experiment. can also grant other 
+    /// User can pause, stop, restart, delete jobs. can also grant other 
     /// </summary>
     Full

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive/3.3/HiveDao.cs

@@ -233 +233 @@
     public DT.Job GetJob(Guid id) {
       using (var db = CreateContext()) {
-        return AddStatsToExperiment(db, DT.Convert.ToDto(db.Jobs.SingleOrDefault(x => x.JobId == id)));
-      }
-    }
-
-    private DT.Job AddStatsToExperiment(HiveDataContext db, DT.Job exp) {
+        return AddStatsToJob(db, DT.Convert.ToDto(db.Jobs.SingleOrDefault(x => x.JobId == id)));
+      }
+    }
+
+    private DT.Job AddStatsToJob(HiveDataContext db, DT.Job exp) {
       if (exp == null)
         return null;
@@ -250 +250 @@
     public IEnumerable<DT.Job> GetJobs(Expression<Func<Job, bool>> predicate) {
       using (var db = CreateContext()) {
-        return db.Jobs.Where(predicate).Select(x => AddStatsToExperiment(db, DT.Convert.ToDto(x))).ToArray();
+        return db.Jobs.Where(predicate).Select(x => AddStatsToJob(db, DT.Convert.ToDto(x))).ToArray();
       }
     }