Changeset 6463 for branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.Tests

Timestamp:

06/21/11 16:51:03 (13 years ago)

Author:

cneumuel

Message:

#1233

• created user interface for experiment sharing
• created UserManager which provides access to the users
• inserted a lot of security and authorization checks serverside
• minor fixes in experiment manager

Location:

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.Tests

Files:

• DaoTests.cs (modified) (1 diff)
• HeuristicLab.Services.Hive-3.4.Tests.csproj (modified) (2 diffs)
• Mocks/MockAuthorizationManager.cs (modified) (1 diff)
• Mocks/MockServiceLocator.cs (modified) (4 diffs)
• Mocks/MockUserManager.cs (added)
• ServiceTests.cs (modified) (4 diffs)

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.Tests/DaoTests.cs

@@ -235 +235 @@
       perm.GrantedByUserId = he.OwnerUserId;
       perm.GrantedUserId = Guid.NewGuid();
-      perm.Permission = Permission.Write;
+      perm.Permission = Permission.Full;
       dao.AddHiveExperimentPermission(perm);
 

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.Tests/HeuristicLab.Services.Hive-3.4.Tests.csproj

@@ -72 +72 @@
   <ItemGroup>
     <Compile Include="Mocks\MockAuthenticationManager.cs" />
+    <Compile Include="Mocks\MockUserManager.cs" />
     <Compile Include="ServiceTests.cs" />
     <Compile Include="Mocks\MockAuthorizationManager.cs" />
@@ -108 +109 @@
     <Reference Include="Microsoft.VisualStudio.QualityTools.UnitTestFramework, Version=10.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a, processorArchitecture=MSIL" />
     <Reference Include="System" />
+    <Reference Include="System.Configuration" />
     <Reference Include="System.Data" />
     <Reference Include="System.Data.DataSetExtensions" />

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.Tests/Mocks/MockAuthorizationManager.cs

@@ -24 +24 @@
 namespace HeuristicLab.Services.Hive.Tests.Mocks {
   public class MockAuthorizationManager : IAuthorizationManager {
-    public static Guid MockUserId1 = new Guid("6C7911A1-46EA-4E51-97DF-5582653AAFCE");
-    public static Guid MockUserId2 = new Guid("897660EB-C90F-4054-988C-D39D530A0A02");
-    public static Guid MockUserId3 = new Guid("9F7B4EA8-A38D-4BC2-802F-E148AC7A6A87");
-
-    private Guid userId = MockUserId1;
-
-    public Guid UserId {
-      get { return userId; }
+    public void Authorize(Guid userId) {
+      // ok.
     }
 
-    public void AuthorizeJobs(params Guid[] jobId) {
-      // o.k.
+    public void AuthorizeForJob(Guid jobId, Common.DataTransfer.Permission requiredPermission) {
+      // ok.
     }
 
-    public void Authorize(Guid userId) {
-      // o.k.
-    }
-    
-    internal void SetUserId(Guid id) {
-      this.userId = id;
+    public void AuthorizeForExperiment(Guid experimentId, Common.DataTransfer.Permission requiredPermission) {
+      // ok.
     }
   }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.Tests/Mocks/MockServiceLocator.cs

@@ -20 +20 @@
 #endregion
 
+using System;
 using HeuristicLab.Services.Hive.DataAccess;
 using HeuristicLab.Services.Hive.Tests.Mocks;
-using System;
 
 namespace HeuristicLab.Services.Hive.Tests {
@@ -36 +36 @@
     }
 
-    private MockAuthorizationManager mockAuthorizationManager = new MockAuthorizationManager();
+    //private MockAuthorizationManager mockAuthorizationManager = new MockAuthorizationManager();
     public IAuthorizationManager AuthorizationManager {
-      get { return mockAuthorizationManager; }
+      get { return defaultServiceLocator.AuthorizationManager; }
     }
 
@@ -51 +51 @@
       get { return defaultServiceLocator.TransactionManager; }
     }
-
+    private MockUserManager mockUserManager = new MockUserManager();
+    public IUserManager UserManager {
+      get { return mockUserManager; }
+    }
     public HeartbeatManager HeartbeatManager {
       get { return defaultServiceLocator.HeartbeatManager; }
@@ -57 +60 @@
 
     #region Special mocking methods
-    public void SetCurrentUser(Guid id) {
-      mockAuthorizationManager.SetUserId(id);
+    public void SetCurrentUserId(Guid userId) {
+      mockUserManager.SetUserId(userId);
     }
-
     #endregion
   }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.Tests/ServiceTests.cs

@@ -303 +303 @@
     public void TestHiveExperimentPermissions() {
       var service = GetLocalService();
-      mockServiceLocator.SetCurrentUser(MockAuthorizationManager.MockUserId1);
+      mockServiceLocator.SetCurrentUserId(MockUserManager.MockUserId1);
 
       // create hive experiment
@@ -311 +311 @@
       var e1loaded = service.GetHiveExperiment(e1.Id);
       Assert.AreEqual(Permission.Full, e1loaded.Permission);
-
+      var allExp = service.GetHiveExperiments();
+      Assert.AreEqual(1, allExp.Count(x => x.Id == e1.Id));
+      
       // change to user2
-      mockServiceLocator.SetCurrentUser(MockAuthorizationManager.MockUserId2);
-      e1loaded = service.GetHiveExperiment(e1.Id);
-      Assert.AreEqual(null, e1loaded); // no access
+      mockServiceLocator.SetCurrentUserId(MockUserManager.MockUserId2);
+      try {
+        e1loaded = service.GetHiveExperiment(e1.Id);
+        Assert.Fail("Access should not be possible");
+      } catch { /* ok, cool */ }
+      allExp = service.GetHiveExperiments();
+      Assert.AreEqual(0, allExp.Count(x => x.Id == e1.Id));
 
       // user2 should not be able to grant permissions
       try {
-        service.GrantPermission(e1.Id, MockAuthorizationManager.MockUserId2, Permission.ReadOnly);
+        service.GrantPermission(e1.Id, MockUserManager.MockUserId2, Permission.Read);
         Assert.Fail("Should not be possible to grant permission due to missing permission for User2");
       }
@@ -325 +331 @@
 
       // switch back to user1 (owner) and grant user2 permissions
-      mockServiceLocator.SetCurrentUser(MockAuthorizationManager.MockUserId1);
-      service.GrantPermission(e1.Id, MockAuthorizationManager.MockUserId2, Permission.ReadOnly);
+      mockServiceLocator.SetCurrentUserId(MockUserManager.MockUserId1);
+      service.GrantPermission(e1.Id, MockUserManager.MockUserId2, Permission.Read);
 
       // back to user2
-      mockServiceLocator.SetCurrentUser(MockAuthorizationManager.MockUserId2);
+      mockServiceLocator.SetCurrentUserId(MockUserManager.MockUserId2);
       e1loaded = service.GetHiveExperiment(e1.Id);
-      Assert.AreEqual(Permission.ReadOnly, e1loaded.Permission);
+      Assert.AreEqual(Permission.Read, e1loaded.Permission);
+      allExp = service.GetHiveExperiments();
+      Assert.AreEqual(1, allExp.Count(x => x.Id == e1.Id));
 
       // user2 should still not be able to grant permissions
       try {
-        service.GrantPermission(e1.Id, MockAuthorizationManager.MockUserId2, Permission.ReadOnly);
+        service.GrantPermission(e1.Id, MockUserManager.MockUserId2, Permission.Read);
         Assert.Fail("Should not be possible to grant permission due to missing permission for User2");
       }
@@ -341 +349 @@
 
       // back to user1
-      mockServiceLocator.SetCurrentUser(MockAuthorizationManager.MockUserId1);
-      service.GrantPermission(e1.Id, MockAuthorizationManager.MockUserId2, Permission.Full);
+      mockServiceLocator.SetCurrentUserId(MockUserManager.MockUserId1);
+      service.GrantPermission(e1.Id, MockUserManager.MockUserId2, Permission.Full);
 
       // back to user2
-      mockServiceLocator.SetCurrentUser(MockAuthorizationManager.MockUserId2);
+      mockServiceLocator.SetCurrentUserId(MockUserManager.MockUserId2);
       e1loaded = service.GetHiveExperiment(e1.Id);
       Assert.AreEqual(Permission.Full, e1loaded.Permission);
-
+      allExp = service.GetHiveExperiments();
+      Assert.AreEqual(1, allExp.Count(x => x.Id == e1.Id));
+      
       // grant rights to user3, now this should be possible due to full permissions
-      service.GrantPermission(e1.Id, MockAuthorizationManager.MockUserId3, Permission.ReadOnly);
+      service.GrantPermission(e1.Id, MockUserManager.MockUserId3, Permission.Read);
 
       // back to user1 and revoke rights for user2
-      mockServiceLocator.SetCurrentUser(MockAuthorizationManager.MockUserId1);
-      service.RevokePermission(e1.Id, MockAuthorizationManager.MockUserId2);
+      mockServiceLocator.SetCurrentUserId(MockUserManager.MockUserId1);
+      service.RevokePermission(e1.Id, MockUserManager.MockUserId2);
 
       // back to user2
-      mockServiceLocator.SetCurrentUser(MockAuthorizationManager.MockUserId2);
-      e1loaded = service.GetHiveExperiment(e1.Id);
-      Assert.AreEqual(null, e1loaded); // no access
-
+      mockServiceLocator.SetCurrentUserId(MockUserManager.MockUserId2);
+      try {
+        e1loaded = service.GetHiveExperiment(e1.Id);
+        Assert.Fail("Access should not be possible");
+      }
+      catch { /* ok, cool */ }
+      allExp = service.GetHiveExperiments();
+      Assert.AreEqual(0, allExp.Count(x => x.Id == e1.Id));
+
+      // back to user1
+      mockServiceLocator.SetCurrentUserId(MockUserManager.MockUserId1);
       service.DeleteHiveExperiment(e1.Id);
     }