Changeset 6444 for branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.DataAccess

Timestamp:

06/19/11 23:21:21 (14 years ago)

Author:

cneumuel

Message:

#1233

• stability improvements for HiveExperiment and HiveEngine
• parallelized upload of jobs
• enabled cancellation of job upload
• reduced the amount of double-assignment of jobs by an additional check in HeartbeatManager
• tried to tackle the amount of deadlocks by automatically rerunning transactions
• some fixes

File:

• branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.DataAccess/3.4/TransactionManager.cs (modified) (2 diffs)

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.DataAccess/3.4/TransactionManager.cs

@@ -27 +27 @@
   public static class TransactionManager {
     public static void UseTransaction(Action call, bool serializable = false, bool longRunning = false) {
-      TransactionScope transaction = CreateTransaction(serializable, longRunning);
-      try {
-        call();
-        transaction.Complete();
-      }
-      finally {
-        transaction.Dispose();
+      int n = 10;
+      while (n > 0) {
+        TransactionScope transaction = CreateTransaction(serializable, longRunning);
+        try {
+          call();
+          transaction.Complete();
+          n = 0;
+        }
+        catch (System.Data.SqlClient.SqlException e) {
+          n--; // probably deadlock situation, let it roll back and repeat the transaction n times
+          LogFactory.GetLogger(typeof(TransactionManager).Namespace).Log(string.Format("Exception occured, repeating transaction {0} more times. Details: {1}", n, e.ToString()));          
+          if (n <= 0) throw;
+        }
+        finally {
+          transaction.Dispose();
+        }
       }
     }
 
     public static T UseTransaction<T>(Func<T> call, bool serializable = false, bool longRunning = false) {
-      TransactionScope transaction = CreateTransaction(serializable, longRunning);
-      try {
-        T result = call();
-        transaction.Complete();
-        return result;
+      int n = 10;
+      while (n > 0) {
+        TransactionScope transaction = CreateTransaction(serializable, longRunning);
+        try {
+          T result = call();
+          transaction.Complete();
+          n = 0;
+          return result;
+        }
+        catch (System.Data.SqlClient.SqlException e) {
+          n--; // probably deadlock situation, let it roll back and repeat the transaction n times
+          LogFactory.GetLogger(typeof(TransactionManager).Namespace).Log(string.Format("Exception occured, repeating transaction {0} more times. Details: {1}", n, e.ToString()));
+          if (n <= 0) throw;
+        }
+        finally {
+          transaction.Dispose();
+        }
       }
-      finally {
-        transaction.Dispose();
-      }
+      throw new Exception("This code should not be reached");
     }
-    
+
     private static TransactionScope CreateTransaction(bool serializable, bool longRunning) {
       var options = new TransactionOptions();
@@ -58 +77 @@
       if (longRunning)
         options.Timeout = ApplicationConstants.LongRunningDatabaseCommandTimeout;
-      
+
       return new TransactionScope(TransactionScopeOption.Required, options);
     }