Changeset 5405

Timestamp:

02/01/11 18:12:46 (14 years ago)

Author:

cneumuel

Message:

#1233

• moved heartbeat timestamps of slaves and jobs into database to make server stateless
• made slave use the right authentication ("hiveslave" instead of HL username/password)
• moved heartbeat related methods into HeartbeatManager
• changed signature of Service.Hello method, so all hardware related information is transferred in that method withing the Slave-object

Location:

branches/HeuristicLab.Hive-3.4/sources

Files:

• HeuristicLab.Clients.Hive.Slave.Tests/Mocks/MockHiveService.cs (modified) (1 diff)
• HeuristicLab.Clients.Hive.Slave.Tests/Mocks/MockServiceLocator.cs (modified) (1 diff)
• HeuristicLab.Clients.Hive.Slave/3.4/WcfService.cs (modified) (13 diffs)
• HeuristicLab.Clients.Hive.Tests (modified) (1 prop)
• HeuristicLab.Clients.Hive.Tests/Mocks/MockServiceLocator.cs (modified) (1 diff)
• HeuristicLab.Clients.Hive/3.4/IServiceLocator.cs (modified) (1 diff)
• HeuristicLab.Clients.Hive/3.4/ServiceLocator.cs (modified) (1 diff)
• HeuristicLab.Services.Hive.Common/3.4/DataTransfer/Heartbeat.cs (modified) (1 diff)
• HeuristicLab.Services.Hive.Common/3.4/DataTransfer/Job.cs (modified) (2 diffs)
• HeuristicLab.Services.Hive.Common/3.4/DataTransfer/Slave.cs (modified) (2 diffs)
• HeuristicLab.Services.Hive.Common/3.4/ServiceContracts/IHiveService.cs (modified) (1 diff)
• HeuristicLab.Services.Hive.DataAccess/3.4/Convert.cs (modified) (4 diffs)
• HeuristicLab.Services.Hive.DataAccess/3.4/HiveDataContext.dbml (modified) (2 diffs)
• HeuristicLab.Services.Hive.DataAccess/3.4/HiveDataContext.dbml.layout (modified) (7 diffs)
• HeuristicLab.Services.Hive.DataAccess/3.4/HiveDataContext.designer.cs (modified) (7 diffs)
• HeuristicLab.Services.Hive.Tests/DaoTests.cs (modified) (1 diff)
• HeuristicLab.Services.Hive.Tests/Mocks/MockLifecycleManager.cs (modified) (1 diff)
• HeuristicLab.Services.Hive.Tests/Mocks/MockServiceLocator.cs (modified) (2 diffs)
• HeuristicLab.Services.Hive.Web/Hive-3.4/App_Code/HiveServerModule.cs (modified) (2 diffs)
• HeuristicLab.Services.Hive.Web/Hive-3.4/Web.config (modified) (1 diff)
• HeuristicLab.Services.Hive/3.4/HeartbeatManager.cs (added)
• HeuristicLab.Services.Hive/3.4/HeuristicLab.Services.Hive-3.4.csproj (modified) (1 diff)
• HeuristicLab.Services.Hive/3.4/HiveService.cs (modified) (3 diffs)
• HeuristicLab.Services.Hive/3.4/Interfaces/ILifecycleManager.cs (modified) (1 diff)
• HeuristicLab.Services.Hive/3.4/Interfaces/IServiceLocator.cs (modified) (1 diff)
• HeuristicLab.Services.Hive/3.4/LifecycleManager.cs (modified) (4 diffs)
• HeuristicLab.Services.Hive/3.4/ServiceLocator.cs (modified) (1 diff)

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive.Slave.Tests/Mocks/MockHiveService.cs

@@ -215 +215 @@
 
     #region Login Methods
-    public void Hello(Guid slaveId, string name, int cores, int memory) {
+    public void Hello(HeuristicLab.Services.Hive.Common.DataTransfer.Slave slaveInfo) {
       // do nothing
     }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive.Slave.Tests/Mocks/MockServiceLocator.cs

@@ -34 +34 @@
       return new Disposable<IHiveService>(service);
     }
+
+    public Disposable<IHiveService> GetService(string username, string password) {
+      return GetService();
+    }
   }
 }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive.Slave/3.4/WcfService.cs

@@ -75 +75 @@
     /// </summary>
     public void Connect(HeuristicLab.Services.Hive.Common.DataTransfer.Slave slaveInfo) {
-      using (Disposable<IHiveService> service = ServiceLocator.Instance.GetService()) {
+      using (Disposable<IHiveService> service = GetSlaveService()) {
         try {
           ConnState = NetworkEnum.WcfConnState.Connected;
           ConnectedSince = DateTime.Now;
-          service.Obj.Hello(slaveInfo.Id/*Settings.Default.Guid*/, slaveInfo.Name, slaveInfo.Cores.Value, slaveInfo.Memory.Value);
+          service.Obj.Hello(slaveInfo);
           OnConnected();
         }
@@ -92 +92 @@
     /// </summary>
     public void Disconnect() {
-      using (Disposable<IHiveService> service = ServiceLocator.Instance.GetService()) {
+      using (Disposable<IHiveService> service = GetSlaveService()) {
         try {
           service.Obj.GoodBye(ConfigManager.Instance.GetClientInfo().Id);
@@ -116 +116 @@
     /// </summary>
     public Job GetJob(Guid jobId) {
-      using (Disposable<IHiveService> service = ServiceLocator.Instance.GetService()) {
+      using (Disposable<IHiveService> service = GetSlaveService()) {
         try {
           Job job = service.Obj.GetJob(jobId);
@@ -129 +129 @@
 
     public JobData GetJobData(Guid jobId) {
-      using (Disposable<IHiveService> service = ServiceLocator.Instance.GetService()) {
+      using (Disposable<IHiveService> service = GetSlaveService()) {
         try {
           JobData jobData = service.Obj.GetJobData(jobId);
@@ -147 +147 @@
     /// <param name="jobData"></param>    
     public void UpdateJob(Job job, JobData jobData) {
-      using (Disposable<IHiveService> service = ServiceLocator.Instance.GetService()) {
+      using (Disposable<IHiveService> service = GetSlaveService()) {
         try {
           service.Obj.UpdateJob(job, jobData);
@@ -158 +158 @@
 
     public List<MessageContainer> SendHeartbeat(Heartbeat heartbeat) {
-      using (Disposable<IHiveService> service = ServiceLocator.Instance.GetService()) {
+      using (Disposable<IHiveService> service = GetSlaveService()) {
         try {
           List<MessageContainer> msg = service.Obj.Heartbeat(heartbeat);
@@ -171 +171 @@
 
     public IEnumerable<PluginData> GetPluginDatas(List<Guid> pluginIds) {
-      using (Disposable<IHiveService> service = ServiceLocator.Instance.GetService()) {
+      using (Disposable<IHiveService> service = GetSlaveService()) {
         try {
           IEnumerable<PluginData> msg = service.Obj.GetPluginDatas(pluginIds);
@@ -184 +184 @@
 
     public IEnumerable<Plugin> GetPlugins() {
-      using (Disposable<IHiveService> service = ServiceLocator.Instance.GetService()) {
+      using (Disposable<IHiveService> service = GetSlaveService()) {
         try {
           IEnumerable<Plugin> msg = service.Obj.GetPlugins();
@@ -197 +197 @@
 
     public Guid AddChildJob(Guid parentJobId, Job job, JobData jobData) {
-      using (Disposable<IHiveService> service = ServiceLocator.Instance.GetService()) {
+      using (Disposable<IHiveService> service = GetSlaveService()) {
         try {
           Guid msg = service.Obj.AddChildJob(parentJobId, job, jobData);
@@ -210 +210 @@
 
     public IEnumerable<JobData> GetChildJobs(Guid? parentJobId) {
-      using (Disposable<IHiveService> service = ServiceLocator.Instance.GetService()) {
+      using (Disposable<IHiveService> service = GetSlaveService()) {
         try {
           IEnumerable<LightweightJob> msg = service.Obj.GetLightweightChildJobs(parentJobId, false, false);
@@ -228 +228 @@
 
     public void DeleteChildJobs(Guid jobId) {
-      using (Disposable<IHiveService> service = ServiceLocator.Instance.GetService()) {
+      using (Disposable<IHiveService> service = GetSlaveService()) {
         try {
           service.Obj.DeleteChildJobs(jobId);
@@ -239 +239 @@
 
     public PluginData GetConfigurationFile() {
-      using (Disposable<IHiveService> service = ServiceLocator.Instance.GetService()) {
+      using (Disposable<IHiveService> service = GetSlaveService()) {
         try {
           PluginData msg = service.Obj.GetConfigurationFile();
@@ -249 +249 @@
         }
       }
+    }
+
+    private static Disposable<IHiveService> GetSlaveService() {
+      return ServiceLocator.Instance.GetService("hiveslave", "hiveslave");
     }
   }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive.Tests/Mocks/MockServiceLocator.cs

@@ -12 +12 @@
       return new Disposable<IHiveService>(new HiveService());
     }
+
+    public Disposable<IHiveService> GetService(string username, string password) {
+      return GetService();
+    }
   }
 }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive/3.4/IServiceLocator.cs

@@ -26 +26 @@
   public interface IServiceLocator {
     Disposable<IHiveService> GetService();
+    Disposable<IHiveService> GetService(string username, string password);
   }
 }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Clients.Hive/3.4/ServiceLocator.cs

@@ -41 +41 @@
       return ClientFactory.CreateClient<IHiveService>("wsHttpBinding_IHiveService");
     }
+
+    public Disposable<IHiveService> GetService(string username, string password) {
+      return ClientFactory.CreateClient<IHiveService>("wsHttpBinding_IHiveService", null, username, password);
+    }
   }
 }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.Common/3.4/DataTransfer/Heartbeat.cs

@@ -37 +37 @@
     public Dictionary<Guid, TimeSpan> JobProgress { get; set; } // TODO: define Type
     [DataMember]
-    public bool IsAllowedToCalculate { get; set; } // this is true if slave is allowed to work according to calendar
+    public bool AssignJob { get; set; } // if false, the server will not assign a new job
 
     public override string ToString() {

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.Common/3.4/DataTransfer/Job.cs

@@ -40 +40 @@
     [DataMember]
     public List<Guid> PluginsNeededIds { get; set; }
+    [DataMember]
+    public DateTime? LastHeartbeat { get; set; }
 
     public Job() {
@@ -50 +52 @@
       this.MemoryNeeded = original.MemoryNeeded;
       this.PluginsNeededIds = new List<Guid>(original.PluginsNeededIds);
+      this.LastHeartbeat = original.LastHeartbeat;
     }
     public override IDeepCloneable Clone(Cloner cloner) {

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.Common/3.4/DataTransfer/Slave.cs

@@ -50 +50 @@
     [DataMember]
     public bool IsAllowedToCalculate { get; set; }
+    [DataMember]
+    public DateTime? LastHeartbeat { get; set; }
 
     public Slave() {
@@ -62 +64 @@
       this.SlaveState = original.SlaveState;
       this.IsAllowedToCalculate = original.IsAllowedToCalculate;
+      this.OperatingSystem = original.OperatingSystem;
+      this.CpuArchitecture = original.CpuArchitecture;
+      this.LastHeartbeat = original.LastHeartbeat;
     }
     public override IDeepCloneable Clone(Cloner cloner) {

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.Common/3.4/ServiceContracts/IHiveService.cs

@@ -76 +76 @@
     #region Login Methods
     [OperationContract]
-    void Hello(Guid slaveId, string name, int cores, int memory);
+    void Hello(Slave slave);
 
     [OperationContract]

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.DataAccess/3.4/Convert.cs

@@ -44 +44 @@
         JobState = source.JobState,
         UserId = source.UserId,
-        PluginsNeededIds = source.RequiredPlugins.Select(x => x.PluginId).ToList()
+        PluginsNeededIds = source.RequiredPlugins.Select(x => x.PluginId).ToList(),
+        LastHeartbeat = source.LastHeartbeat        
       };
     }
@@ -67 +68 @@
         target.JobState = source.JobState;
         target.UserId = source.UserId;
-        // RequiredPlugins need to be added by Dao
+        target.LastHeartbeat = source.LastHeartbeat;
+        // RequiredPlugins are added by Dao
       }
     }
@@ -143 +145 @@
     public static DT.Slave ToDto(Slave source) {
       if (source == null) return null;
-      return new DT.Slave { Id = source.ResourceId, ParentResourceId = source.ParentResourceId, Cores = source.Cores, CpuSpeed = source.CpuSpeed, FreeCores = source.FreeCores, FreeMemory = source.FreeMemory, IsAllowedToCalculate = source.IsAllowedToCalculate, Memory = source.Memory, Name = source.Name, SlaveState = source.SlaveState, CpuArchitecture = source.CpuArchitecture, OperatingSystem = source.OperatingSystem };
+      return new DT.Slave { 
+        Id = source.ResourceId, 
+        ParentResourceId = source.ParentResourceId, 
+        Cores = source.Cores,
+        CpuSpeed = source.CpuSpeed, 
+        FreeCores = source.FreeCores, 
+        FreeMemory = source.FreeMemory, 
+        IsAllowedToCalculate = source.IsAllowedToCalculate, 
+        Memory = source.Memory, 
+        Name = source.Name, 
+        SlaveState = source.SlaveState, 
+        CpuArchitecture = source.CpuArchitecture, 
+        OperatingSystem = source.OperatingSystem,
+        LastHeartbeat = source.LastHeartbeat
+      };
     }
     public static Slave ToEntity(DT.Slave source) {
@@ -152 +168 @@
     public static void ToEntity(DT.Slave source, Slave target) {
       if ((source != null) && (target != null)) {
-        target.ResourceId = source.Id; target.ParentResourceId = source.ParentResourceId; target.Cores = source.Cores; target.CpuSpeed = source.CpuSpeed; target.FreeCores = source.FreeCores; target.FreeMemory = source.FreeMemory; target.IsAllowedToCalculate = source.IsAllowedToCalculate; target.Memory = source.Memory; target.Name = source.Name; target.SlaveState = source.SlaveState; target.CpuArchitecture = source.CpuArchitecture; target.OperatingSystem = source.OperatingSystem;
+        target.ResourceId = source.Id;
+        target.ParentResourceId = source.ParentResourceId;
+        target.Cores = source.Cores; 
+        target.CpuSpeed = source.CpuSpeed;
+        target.FreeCores = source.FreeCores;
+        target.FreeMemory = source.FreeMemory; 
+        target.IsAllowedToCalculate = source.IsAllowedToCalculate;
+        target.Memory = source.Memory;
+        target.Name = source.Name; 
+        target.SlaveState = source.SlaveState; 
+        target.CpuArchitecture = source.CpuArchitecture; 
+        target.OperatingSystem = source.OperatingSystem;
+        target.LastHeartbeat = source.LastHeartbeat;
       }
     }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.DataAccess/3.4/HiveDataContext.dbml

@@ -50 +50 @@
         <Column Name="IsAllowedToCalculate" Type="System.Boolean" DbType="Bit" CanBeNull="false" />
         <Column Name="CpuArchitecture" Type="global::HeuristicLab.Services.Hive.Common.DataTransfer.CpuArchitecture" DbType="VarChar(3)" CanBeNull="false" />
-        <Column Name="OperatingSystem" Type="System.String" DbType="VarChar(MAX)" CanBeNull="false" />
+        <Column Name="OperatingSystem" Type="System.String" DbType="VarChar(MAX)" CanBeNull="false" UpdateCheck="Never" />
+        <Column Name="LastHeartbeat" Type="System.DateTime" DbType="DateTime" CanBeNull="true" />
         <Association Name="Slave_Job" Member="Jobs" ThisKey="ResourceId" OtherKey="SlaveId" Type="Job" />
       </Type>
@@ -72 +73 @@
       <Column Name="CoresNeeded" Type="System.Int32" DbType="Int NOT NULL" CanBeNull="false" />
       <Column Name="MemoryNeeded" Type="System.Int32" DbType="Int NOT NULL" CanBeNull="false" />
+      <Column Name="LastHeartbeat" Type="System.DateTime" DbType="DateTime" CanBeNull="true" />
       <Association Name="Job_AssignedResource" Member="AssignedResources" ThisKey="JobId" OtherKey="JobId" Type="AssignedResource" />
       <Association Name="Job_RequiredPlugin" Member="RequiredPlugins" ThisKey="JobId" OtherKey="JobId" Type="RequiredPlugin" />

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.DataAccess/3.4/HiveDataContext.dbml.layout

@@ -27 +27 @@
       </nestedChildShapes>
     </classShape>
-    <classShape Id="695bfc39-59f3-4e60-8644-f847964bf62c" absoluteBounds="6.5, 1, 2, 3.5016097005208326">
+    <classShape Id="695bfc39-59f3-4e60-8644-f847964bf62c" absoluteBounds="6.5, 1, 2, 3.6939111328124996">
       <DataClassMoniker Name="/HiveDataContext/Job" />
       <nestedChildShapes>
-        <elementListCompartment Id="a6a30e11-03d1-4869-82e6-b733f4ef9974" absoluteBounds="6.5150000000000006, 1.46, 1.9700000000000002, 2.941609700520833" name="DataPropertiesCompartment" titleTextColor="Black" itemTextColor="Black" />
+        <elementListCompartment Id="a6a30e11-03d1-4869-82e6-b733f4ef9974" absoluteBounds="6.5150000000000006, 1.46, 1.9700000000000002, 3.1339111328125" name="DataPropertiesCompartment" titleTextColor="Black" itemTextColor="Black" />
       </nestedChildShapes>
     </classShape>
@@ -45 +45 @@
       </nestedChildShapes>
     </classShape>
-    <classShape Id="26f4edfa-91dd-4941-a058-359f89e567a8" absoluteBounds="8.875, 1, 2, 2.7324039713541666">
+    <classShape Id="26f4edfa-91dd-4941-a058-359f89e567a8" absoluteBounds="8.875, 0.75, 2, 2.9247054036458331">
       <DataClassMoniker Name="/HiveDataContext/Slave" />
       <nestedChildShapes>
-        <elementListCompartment Id="1e61f36b-08dc-4df7-8594-c9dcd95c0791" absoluteBounds="8.89, 1.46, 1.9700000000000002, 2.1724039713541665" name="DataPropertiesCompartment" titleTextColor="Black" itemTextColor="Black" />
+        <elementListCompartment Id="1e61f36b-08dc-4df7-8594-c9dcd95c0791" absoluteBounds="8.89, 1.21, 1.9700000000000002, 2.364705403645833" name="DataPropertiesCompartment" titleTextColor="Black" itemTextColor="Black" />
       </nestedChildShapes>
     </classShape>
@@ -76 +76 @@
       </nodes>
     </associationConnector>
-    <associationConnector edgePoints="[(8.5 : 4.12580485026042); (8.875 : 4.12580485026042)]" fixedFrom="NotFixed" fixedTo="NotFixed">
+    <associationConnector edgePoints="[(8.5 : 4.22195556640625); (8.875 : 4.22195556640625)]" fixedFrom="NotFixed" fixedTo="NotFixed">
       <AssociationMoniker Name="/HiveDataContext/Job/Job_AssignedResource" />
       <nodes>
@@ -83 +83 @@
       </nodes>
     </associationConnector>
-    <associationConnector edgePoints="[(7.1210551923077 : 4.50160970052083); (7.1210551923077 : 5.5)]" fixedFrom="NotFixed" fixedTo="NotFixed">
+    <associationConnector edgePoints="[(7.0898076923077 : 4.6939111328125); (7.0898076923077 : 5.5)]" fixedFrom="NotFixed" fixedTo="NotFixed">
       <AssociationMoniker Name="/HiveDataContext/Job/Job_RequiredPlugin" />
       <nodes>
@@ -90 +90 @@
       </nodes>
     </associationConnector>
-    <associationConnector edgePoints="[(8.3334359271285 : 4.50160970052083); (8.3334359271285 : 4.58410970052083); (8.4156121961154 : 4.58410970052083); (8.4156121961154 : 4.75160970052083); (7.8046153846154 : 4.75160970052083); (7.8046153846154 : 4.50160970052083)]" manuallyRouted="true" fixedFrom="NotFixed" fixedTo="NotFixed">
+    <associationConnector edgePoints="[(7.20923076923077 : 1); (7.20923076923077 : 0.75); (7.80461538461539 : 0.75); (7.80461538461539 : 1)]" manuallyRouted="true" fixedFrom="NotFixed" fixedTo="NotFixed">
       <AssociationMoniker Name="/HiveDataContext/Job/Job_Job" />
       <nodes>
@@ -97 +97 @@
       </nodes>
     </associationConnector>
-    <associationConnector edgePoints="[(8.875 : 2.36620198567708); (8.5 : 2.36620198567708)]" fixedFrom="NotFixed" fixedTo="NotFixed">
+    <associationConnector edgePoints="[(8.875 : 2.33735270182292); (8.5 : 2.33735270182292)]" fixedFrom="NotFixed" fixedTo="NotFixed">
       <AssociationMoniker Name="/HiveDataContext/Slave/Slave_Job" />
       <nodes>
@@ -111 +111 @@
       </nodes>
     </associationConnector>
-    <associationConnector edgePoints="[(6.5 : 3.56330485026042); (6.125 : 3.56330485026042)]" fixedFrom="NotFixed" fixedTo="NotFixed">
+    <associationConnector edgePoints="[(6.5 : 3.65945556640625); (6.125 : 3.65945556640625)]" fixedFrom="NotFixed" fixedTo="NotFixed">
       <AssociationMoniker Name="/HiveDataContext/Job/Job_HiveExperiment" />
       <nodes>

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.DataAccess/3.4/HiveDataContext.designer.cs

@@ -1064 +1064 @@
     private string _OperatingSystem;
     
+    private System.Nullable<System.DateTime> _LastHeartbeat;
+    
     private EntitySet<Job> _Jobs;
     
@@ -1090 +1092 @@
     partial void OnOperatingSystemChanging(string value);
     partial void OnOperatingSystemChanged();
+    partial void OnLastHeartbeatChanging(System.Nullable<System.DateTime> value);
+    partial void OnLastHeartbeatChanged();
     #endregion
     
@@ -1278 +1282 @@
     }
     
-    [global::System.Data.Linq.Mapping.ColumnAttribute(Storage="_OperatingSystem", DbType="VarChar(MAX)", CanBeNull=false)]
+    [global::System.Data.Linq.Mapping.ColumnAttribute(Storage="_OperatingSystem", DbType="VarChar(MAX)", CanBeNull=false, UpdateCheck=UpdateCheck.Never)]
     public string OperatingSystem
     {
@@ -1294 +1298 @@
           this.SendPropertyChanged("OperatingSystem");
           this.OnOperatingSystemChanged();
+        }
+      }
+    }
+    
+    [global::System.Data.Linq.Mapping.ColumnAttribute(Storage="_LastHeartbeat", DbType="DateTime")]
+    public System.Nullable<System.DateTime> LastHeartbeat
+    {
+      get
+      {
+        return this._LastHeartbeat;
+      }
+      set
+      {
+        if ((this._LastHeartbeat != value))
+        {
+          this.OnLastHeartbeatChanging(value);
+          this.SendPropertyChanging();
+          this._LastHeartbeat = value;
+          this.SendPropertyChanged("LastHeartbeat");
+          this.OnLastHeartbeatChanged();
         }
       }
@@ -1372 +1396 @@
     
     private int _MemoryNeeded;
+    
+    private System.Nullable<System.DateTime> _LastHeartbeat;
     
     private EntitySet<AssignedResource> _AssignedResources;
@@ -1417 +1443 @@
     partial void OnMemoryNeededChanging(int value);
     partial void OnMemoryNeededChanged();
+    partial void OnLastHeartbeatChanging(System.Nullable<System.DateTime> value);
+    partial void OnLastHeartbeatChanged();
     #endregion
     
@@ -1710 +1738 @@
           this.SendPropertyChanged("MemoryNeeded");
           this.OnMemoryNeededChanged();
+        }
+      }
+    }
+    
+    [global::System.Data.Linq.Mapping.ColumnAttribute(Storage="_LastHeartbeat", DbType="DateTime")]
+    public System.Nullable<System.DateTime> LastHeartbeat
+    {
+      get
+      {
+        return this._LastHeartbeat;
+      }
+      set
+      {
+        if ((this._LastHeartbeat != value))
+        {
+          this.OnLastHeartbeatChanging(value);
+          this.SendPropertyChanging();
+          this._LastHeartbeat = value;
+          this.SendPropertyChanged("LastHeartbeat");
+          this.OnLastHeartbeatChanged();
         }
       }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.Tests/DaoTests.cs

@@ -76 +76 @@
 
       DT.Slave slave = new DT.Slave() {
+        Id = Guid.NewGuid(),
         Name = "Test",
-        OperatingSystem = Environment.OSVersion.VersionString,
+        OperatingSystem = null, //"Windows 3.11",
         Cores = 2,
-        Memory = 1024
+        Memory = 1024,
+        FreeMemory = 512
       };
-      slave.Id= dao.AddSlave(slave);
+
+      Assert.AreEqual(slave.Id, dao.AddSlave(slave));
+
+      // update
+      slave.FreeMemory = 255;
+      slave.OperatingSystem = Environment.OSVersion.VersionString;
+      dao.UpdateSlave(slave);
+
+      DT.Slave slaveLoaded = dao.GetSlave(slave.Id);
+      Assert.AreEqual(slave.FreeMemory, slaveLoaded.FreeMemory);
 
       dao.DeleteSlave(slave.Id);

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.Tests/Mocks/MockLifecycleManager.cs

@@ -28 +28 @@
   public class MockLifecycleManager : ILifecycleManager {
 
-    public void Start() {
+    public void Start() { }
 
-    }
-
-    public void Stop() {
-
-    }
-
-    public List<MessageContainer> ProcessHeartbeat(Heartbeat heartbeat) {
-      throw new NotImplementedException();
-    }
+    public void Stop() { }
   }
 }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.Tests/Mocks/MockServiceLocator.cs

@@ -39 +39 @@
     }
 
-    private ILifecycleManager lifecycleManager;
     public ILifecycleManager LifecycleManager {
       get {
@@ -50 +49 @@
     }
 
+    public HeartbeatManager HeartbeatManager {
+      get {
+        return defaultServiceLocator.HeartbeatManager;
+      }
+    }
   }
 }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.Web/Hive-3.4/App_Code/HiveServerModule.cs

@@ -27 +27 @@
 using HeuristicLab.Services.Hive.Common.ServiceContracts;
 using HeuristicLab.Services.Hive;
+using HeuristicLab.Tracing;
 
 namespace HeuristicLab.Hive.Server.Core.IISModules {
@@ -37 +38 @@
       if (lifecycleManager == null)
         lifecycleManager = new LifecycleManager();
+      lifecycleManager.Start();
     }
 
     public void Dispose() {
-      
+      lifecycleManager.Stop();
     } 
   }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive.Web/Hive-3.4/Web.config

@@ -70 +70 @@
 
   <system.webServer>
-    <!--<modules runAllManagedModulesForAllRequests="true">
+    <modules runAllManagedModulesForAllRequests="true">
       <add name="HiveServerModule" type="HeuristicLab.Hive.Server.Core.IISModules.HiveServerModule"/>
-    </modules>-->
+    </modules>
     <directoryBrowse enabled="true"/>
   </system.webServer>

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive/3.4/HeuristicLab.Services.Hive-3.4.csproj

@@ -112 +112 @@
     <None Include="HeuristicLabServicesHivePlugin.cs.frame" />
     <None Include="Properties\AssemblyInfo.cs.frame" />
+    <Compile Include="HeartbeatManager.cs" />
     <Compile Include="Interfaces\ILifecycleManager.cs" />
     <Compile Include="Interfaces\IServiceLocator.cs" />

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive/3.4/HiveService.cs

@@ -25 +25 @@
     private ILifecycleManager lifecycleManager {
       get { return ServiceLocator.Instance.LifecycleManager; }
+    }
+    private HeartbeatManager heartbeatManager {
+      get { return ServiceLocator.Instance.HeartbeatManager; }
     }
 
@@ -162 +165 @@
 
     #region Login Methods
-    public void Hello(Guid slaveId, string name, int cores, int memory) {
-      using (trans.OpenTransaction()) {
-        var slave = dao.GetSlave(slaveId);
+    public void Hello(Slave slaveInfo) {
+      using (trans.OpenTransaction()) {
+        var slave = dao.GetSlave(slaveInfo.Id);
 
         if (slave == null) {
-          slave = new Slave { Id = slaveId, Name = name, Cores = cores, Memory = memory };
-          slave.IsAllowedToCalculate = true; //a little bit to optimistic?
-          slave.SlaveState = SlaveState.Idle;
-          dao.AddSlave(slave);
+          dao.AddSlave(slaveInfo);
         } else {
-          //TODO: error handling? 
+          dao.UpdateSlave(slaveInfo);
         }
       }
@@ -191 +191 @@
     public List<MessageContainer> Heartbeat(Heartbeat heartbeat) {
       using (trans.OpenTransaction()) {
-        return lifecycleManager.ProcessHeartbeat(heartbeat);
+        return heartbeatManager.ProcessHeartbeat(heartbeat);
       }
     }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive/3.4/Interfaces/ILifecycleManager.cs

@@ -14 +14 @@
 
     void Stop();
-
-    List<MessageContainer> ProcessHeartbeat(Heartbeat heartbeat);
   }
 }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive/3.4/Interfaces/IServiceLocator.cs

@@ -12 +12 @@
     ILifecycleManager LifecycleManager { get; }
     TransactionManager TransactionManager { get; }
+    HeartbeatManager HeartbeatManager { get; }
   }
 }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive/3.4/LifecycleManager.cs

@@ -25 +25 @@
 
     private static object locker = new object();
-    private Dictionary<Guid, DateTime> heartbeats = new Dictionary<Guid, DateTime>();
 
     // Windows-Forms timer is single threaded, so callbacks will be synchron
-    System.Windows.Forms.Timer timer = new System.Windows.Forms.Timer();
+    System.Windows.Forms.Timer timer;
 
-    /// <summary>
-    /// Contains a list job JobIds which have been sent to a slave, but the slave has not yet sent 
-    /// a jobProgress of the job with a heartbeat, because he has not finished downloading/deserializing it.
-    /// The number value indicates a TimeToLive count that is decremented with each server-heartbeat.
-    /// When the number reaches zero, the jobs is assumed to be lost and is set Offline again.
-    /// </summary>
-    private Dictionary<Guid, int> newlyAssignedJobs = new Dictionary<Guid, int>();
-
-    /// <summary>
-    /// Counts how many jobs are currently beeing transferred.
-    /// </summary>
-    private int jobsCurrentlyTransfering = 0;
-    public int JobsCurrentlyTransferring {
-      get { return jobsCurrentlyTransfering; }
-      set {
-        if (jobsCurrentlyTransfering != value) {
-          jobsCurrentlyTransfering = value;
-          Logger.Info("JobsCurrentlyTransfering: " + jobsCurrentlyTransfering);
-        }
-      }
+    public ExecutionState ExecutionState {
+      get { return timer.Enabled ? ExecutionState.Started : Core.ExecutionState.Stopped; }
     }
 
-    public ExecutionState ExecutionState {
-      get { return timer.Enabled ? ExecutionState.Started : Core.ExecutionState.Stopped;  }
+    public LifecycleManager() {
+      this.timer = new System.Windows.Forms.Timer();
+      this.timer.Tick += new EventHandler(timer_Tick);
     }
-
-    public LifecycleManager() { }
 
     public void Start() {
       if (ExecutionState == Core.ExecutionState.Stopped) {
         this.timer.Interval = (int)new TimeSpan(0, 0, 10).TotalMilliseconds;
-        this.timer.Tick += new EventHandler(timer_Tick);
         this.timer.Start();
-        AddAllSlavesToHeartbeats();
       }
     }
@@ -74 +52 @@
 
     /// <summary>
-    // add all slaves to hearbeats-collection and give them some time to say hello (HEARTBEAT_TIMEOUT)
-    // otherwise alls the slaves jobs would be aborted immediately, which is not desirable if the server has just been restarted
-    /// </summary>
-    private void AddAllSlavesToHeartbeats() {
-      lock (locker) {
-        using (trans.OpenTransaction()) {
-          Guid[] slaveIds = dao.GetSlaves(x => true).Select(s => s.Id).ToArray();
-          foreach (Guid slaveId in slaveIds) {
-            if (!heartbeats.ContainsKey(slaveId)) {
-              heartbeats.Add(slaveId, DateTime.Now);
-            }
-          }
-        }
-      }
-    }
-
-    /// <summary>
     /// This method is supposed to check if slaves are online
     /// if not -> set them offline and check if they where calculating a job
@@ -97 +58 @@
       lock (locker) {
         using (trans.OpenTransaction()) {
-          Guid[] slaveIds = dao.GetSlaves(x => true).Select(s => s.Id).ToArray();
-          foreach (Guid slaveId in slaveIds) {
-            if (SlaveTimedOut(slaveId)) {
-              var slave = dao.GetSlave(slaveId);
-              if (slave.SlaveState != SlaveState.Offline) {
-                AbortJobs(slaveId);
-                slave.SlaveState = SlaveState.Offline;
-                dao.UpdateSlave(slave);
-              }
-              heartbeats.Remove(slaveId);
+          var slaves = dao.GetSlaves(x => x.SlaveState != SlaveState.Offline);
+          foreach (Slave slave in slaves) {
+            if (!slave.LastHeartbeat.HasValue || (DateTime.Now - slave.LastHeartbeat.Value).TotalSeconds > ApplicationConstants.HeartbeatTimeout) {
+              slave.SlaveState = SlaveState.Offline;
+              AbortJobs(slave.Id);
+              dao.UpdateSlave(slave);
             }
           }
         }
       }
-    }
-
-    private bool SlaveTimedOut(Guid slaveId) {
-      if (!heartbeats.ContainsKey(slaveId))
-        return true;
-
-      if ((DateTime.Now - heartbeats[slaveId]).TotalSeconds > ApplicationConstants.HeartbeatTimeout) {
-        return true;
-      }
-
-      return false;
     }
 
@@ -131 +77 @@
       }
     }
-
-    /// <summary>
-    /// This method will be called every time a slave sends a heartbeat (-> very often; concurrency is important!)
-    /// </summary>
-    /// <returns>a list of actions the slave should do</returns>
-    public List<MessageContainer> ProcessHeartbeat(Heartbeat heartbeat) {
-      List<MessageContainer> actions = new List<MessageContainer>();
-      Slave slave = dao.GetSlave(heartbeat.SlaveId);
-      if (slave == null) {
-        actions.Add(new MessageContainer(MessageContainer.MessageType.SayHello));
-      } else {
-        heartbeats[heartbeat.SlaveId] = DateTime.Now;
-        actions.AddRange(UpdateJobs(heartbeat));
-
-        if (this.IsAllowedToSendJobs() && slave.IsAllowedToCalculate && heartbeat.FreeCores > 0) {
-          var availableJobs = dao.GetWaitingJobs(slave, 1);
-          if (availableJobs.Count() > 0) {
-            var job = availableJobs.First();
-            actions.Add(new MessageContainer(MessageContainer.MessageType.CalculateJob, job.Id));
-            AssignJob(slave, job);
-          }
-        }
-
-        if (slave.FreeCores != heartbeat.FreeCores ||
-            slave.FreeMemory != heartbeat.FreeMemory ||
-            slave.IsAllowedToCalculate != heartbeat.IsAllowedToCalculate ||
-            slave.SlaveState != (heartbeat.JobProgress.Count > 0 ? SlaveState.Calculating : SlaveState.Idle)) { // only update slave when something changed, to avoid unnecessary updates
-          slave.FreeCores = heartbeat.FreeCores;
-          slave.FreeMemory = heartbeat.FreeMemory;
-          slave.IsAllowedToCalculate = heartbeat.IsAllowedToCalculate;
-          slave.SlaveState = (heartbeat.JobProgress != null && heartbeat.JobProgress.Count > 0) ? SlaveState.Calculating : SlaveState.Idle;
-          dao.UpdateSlave(slave);
-        }
-      }
-      return actions;
-    }
-
-    private void AssignJob(Slave slave, Job job) {
-      job.SlaveId = slave.Id;
-      job.JobState = JobState.Calculating; // Todo: Maybe use State = Transferring (?)
-      job.DateCalculated = DateTime.Now; // Todo: use statelog instead
-      dao.UpdateJob(job);
-      dao.UpdateSlave(slave);
-    }
-
-    /// <summary>
-    /// Update the progress of each job
-    /// Checks if all the jobs sent by heartbeat are supposed to be calculated by this slave
-    /// </summary>
-    private IEnumerable<MessageContainer> UpdateJobs(Heartbeat heartbeat) {
-      List<MessageContainer> actions = new List<MessageContainer>();
-
-      if (heartbeat.JobProgress == null)
-        return actions;
-
-      // process the jobProgresses
-      foreach (var jobProgress in heartbeat.JobProgress) {
-        Job curJob = dao.GetJob(jobProgress.Key);
-        if (curJob == null) {
-          // job does not exist in db
-          actions.Add(new MessageContainer(MessageContainer.MessageType.AbortJob, jobProgress.Key));
-          Logger.Error("Job does not exist in DB: " + jobProgress.Key);
-        } else {
-          if (curJob.SlaveId == Guid.Empty || curJob.SlaveId != heartbeat.SlaveId) {
-            // assigned slave does not match heartbeat
-            actions.Add(new MessageContainer(MessageContainer.MessageType.AbortJob, curJob.Id));
-            Logger.Error("The slave " + heartbeat.SlaveId + " is not supposed to calculate Job: " + curJob);
-          } else {
-            // save job execution time
-            curJob.ExecutionTime = jobProgress.Value;
-
-            if (curJob.JobState == JobState.Aborted) {
-              // a request to abort the job has been set
-              actions.Add(new MessageContainer(MessageContainer.MessageType.AbortJob, curJob.Id));
-            }
-            dao.UpdateJob(curJob);
-          }
-        }
-      }
-      return actions;
-    }
-
-    /// <summary>
-    /// Returns true if there are enough resources to send a job
-    /// There should not be too many jobs sent simultaniously
-    /// </summary>
-    private bool IsAllowedToSendJobs() {
-      return JobsCurrentlyTransferring < ApplicationConstants.MaxJobTransferCount;
-    }
   }
 }

branches/HeuristicLab.Hive-3.4/sources/HeuristicLab.Services.Hive/3.4/ServiceLocator.cs

@@ -48 +48 @@
       }
     }
+
+    private HeartbeatManager heartbeatManager;
+    public HeartbeatManager HeartbeatManager {
+      get {
+        if(heartbeatManager == null) heartbeatManager = new HeartbeatManager();
+        return heartbeatManager;
+      }
+    }
   }
 }