Changeset 5341

Timestamp:

01/20/11 17:51:36 (14 years ago)

Author:

mkommend

Message:

Corrected minor flaw regarding equal classification scores during the calculation of the optimal thresholds (ticket #1383).

File:

• trunk/sources/HeuristicLab.Problems.DataAnalysis.Classification/3.3/Symbolic/SymbolicClassificationSolution.cs (modified) (2 diffs)

trunk/sources/HeuristicLab.Problems.DataAnalysis.Classification/3.3/Symbolic/SymbolicClassificationSolution.cs

@@ -114 +114 @@
         double highestBestThreshold = double.NaN;
         double bestClassificationScore = double.PositiveInfinity;
+        bool seriesOfEqualClassificationScores = false;
 
         while (actualThreshold < originalClasses[i]) {
@@ -138 +139 @@
             }
           }
+
+          //new best classification score found
           if (classificationScore < bestClassificationScore) {
             bestClassificationScore = classificationScore;
             lowestBestThreshold = actualThreshold;
             highestBestThreshold = actualThreshold;
-          } else if (Math.Abs(classificationScore - bestClassificationScore) < double.Epsilon)
+            seriesOfEqualClassificationScores = true;
+          }
+            //equal classification scores => if seriesOfEqualClassifcationScores == true update highest threshold
+          else if (Math.Abs(classificationScore - bestClassificationScore) < double.Epsilon && seriesOfEqualClassificationScores)
             highestBestThreshold = actualThreshold;
+          //worse classificatoin score found reset seriesOfEqualClassifcationScores
+          else seriesOfEqualClassificationScores = false;
 
           actualThreshold += thresholdIncrement;
         }
+        //scale lowest thresholds and highest found optimal threshold according to the misclassification matrix
         double falseNegativePenalty = ProblemData.MisclassificationMatrix[i, i - 1];
         double falsePositivePenalty = ProblemData.MisclassificationMatrix[i - 1, i];