Changeset 5207 for branches/HeuristicLab.MetaOptimization/HeuristicLab.Problems.MetaOptimization/3.3/Encoding/ParameterConfigurations

Timestamp:

01/04/11 02:18:27 (14 years ago)

Author:

cneumuel

Message:

#1215

• lots of memory-consumption improvements
• validValues -> validTypes (this saves memory!)
• changed manipulators; modifications are less significant, out-of-bound-values are resampled instead of set to lower or upper bound
• changed the way a base-level algorithm gets executed -> introduced AlgorithmExecutor

File:

• branches/HeuristicLab.MetaOptimization/HeuristicLab.Problems.MetaOptimization/3.3/Encoding/ParameterConfigurations/ParameterConfiguration.cs (modified) (8 diffs)

branches/HeuristicLab.MetaOptimization/HeuristicLab.Problems.MetaOptimization/3.3/Encoding/ParameterConfigurations/ParameterConfiguration.cs

@@ -10 +10 @@
 using HeuristicLab.PluginInfrastructure;
 using System.Text;
+using System.Reflection;
 
 namespace HeuristicLab.Problems.MetaOptimization {
   [StorableClass]
   public class ParameterConfiguration : Item, IParameterConfiguration, IStorableContent {
-    public bool IsOptimizable { 
-      get { return true; } 
+    public bool IsOptimizable {
+      get { return true; }
     }
 
@@ -58 +59 @@
 
     [Storable]
-    protected IItemSet<IItem> validValues;
-    public IItemSet<IItem> ValidValues {
-      get { return validValues; }
+    protected Type[] validTypes;
+    public Type[] ValidTypes {
+      get { return validTypes; }
       protected set {
-        if (this.validValues != value) {
-          this.validValues = value;
+        if (this.validTypes != value) {
+          this.validTypes = value;
         }
       }
@@ -124 +125 @@
       this.parameterDataType = valueParameter.GetType();
       this.valueDataType = valueParameter.DataType;
-      this.validValues = GetValidValues(valueParameter);
+      this.validTypes = GetValidTypes(valueParameter).ToArray();
       this.IsNullable = valueParameter.ItemName.StartsWith("Optional");
       if (IsNullable) {
-        validValues.Add(new NullValue());
-      }
-      this.ValueConfigurations = new CheckedValueConfigurationCollection(this.validValues);
-      this.ActualValue = new ConstrainedValue(valueParameter.Value, valueParameter.DataType, this.ValidValues, this.IsNullable);
+        validTypes = new List<Type>(validTypes) { typeof(NullValue) }.ToArray();
+      }
+      this.ValueConfigurations = new CheckedValueConfigurationCollection(this.validTypes);
+      this.ActualValue = new ConstrainedValue(valueParameter.Value != null ? (IItem)valueParameter.Value.Clone() : null, valueParameter.DataType, this.ValidTypes, this.IsNullable);
       if (Optimize) {
         PopulateValueConfigurations();
@@ -139 +140 @@
     [StorableConstructor]
     protected ParameterConfiguration(bool deserializing) { }
-    protected ParameterConfiguration(ParameterConfiguration original, Cloner cloner) : base(original, cloner) {
+    protected ParameterConfiguration(ParameterConfiguration original, Cloner cloner)
+      : base(original, cloner) {
       this.parameterName = original.ParameterName;
       this.parameterDataType = original.parameterDataType;
       this.valueDataType = original.ValueDataType;
-      this.validValues = cloner.Clone(original.ValidValues);
+      this.validTypes = original.validTypes.ToArray();
       this.valueConfigurations = cloner.Clone(original.ValueConfigurations);
       this.ActualValue = cloner.Clone(original.ActualValue);
@@ -180 +182 @@
 
     private void PopulateValueConfigurations() {
-      foreach (IItem validValue in this.validValues) {
-        if (validValue is NullValue) {
+      foreach (Type t in this.validTypes) {
+        if (t == typeof(NullValue)) {
           this.ValueConfigurations.Add(new NullValueConfiguration());
         } else {
           IItem val;
-          if (ActualValue.Value != null && ActualValue.ValueDataType == validValue.GetType()) {
+          if (ActualValue.Value != null && ActualValue.ValueDataType == t) {
             val = ActualValue.Value; // use existing value for that type (if available)
           } else {
-            val = validValue;
+            val = (IItem)Activator.CreateInstance(t);
           }
           this.ValueConfigurations.Add(new ValueConfiguration(val, val.GetType()), true);
@@ -195 +197 @@
     }
 
-    private IItemSet<IItem> GetValidValues(IValueParameter parameter) {
-      if (IsSubclassOfRawGeneric(typeof(OptionalConstrainedValueParameter<>), parameter.GetType())) {
-        var x = (IEnumerable)parameter.GetType().GetProperty("ValidValues").GetValue(parameter, new object[] { });
-        return new ItemSet<IItem>(x.Cast<IItem>());
-      } else {
-        return new ItemSet<IItem>(ApplicationManager.Manager.GetInstances(valueDataType).Select(x => (IItem)x).OrderBy(x => x.ItemName));
-      }
+    private IEnumerable<Type> GetValidTypes(IValueParameter parameter) {
+      //if (IsSubclassOfRawGeneric(typeof(OptionalConstrainedValueParameter<>), parameter.GetType())) {
+      //  var x = (IEnumerable)parameter.GetType().GetProperty("ValidValues").GetValue(parameter, new object[] { });
+      //  return new ItemSet<IItem>(x.Cast<IItem>());
+      //} else {
+      //  return new ItemSet<IItem>(ApplicationManager.Manager.GetInstances(valueDataType).Select(x => (IItem)x).OrderBy(x => x.ItemName));
+      //}
+      return ApplicationManager.Manager.GetTypes(valueDataType, true);
     }
 
@@ -278 +281 @@
       if (handler != null) handler(sender, e);
     }
-    
+
     public virtual event EventHandler IsOptimizableChanged;
     private void OnIsOptimizableChanged() {
@@ -333 +336 @@
         }
       }
-      parameter.Value = this.ActualValue.Value;
+      var clonedValue = this.ActualValue.Value != null ? (IItem)this.ActualValue.Value.Clone() : null;
+      AdaptValidValues(parameter, clonedValue);
+      parameter.Value = clonedValue;
+    }
+
+    /// <summary>
+    /// Adds value to the ValidValues of the parameter if they don't contain the value
+    /// </summary>
+    private void AdaptValidValues(IValueParameter parameter, IItem value) {
+      // this requires some tricky reflection, because the type is unknown at runtime so parameter.ValidValues cannot be casted to Collection<?>
+      if (IsSubclassOfRawGeneric(typeof(OptionalConstrainedValueParameter<>), parameter.GetType())) {
+        var validValues = parameter.GetType().GetProperty("ValidValues").GetValue(parameter, new object[] { });
+        Type validValuesType = validValues.GetType();
+
+        var containsMethod = validValuesType.GetMethod("Contains");
+        if (!(bool)containsMethod.Invoke(validValues, new object[] { value })) {
+          var addMethod = validValuesType.GetMethod("Add");
+          addMethod.Invoke(validValues, new object[] { value });
+        }
+      }
     }