Changeset 4947

Timestamp:

11/26/10 17:14:16 (14 years ago)

Author:

epitzer

Message:

Simpler breakpoint handling, fix cloning, prevent stepping while running (#47)

Location:

branches/HeuristicLab.DebugEngine

Files:

• DebugEngine.cs (modified) (13 diffs)
• DebugEngineView.cs (modified) (1 diff)

branches/HeuristicLab.DebugEngine/DebugEngine.cs

@@ -48 +48 @@
       Log = cloner.Clone(original.Log);
       ExecutionStack = cloner.Clone(original.ExecutionStack);
-      OperatorTrace = cloner.Clone(OperatorTrace);
+      OperatorTrace = cloner.Clone(original.OperatorTrace);
       operatorParents = original.operatorParents.ToDictionary(kvp => cloner.Clone(kvp.Key), kvp => cloner.Clone(kvp.Value));
       pausePending = original.pausePending;
@@ -94 +94 @@
 
     [Storable]
-    private bool ignoreNextBreakpoint;
-
-    [Storable]
     private IOperation currentOperation;
     public virtual IOperation CurrentOperation {
@@ -122 +119 @@
     private Dictionary<IAtomicOperation, IAtomicOperation> operatorParents;
 
+    public virtual bool CanContinue {
+      get { return CurrentOperation != null || ExecutionStack.Count > 0; }
+    }
+
+    public virtual bool IsAtBreakpoint {
+      get { return CurrentAtomicOperation != null && CurrentAtomicOperation.Operator != null && CurrentAtomicOperation.Operator.Breakpoint; }
+    }
+
     #endregion
 
@@ -140 +145 @@
       base.Prepare();
       ExecutionStack.Clear();
-      ignoreNextBreakpoint = false;
       CurrentOperation = null;
       OperatorTrace.Clear();
@@ -151 +155 @@
       if (initialOperation != null)
         ExecutionStack.Add(initialOperation);
-      ignoreNextBreakpoint = false;
       CurrentOperation = null;
       OperatorTrace.Clear();
@@ -165 +168 @@
       OnStarted();
       lastUpdateTime = DateTime.Now;
-      ignoreNextBreakpoint = true;
       timer.Start();
       ProcessNextOperation();
@@ -172 +174 @@
       timer.Stop();
       ExecutionTime += DateTime.Now - lastUpdateTime;
-      ignoreNextBreakpoint = false;
       OnPaused();
     }
@@ -202 +203 @@
       stopPending = true;
       if (currentOperator != null) currentOperator.Abort();
-      ignoreNextBreakpoint = false;
       if (ExecutionState == ExecutionState.Paused) OnStopped();
     }
@@ -222 +222 @@
       lastUpdateTime = DateTime.Now;
       timer.Start();
-      while (!pausePending && !stopPending && CanContinue) {
+      if (!pausePending && !stopPending && CanContinue)
         ProcessNextOperation();
-      }
+      while (!pausePending && !stopPending && CanContinue && !IsAtBreakpoint)
+        ProcessNextOperation();
       timer.Stop();
       ExecutionTime += DateTime.Now - lastUpdateTime;
 
-      if (pausePending) OnPaused();
-      else OnStopped();
+      if (IsAtBreakpoint)
+        Log.LogMessage(string.Format("Breaking before: {0}", CurrentAtomicOperation.Operator.Name));
+      if (pausePending || IsAtBreakpoint)
+        OnPaused();
+      else
+        OnStopped();
     }
 
@@ -241 +246 @@
     #region Methods
 
-    public virtual bool CanContinue {
-      get { return CurrentOperation != null || ExecutionStack.Count > 0; }
-    }
+
 
     /// <summary>
@@ -274 +277 @@
         }
         GenerateOperationTrace();
-      }
-      catch (Exception x) {
+      } catch (Exception x) {
         OnExceptionOccurred(x);
       }
@@ -298 +300 @@
     protected virtual void PerformAtomicOperation(IAtomicOperation operation) {
       if (operation != null) {
-        if (operation.Operator.Breakpoint) {
-          if (ignoreNextBreakpoint) {
-            ignoreNextBreakpoint = false;
-          } else {
-            ignoreNextBreakpoint = true;
-            Log.LogMessage(string.Format("Breaking before: {0}", Name(operation)));
-            Pause();
-            return;
-          }
-        }
         try {
           currentOperator = operation.Operator;
@@ -317 +309 @@
           currentOperator = null;
           CurrentOperation = null;
-        }
-        catch (Exception ex) {
+        } catch (Exception ex) {
           OnExceptionOccurred(new OperatorExecutionException(operation.Operator, ex));
           Pause();

branches/HeuristicLab.DebugEngine/DebugEngineView.cs

@@ -95 +95 @@
         refreshButton.Enabled = false;
       } else {
-        stepButton.Enabled = Content.CanContinue;
-        refreshButton.Enabled = Content.CurrentAtomicOperation != null;
+        stepButton.Enabled = Content.CanContinue && Content.ExecutionState != ExecutionState.Started;
+        refreshButton.Enabled = Content.CurrentAtomicOperation != null && Content.ExecutionState != ExecutionState.Started;
       }
     }