Changeset 4632

Timestamp:

10/21/10 10:23:14 (14 years ago)

Author:

mkommend

Message:

Corrected PluginDependenciesTest to check unnecessary dependencies (ticket #1239).

File:

• trunk/sources/HeuristicLab/3.3/Tests/PluginDependenciesTest.cs (modified) (3 diffs)

trunk/sources/HeuristicLab/3.3/Tests/PluginDependenciesTest.cs

@@ -33 +33 @@
     private static Dictionary<Assembly, Type> loadedPlugins;
     private static Dictionary<string, string> pluginNames;
+    private static HashSet<string> extLibPluginNames;
 
     // Use ClassInitialize to run code before running the first test in the class
@@ -38 +39 @@
     public static void MyClassInitialize(TestContext testContext) {
       loadedPlugins = PluginLoader.pluginAssemblies.ToDictionary(a => a, GetPluginFromAssembly);
-      pluginNames = loadedPlugins.ToDictionary(a => a.Key.GetName().FullName,
-                                                                          a => GetPluginName(a.Value));
+      pluginNames = loadedPlugins.ToDictionary(a => a.Key.GetName().FullName, a => GetPluginName(a.Value));
+
+      extLibPluginNames = new HashSet<string>();
+      extLibPluginNames.Add("HeuristicLab.ALGLIB");
+      extLibPluginNames.Add("HeuristicLab.LibSVM");
+      extLibPluginNames.Add("HeuristicLab.log4net");
+      extLibPluginNames.Add("HeuristicLab.Netron");
+      extLibPluginNames.Add("HeuristicLab.ProtobufCS");
+      extLibPluginNames.Add("HeuristicLab.SharpDevelop");
+      extLibPluginNames.Add("HeuristicLab.WinFormsUI");
     }
 
@@ -69 +78 @@
         foreach (PluginDependencyAttribute attribute in pluginDependencies.Keys) {
           string pluginDependencyName = pluginDependencies[attribute];
-          if (pluginAssembly.GetReferencedAssemblies()
-            .All(a => pluginNames.ContainsKey(a.FullName) && pluginNames[a.FullName] != pluginDependencyName)) {
+          //do not check extlib plugins, because the transport assemblies are never referenced in the assemblies
+          if (extLibPluginNames.Contains(pluginDependencyName)) continue;
+          if (pluginAssembly.GetReferencedAssemblies().Where(a => pluginNames.ContainsKey(a.FullName))
+            .All(a => pluginNames[a.FullName] != pluginDependencyName)) {
             errorMessage.AppendLine("Unnecessary plugin dependency in " + GetPluginName(plugin) + " to " + pluginDependencyName + ".");
           }